Re: [Dots] [yang-doctors] Yangdoctors early review of draft-ietf-dots-telemetry-09

mohamed.boucadair@orange.com Wed, 01 July 2020 10:06 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: dots@ietfa.amsl.com
Delivered-To: dots@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 745943A0D5D; Wed, 1 Jul 2020 03:06:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.096
X-Spam-Level:
X-Spam-Status: No, score=-2.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=orange.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JPdLLFx_P8ly; Wed, 1 Jul 2020 03:06:09 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.66.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A0D93A0D5C; Wed, 1 Jul 2020 03:06:09 -0700 (PDT)
Received: from opfedar03.francetelecom.fr (unknown [xx.xx.xx.5]) by opfedar27.francetelecom.fr (ESMTP service) with ESMTP id 49xcLk6bMtz2xHF; Wed, 1 Jul 2020 12:06:06 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.com; s=ORANGE001; t=1593597966; bh=MHscM3i71TDB5W8xNbuk54FrTSrKhWjWYrneddA8oHQ=; h=From:To:Subject:Date:Message-ID:Content-Type: Content-Transfer-Encoding:MIME-Version; b=s/8WqqyZeZZW1/MFnB/PfylNXOcargd9dYZgn98Q4/4OwIEZ94rTDfv2/V5FiHvKk XE/FAOCmNpxsNu/q7Jm1YJsfcMrMSnrF1xxOg0c68Sx840LpDyfRHhu+yUZcatLBJ2 3I+hofL2f+OvYjEew1NiHV8D0xbG+MsN1NEvTK52rn6flct7LdUpgmzO07yNUSkKwC NdXY4RIUl7IWsLimqmSziqh6VeY1PEOZuSNgIo2H2F8d1ebQ6aLIKz7BZgqi6jMOct P34mlSUTNDUqFIladz2JjHJNoPo6p6kRJ4+UFq+gxSDTClsv0qcOyriWtwEMxBl7qf hZlzicxDh3zEQ==
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.107]) by opfedar03.francetelecom.fr (ESMTP service) with ESMTP id 49xcLk57dPzCql1; Wed, 1 Jul 2020 12:06:06 +0200 (CEST)
From: mohamed.boucadair@orange.com
To: Martin Björklund <mbj+ietf@4668.se>
CC: "janl@tail-f.com" <janl@tail-f.com>, "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-dots-telemetry.all@ietf.org" <draft-ietf-dots-telemetry.all@ietf.org>, "dots@ietf.org" <dots@ietf.org>
Thread-Topic: [yang-doctors] Yangdoctors early review of draft-ietf-dots-telemetry-09
Thread-Index: AQHWT4ZwyLUzg4toRReM83kxwr9eLajyb1qg
Date: Wed, 01 Jul 2020 10:06:06 +0000
Message-ID: <28429_1593597966_5EFC600E_28429_155_28_787AE7BB302AE849A7480A190F8B9330314EB8B7@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <159353177839.29172.8254735147639701580@ietfa.amsl.com> <20200630.201818.699105283686964442.id@4668.se> <20313_1593585670_5EFC3006_20313_116_1_787AE7BB302AE849A7480A190F8B9330314EA69B@OPEXCAUBMA2.corporate.adroot.infra.ftgroup> <20200701.110308.454388377905104310.id@4668.se>
In-Reply-To: <20200701.110308.454388377905104310.id@4668.se>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.247]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/dots/pjgPeAY07obHSoFaQF26gI0JMbI>
Subject: Re: [Dots] [yang-doctors] Yangdoctors early review of draft-ietf-dots-telemetry-09
X-BeenThere: dots@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for discussion of DDoS Open Threat Signaling \(DOTS\) technology and directions." <dots.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dots>, <mailto:dots-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dots/>
List-Post: <mailto:dots@ietf.org>
List-Help: <mailto:dots-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dots>, <mailto:dots-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Jul 2020 10:06:12 -0000

Re-,

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : Martin Björklund [mailto:mbj+ietf@4668.se]
> Envoyé : mercredi 1 juillet 2020 11:03
> À : BOUCADAIR Mohamed TGI/OLN
> Cc : janl@tail-f.com; yang-doctors@ietf.org; draft-ietf-dots-
> telemetry.all@ietf.org; dots@ietf.org
> Objet : Re: [yang-doctors] Yangdoctors early review of draft-ietf-dots-
> telemetry-09
> 
> > >
> > > You may also want to look at RFC 8791, which defines a new YANG
> > > extension statement "sx:structure".  This statement can be used to
> > > define messages that are not intended to be generic rpcs or
> > > notifications.
> > >
> > >
> >
> > [Med] Thanks for the pointer, Martin.
> >
> > Importing ietf-yang-structure-ext + s/container
> > dots-signal/sx:structure in ietf-dots-signal-channel (RFC8782) would
> > be sufficient to define the structure as per RFC8791 but we will lose
> > the "tagging" of parts of the structure/schema that applies only in
> > the server to client direction.
> >
> > We used rw/ro so that we can have a compact module/structure that can
> > be used in both directions of the DOTS communication, rather than
> > defining two structures.
> >
> > The good news is that with both the current approach in RFC8782 and an
> > updated one that strictly follows RFC 8791, we will have the same
> > JSON/CBOR mappings that are authoritative for our spec (Section 6 of
> > RFC8782).
> >
> > Given that we don't have interoperability issues, would it be OK with
> > you if we update draft-ietf-dots-telemetry to add a reference to
> > inform the reader about RFC8791 and that we are not using it here
> > because we are augmenting a module not using sx:structure?
> >
> > If there is any RFC8782bis in the future, making changes to follow
> > RFC8791 will be part of the things to be considered.
> 
> It seems that the YANG modules in RFC8782 were never reviewed by the
> YANG doctors.  Please correct me if this was not the case.
> 

[Med] RFC8782 is a complex doc that manipulates many pieces from various areas. We had to pay attention to many things. I don't remember we received a yangdoctors review as part of the IETF LC, though. 

> So RFC 8782 seems to have the same fundamental problem as this draft.
> 

[Med] We can't use RFC8791 in draft-ietf-dots-telemetry because : "since a YANG compiler or other tool is not required to understand the "structure" extension.". 

This is why I made the proposal to record this in the draft so that this can be scheduled for future bis work of 8782. Fundamentally, we will come up with close structure (less compact with 8791). 

Given the conventions set in the RFC and that we are clearly saying that the module is not intended for NETCONF/RESTCONF use, is there any interoperability issue that you foresee?


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.