IETF Logo Mail Archive

Re: [Emu] draft-ietf-emu-eap-tls13-16.txt

Alan DeKok <aland@deployingradius.com> Thu, 17 June 2021 17:55 UTC

Return-Path: <aland@deployingradius.com>
X-Original-To: emu@ietfa.amsl.com
Delivered-To: emu@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A86A03A286A for <emu@ietfa.amsl.com>; Thu, 17 Jun 2021 10:55:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YdNP9tBuPwgT for <emu@ietfa.amsl.com>; Thu, 17 Jun 2021 10:55:51 -0700 (PDT)
Received: from mail.networkradius.com (mail.networkradius.com [62.210.147.122]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 50FCA3A2869 for <emu@ietf.org>; Thu, 17 Jun 2021 10:55:51 -0700 (PDT)
Received: from [192.168.46.129] (24-52-251-6.cable.teksavvy.com [24.52.251.6]) by mail.networkradius.com (Postfix) with ESMTPSA id 5A23552B; Thu, 17 Jun 2021 17:55:48 +0000 (UTC)
Authentication-Results: NetworkRADIUS; dmarc=none (p=none dis=none) header.from=deployingradius.com
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
From: Alan DeKok <aland@deployingradius.com>
In-Reply-To: <HE1PR0701MB3050725DA65963DCAB065A90890E9@HE1PR0701MB3050.eurprd07.prod.outlook.com>
Date: Thu, 17 Jun 2021 13:55:46 -0400
Cc: Joseph Salowey <joe@salowey.net>, Bernard Aboba <bernard.aboba@gmail.com>, Mohit Sethi M <mohit.m.sethi@ericsson.com>, EMU WG <emu@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <63475285-E12B-43FA-9340-CCE99B50ECF9@deployingradius.com>
References: <CAOgPGoBXRAABeC_kCcCrsUPC03e8C_GGpzJHB+aWAue5sE=9zw@mail.gmail.com> <4789411B-9D6A-4A33-B465-DCEC2369E671@deployingradius.com> <BA5BC7E9-EC6F-4A10-9F19-284572AF2710@deployingradius.com> <ac3fda5a-65ef-0e57-fdb0-fffdc08bb9e1@ericsson.com> <4F473CF1-CE5C-4834-AF7E-7FCB2457B199@deployingradius.com> <CAOgPGoCoFRF-0uowFiVRtDyWATzr0d3pNKz7DJo5CDBesiDP5Q@mail.gmail.com> <7B957BC5-DEC4-48D6-A032-C8AC1CBFD210@deployingradius.com> <HE1PR0701MB3050725DA65963DCAB065A90890E9@HE1PR0701MB3050.eurprd07.prod.outlook.com>
To: John Mattsson <john.mattsson@ericsson.com>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/emu/drN3e734eiUQcfgLVPwHbSz5NTQ>
Subject: Re: [Emu] draft-ietf-emu-eap-tls13-16.txt
X-BeenThere: emu@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "EAP Methods Update \(EMU\)" <emu.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/emu>, <mailto:emu-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/emu/>
List-Post: <mailto:emu@ietf.org>
List-Help: <mailto:emu-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/emu>, <mailto:emu-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jun 2021 17:55:56 -0000

On Jun 17, 2021, at 12:04 PM, John Mattsson <john.mattsson@ericsson.com> wrote:
> I have made a single PR addressing all the currently listed issues in the way suggested by Joe.
>  
> https://github.com/emu-wg/draft-ietf-emu-eap-tls13/pull/83/files
>  
> - Does PR #83 address the currently listed issues?

  I'll have to go through it and see.  It's normally traditional to respond to reviews.  And, to reply with proposed text for the document update.  That process allows reviewers to quickly see if their issues have been addressed.

  The current use of GitHub makes this process rather more opaque.  There are changes to the document pushed as commits, but it requires rooting through multiple commits and references in order to see which commit addresses which issue.  The many commits of "updated document" make it more difficult to see what is changed, and why.

> - Are there any other remaining issues that are not listed on GitHub?

  My review of a few days ago had extensive comments.  It may be worth going through that and addressing each issue.  Some of the items have been addressed, which is positive.  However, it looks like all of my comments for Section 5 remain unaddressed.

  Alan DeKok.

v2.23.0 | Report a Bug | By Email