Re: [Gen-art] Gen-ART review of draft-ietf-v6ops-siit-dc-2xlat-01

Tore Anderson <tore@redpill-linpro.com> Wed, 07 October 2015 09:54 UTC

Return-Path: <tore@redpill-linpro.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CCA801B2D04 for <gen-art@ietfa.amsl.com>; Wed, 7 Oct 2015 02:54:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.6
X-Spam-Level:
X-Spam-Status: No, score=-2.6 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 89Ge5ObmzFDS for <gen-art@ietfa.amsl.com>; Wed, 7 Oct 2015 02:54:11 -0700 (PDT)
Received: from gallus.zimbra.h.bitbit.net (gallus.zimbra.h.bitbit.net [87.238.49.226]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7DF7E1B2D06 for <gen-art@ietf.org>; Wed, 7 Oct 2015 02:54:11 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by gallus.zimbra.h.bitbit.net (Postfix) with ESMTP id 542D3C128B; Wed, 7 Oct 2015 11:54:09 +0200 (CEST)
Received: from gallus.zimbra.h.bitbit.net ([127.0.0.1]) by localhost (gallus.zimbra.h.bitbit.net [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id oa5lqeUBytkh; Wed, 7 Oct 2015 11:54:08 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1]) by gallus.zimbra.h.bitbit.net (Postfix) with ESMTP id 150EFC12F7; Wed, 7 Oct 2015 11:54:08 +0200 (CEST)
X-Virus-Scanned: amavisd-new at gallus.zimbra.h.bitbit.net
Received: from gallus.zimbra.h.bitbit.net ([127.0.0.1]) by localhost (gallus.zimbra.h.bitbit.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OYgdvKISQ5jk; Wed, 7 Oct 2015 11:54:07 +0200 (CEST)
Received: from echo.ms.redpill-linpro.com (login-osl1.i.bitbit.net [87.238.42.59]) by gallus.zimbra.h.bitbit.net (Postfix) with ESMTPSA id D620BC128B; Wed, 7 Oct 2015 11:54:07 +0200 (CEST)
Date: Wed, 07 Oct 2015 11:54:07 +0200
From: Tore Anderson <tore@redpill-linpro.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
Message-ID: <20151007115407.53e95348@echo.ms.redpill-linpro.com>
In-Reply-To: <7594FB04B1934943A5C02806D1A2204B37A84174@ESESSMB209.ericsson.se>
References: <7594FB04B1934943A5C02806D1A2204B37A84174@ESESSMB209.ericsson.se>
Organization: Redpill Linpro AS
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/0EiNS-zrAQ3-hEVP16WM4X5Z1Ho>
Cc: "draft-ietf-v6ops-siit-dc-2xlat.all@tools.ietf.org" <draft-ietf-v6ops-siit-dc-2xlat.all@tools.ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-v6ops-siit-dc-2xlat-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Oct 2015 09:54:14 -0000

Hi again Christer, and thanks again for reviewing!

* Christer Holmberg <christer.holmberg@ericsson.com>

> Section 2 (Terminology):
> ------------------------------
> 
> Q2_1: Many of the definitions have been defined in
> draft-ietf-v6ops-siit-dc. Now they are re-defined, and sometimes with
> a little different wording.
> 
> For those definitions, my suggestion would be to say:
> 
> "As defined in [draft-ietf-v6ops-siit-dc], a XXX is a blah blah blah"
> - copy/pasting the text from draft-ietf-v6ops-siit-dc.

Ack. I simply copied the definitions from -siit-dc (without the "As
defined in..." prefix you proposed, since I think it would be rather
repetitive).

The only definition that is not identical between -siit-dc and
-siit-dc-2xlat now is the ER one; the [draft-ietf-v6ops-siit-dc-2xlat]
reference is removed in -siit-dc-2xlat, instead your Q2_2 suggestion is
added. Hope that's fine.

> Q2_2: In the Edge Relay, I think it would be good to mention the two
> types (node-based and network-based).

Fixed. References to the appropriate sections defining the two variants
also added.

> Section 4 (Deployment Considerations):
> ---------------------------------------------------
> 
> Q4_1:
> 
> The text in section 4.1. says:
> 
>                              "The IPv6 Path MTU between the ER and
> the BR will typically be larger than the default value defined in
> Section 4 of [RFC6145] (1280),"
> 
> What is (1280)?

Bytes. Fixed.

> Section 5 (Intra-IDC IPv4 Communication):
> ---------------------------------------------------
> 
> Q5_1:
> 
> The text in section 5.1 says:
> 
> "If the BR supports hairpinning as described in Section 4.2 of I-D
>    .ietf-v6ops-siit-eam [I-D.ietf-v6ops-siit-eam],"
> 
> I suggest to remove I-D.ietf-v6ops-siit-eam. The reference is enough.

Fixed.

> Section 7 (IANA Considerations):
> ----------------------------------------
> 
> Q7_1: Do we normally remove the section if there are no requests from
> IANA? Personally I prefer to keep the explicit "This draft makes no
> request of the IANA." sentence.

Fixed.

> Section 8 (Security Considerations):
> ----------------------------------------
> 
> Q8_1:
> 
> The text says:
> 
> "See the Security Considerations section in
>    [I-D.ietf-v6ops-siit-dc] for additional security considerations
>    applicable to the SIIT-DC architecture in general."
> 
> I suggest to remove "additional".

Fixed.

> Q8_2:
> 
> Is there a need to have section 8.1, or can all text be put in
> section 8?

I supposed not. Fixed.

The changes implemented can be seen here:

https://github.com/toreanderson/ietf/commit/c22ca60c39eb0d98506ce7bae252cf5327be6acf

Please have a look and let me know if further changes are required, in
your opinion. Thanks again!

Best regards,
Tore Anderson