Re: [Gen-art] Genart last call review of draft-ietf-httpbis-header-structure-18

David Schinazi <dschinazi.ietf@gmail.com> Tue, 05 May 2020 19:42 UTC

Return-Path: <dschinazi.ietf@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 105F13A03F2; Tue, 5 May 2020 12:42:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ent72IKyPTqr; Tue, 5 May 2020 12:42:22 -0700 (PDT)
Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CF4353A02C1; Tue, 5 May 2020 12:42:21 -0700 (PDT)
Received: by mail-lj1-x232.google.com with SMTP id w20so2958832ljj.0; Tue, 05 May 2020 12:42:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eQ7ZesUCaB0aM9LhaOgPybm3zQ2q2qNEuqftqIhec44=; b=jXF5nweYDghcRNbpDQRncXxKPWUW0KT3p8jvd67q6R/ClfCTmWT2hzDtFz3nKeGhVh mA5ol6gG+zsqpK5S7h50J85/n5NKg1LDWCeKKeJK6aCME/YW0Db/bzBLgCxpISw/EUNM ZnY8QE37pcYaosPcALqvyH7EM4DMrOgssTsnUX0ko0JEMchhl5QUpXddJiqCC6yeNohc 5oGui2kKFbdLdbVbpLskDW0D/CJBqBIsF6Pywg0tuzrPdB0zTbmjfe5anN5QqLvnGsmo wiZo3RNAOJh8ZTKIJUGvmgr1e87sZYK63lxOqcbEkspSpkTmh/kjv3b5qd+0DcY4XdCc HVhA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eQ7ZesUCaB0aM9LhaOgPybm3zQ2q2qNEuqftqIhec44=; b=ZsRV9A28H8tzfEUx3tVgenGhReaEGrTX7AUrV7T8h++/2wOPFvu4t1M7BA83NIF7On y+fFOGaw3NMx6O/TD4DrKCo2kQw6MrJOb3HY5BTWeOROhzUFOVpE2hhFuJvIrpjvTtoN Q/64qneRjjv9lIzhHQap8f8iM8drJvESENP5oX1nTt/xuf0EEF0Nd4acSqRc2yZcnEwk DdzAnAdws13OTZd0YvmhGA8cjW56IxMuor1/RWuPFvj7tM0JK00C0hSRwRu90xtorqmj KcPatGAvDh8qYsQLEvK/FIoVE64U535yBaOse8f2QcSGC2bCjO8MwRofkH8ttvhIYSBO tlTQ==
X-Gm-Message-State: AGi0PuaFXi+deV2fI5mJ4uMXHINqkejgGoX+gyNP57h6vv163EHAcLlk 28R8ZIkXYkaStZaSlhnMHYBTSWX7GDYrha8Vc5Y=
X-Google-Smtp-Source: APiQypKgh+Q3WKxwjMJ4Ibrf2maVrrxVAWtWiATHlA4k+V22pR5//XUsa+FbJ0vhzs5YxPV3TNnnNv3vDggTTvzldPI=
X-Received: by 2002:a2e:9012:: with SMTP id h18mr2835625ljg.28.1588707739890; Tue, 05 May 2020 12:42:19 -0700 (PDT)
MIME-Version: 1.0
References: <158864148815.25056.4870473086918483854@ietfa.amsl.com> <2E578812-9E59-426E-85A9-B3A5AEA12853@mnot.net>
In-Reply-To: <2E578812-9E59-426E-85A9-B3A5AEA12853@mnot.net>
From: David Schinazi <dschinazi.ietf@gmail.com>
Date: Tue, 05 May 2020 12:42:09 -0700
Message-ID: <CAPDSy+4y9ZZ-f=MyV1b_-t5OygyYgdr3W4V4soiLVGOgzXKdMg@mail.gmail.com>
To: Mark Nottingham <mnot@mnot.net>
Cc: gen-art <gen-art@ietf.org>, draft-ietf-httpbis-header-structure.all@ietf.org, HTTP Working Group <ietf-http-wg@w3.org>, last-call@ietf.org
Content-Type: multipart/alternative; boundary="0000000000007cf9ae05a4ebd8dc"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/5LXCmYUzZT06E1da9D1z1qb1HWQ>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-httpbis-header-structure-18
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 May 2020 19:42:24 -0000

On Mon, May 4, 2020 at 10:02 PM Mark Nottingham <mnot@mnot.net> wrote:

> Hi David,
>
> Thanks for the comments. Responses below; I've committed in <
> https://github.com/httpwg/http-extensions/commit/001023>.
>

Thanks for making the changes! That commit looks good to me.


> > On 5 May 2020, at 11:18 am, David Schinazi via Datatracker <
> noreply@ietf.org> wrote:
> >
> > Nits/editorial comments:
> >
> > In s1.2 (Notational Conventions), I didn't understand what greedy meant
> in:
> >   In some places, the algorithms are "greedy" with
> >   whitespace, but this should not affect conformance.
>
> Hmm, I think we can remove that sentence.
>
> > In s2 (Defining New Structured Fields), perhaps "Reference this
> specification."
> >  should instead be "Normatively reference this specification." ?
>
> Sounds good.
>
> > In s2, the definition of Foo-Example Header seems to be enclosed in
> >  "--8<--" and "-->8--" in the TXT version, could be a bug in the tools?
>
> Our AD commented that it was difficult to distinguish the example spec
> text from the surrounding spec text in the text/plain rendering. These
> "scissor" marks were intended to serve that purpose; I suppose they're not
> as common as they used to be. My assumption is that the RFC Editor is going
> to propose a more suitable way to do this.
>

Ah! Now I see it :) Happy to let the RFC editor decide what's best here.


> > In s3.1.2 and s3.2, in the example, I was confused by "a=?0" and "b=?0"
> until I
> > s3.3.6.
> >    Perhaps reordering sections or adding a reference would help?
>
> I think a reference.
>
> > Should there be some guidance for defining new integer fields that don't
> fit in
> > 10^15?
> >    Is a String the recommended approach?
>
> I'm a little wary of giving a single recommendation here; it depends on
> the use case. It might be that it would be better to use two integers, for
> example, and add, multiply or otherwise combine them. Or it might make
> sense to implicitly multiple (e.g., *100) the value. Or it might make sense
> to yes, use a string -- or binary.
>

Sounds good. I was mainly curious because I defined a sh-integer in one of
my drafts for a value that can in theory go up to 2^62-1, and I wonder if
it's worth the added complexity to support values between 10^15 and 2^62...
https://tools.ietf.org/html/draft-schinazi-masque-connect-udp-00#section-5
But we can figure that out in the context of that draft, no need to answer
that question in draft-ietf-httpbis-header-structure if there's no easy
solution that fits all.