IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-httpbis-header-structure-18

Alissa Cooper <alissa@cooperw.in> Mon, 18 May 2020 18:19 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0753C3A0957; Mon, 18 May 2020 11:19:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.198
X-Spam-Level:
X-Spam-Status: No, score=-0.198 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=hfq1T3fU; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=Z3KB4hWn
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Soa1HfhPu7TI; Mon, 18 May 2020 11:19:46 -0700 (PDT)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CCE443A0C21; Mon, 18 May 2020 11:19:45 -0700 (PDT)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 193DE5C012C; Mon, 18 May 2020 14:19:45 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 18 May 2020 14:19:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=0 GBYQuNRqXqRFuB+7QYwZ4p1Rmb3uOgpsFy2tFFvW2g=; b=hfq1T3fUb8pbLeVLi ddoxznq5lchmD4/ZQLMvshYtBGHTY0t74CkMSq2jkfN9vrNgzK3M+A2cfWZi9S3C aRFYCEqKgBPDdX2bobK/r+zsr7ts7C0vIG2HxhINxrVcoZcm5WDe7D6Tm1rWGXSv yP2tFJE+aaRP0IsjJ+KoFvsBdfUOKkhOOnRdVC/qkECxZAeMj2TnY8dBvBHQgGKW LIsZ9K5GyHDTgD3luJTpaqPnrSS8K2DCYrHMCvXZ0OrRtvCFYAfkiJkRT/deGmvG ESwRb9LNR1qnTOCc7ev+TDkA6b/5CZlo+0mNOGZMhZ/8h31xwj79x2BIGl4lbmWI /22sQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0GBYQuNRqXqRFuB+7QYwZ4p1Rmb3uOgpsFy2tFFvW 2g=; b=Z3KB4hWneZmx+OSHcDrF+4P24SnOl/yTB+4xAST8dfdSWWmA2nFraKX/X zOZu2Qrtwy9YLL5vV9y+7rs6MlY+uRd73Rc5E+v4TCgC+jo4ZYhOQMRB4IBf47uy qyObg1DzY9CivM/RG1eT/9VpLQQECFpkAbLPk+Hkp/1Ar5W+76ztlhCk3gWTif3N UdBMbWsKMpsFhctmgKNZXgcK7LGFvvf2Fge+JIXvQKXjRUri9RBTaL/KJwedyzAF SVG0uWTTA2cJZV9/IyqVM6tQq5pFVv2Zf6AxRiYAP9EycHbM0KdnQokgFOQqXDaz d2oiSk2RL/aQ3Nc+nwvAXcrZcBQZg==
X-ME-Sender: <xms:wNHCXg_SPOKs6_BCaZRhJ87UJo63hR7sAn_wH4J01lHDIgjJDGupfg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddthedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurheptggguffhjgffgffkfhfvofesth hqmhdthhdtvdenucfhrhhomheptehlihhsshgrucevohhophgvrhcuoegrlhhishhsrges tghoohhpvghrfidrihhnqeenucggtffrrghtthgvrhhnpeefudfhgfetgfetvddvffeiud dtkeffgedvjeejtdeiheefgfelfeeutdelvdfggfenucffohhmrghinhepihgvthhfrdho rhhgnecukfhppedujeefrdefkedruddujedrjeeknecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomheprghlihhsshgrsegtohhophgvrhifrdhinh
X-ME-Proxy: <xmx:wNHCXosGaehiwbv5_tOtmeJx4NdrCKYcKZvd-nUgGWRUepBG8_gpQA> <xmx:wNHCXmADHdrgkfztxLg_7gB4iCFjMKgpBw4z_Q7mFbAAZeoo03YoIg> <xmx:wNHCXgccxpCsjnopKNtn0-NY7ae-0ebWGBQfc8tW4g7kYNKc4cLM8A> <xmx:wdHCXj0BTDb9jH-gL5scQhR6J3JktxDY58PsI6qg_Z2VuoQGDwKENw>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.78]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E39430663E4; Mon, 18 May 2020 14:19:44 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <158864148815.25056.4870473086918483854@ietfa.amsl.com>
Date: Mon, 18 May 2020 14:19:43 -0400
Cc: General Area Review Team <gen-art@ietf.org>, last-call@ietf.org, draft-ietf-httpbis-header-structure.all@ietf.org, ietf-http-wg@w3.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <41600C85-4B54-44C8-BFFA-A6D9F045A1A6@cooperw.in>
References: <158864148815.25056.4870473086918483854@ietfa.amsl.com>
To: David Schinazi <dschinazi.ietf@gmail.com>
X-Mailer: Apple Mail (2.3445.9.5)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/61KaaKHuSqfO6-XiVh-BFDl1Sqs>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-httpbis-header-structure-18
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2020 18:19:48 -0000

David, thanks for your review and thanks to everyone for the discussion. As I noted in my No Objection ballot, it seems like at a minimum the options available for integers larger than 10^15 should be noted somewhere so that readers are alert to it, even if no particular option is recommended.

Alissa


> On May 4, 2020, at 9:18 PM, David Schinazi via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: David Schinazi
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-httpbis-header-structure-18
> Reviewer: David Schinazi
> Review Date: 2020-05-04
> IETF LC End Date: 2020-05-04
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: This document was clear and well-written. I found no issues and noted
> some number of small nits below.
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
> 
> In s1.2 (Notational Conventions), I didn't understand what greedy meant in:
>   In some places, the algorithms are "greedy" with
>   whitespace, but this should not affect conformance.
> 
> In s2 (Defining New Structured Fields), perhaps "Reference this specification."
>  should instead be "Normatively reference this specification." ?
> 
> In s2, the definition of Foo-Example Header seems to be enclosed in
>  "--8<--" and "-->8--" in the TXT version, could be a bug in the tools?
> 
> In s3.1.2 and s3.2, in the example, I was confused by "a=?0" and "b=?0" until I
> s3.3.6.
>    Perhaps reordering sections or adding a reference would help?
> 
> Should there be some guidance for defining new integer fields that don't fit in
> 10^15?
>    Is a String the recommended approach?
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email