Re: [Gen-art] [Last-Call] Genart last call review of draft-allan-5g-fmc-encapsulation-04

Alissa Cooper <alissa@cooperw.in> Wed, 12 August 2020 17:05 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C117D3A0317; Wed, 12 Aug 2020 10:05:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=gHyNiB1U; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=mkxmuj4n
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9LRPrkKHwtZr; Wed, 12 Aug 2020 10:05:05 -0700 (PDT)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D66813A00E0; Wed, 12 Aug 2020 10:05:01 -0700 (PDT)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 00CAA5C0197; Wed, 12 Aug 2020 13:05:01 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 12 Aug 2020 13:05:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=/ t7/8syhqfEE2iui7higgReRzN2Wa52NLZ5jIYNeYbw=; b=gHyNiB1Uipz4Bf/HZ Jh0LsVsfL0XMoH/Y8B2jqRV2CYdNX8dwlXYc09Y5FkiJUGXgMv/D8SlKhFUuQnJv yvhxux+kV3Oi9w1u/Ceb0JpDkpTwA74Cn2REotPpzBYsMrO+FVc+r/UKbc9zKAYt jGmtax1x+o1LSErQtkaF02AHhuFC7dbu3HrspC1rDWEmvBmJNrVeK0hLhVcaTsvr Dkc27fDsmi3EUsUmbNuRwrhUoGhLG5q464ZCQrzktMnp27lRbVhH+GinyclTjAnl MYrEfuWPlyK7yvVAeufviSVjvWmFRuOdmnHSMlUyKKz1famVkQg6ghIiLMjTj33p iINWw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=/t7/8syhqfEE2iui7higgReRzN2Wa52NLZ5jIYNeY bw=; b=mkxmuj4nnxSkWF52Ai3pGL1CFd4DaYciFy+B6EKwqnC3JE4MT5LtD5o7c J+Gzuhn3zy+uPrK1hGZDqfIRVO59WgbU+CAmfcONdGFuqKNcLboeAdLti4FYEE1B lsLiz843yj0ghxlniUmB5UdtZmn5Ss3x9qI1G4BONFsbFEc8Stwkk9Rj6u26q7bt 6D9O5GZ4p64A72yYXHH5ugMMY6tThf7LOovRxfkCQRqZAIXtXjSDg5Gc4G/7hsNv obKB2axCnWd+HX4zfq+9pfOlJObk0dBqW3SKLuAwCToPQljP1QhbLE1E5cuRhZoA ltwDL3uPI7sNIDPXoQXyONUyRRZeg==
X-ME-Sender: <xms:PCE0XzPohAZ19D7lJ-XsS4pjnVAUlmtiX4DdTbYTBfZNA_PcKyBTlw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrledvgddutdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffgffkfhfvofesthhqmhdthhdtvdenucfhrhhomheptehlihhs shgrucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucggtffrrg htthgvrhhnpeffueelleeftedtjeekgffhudfgkeduueduudelteevfeegfeeutdfgvedt lefhleenucffohhmrghinhepihgvthhfrdhorhhgpdhfihhrvggvhigvrdgtohhmpdhrfh gtqdgvughithhorhdrohhrghdpihgrnhgrrdhorhhgnecukfhppedutdekrdehuddruddt uddrleeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghlihhsshgrsegtohhophgvrhifrdhinh
X-ME-Proxy: <xmx:PCE0X9_LLsDUp0K86ylpcO76ie-tkqzyc4SWpn-nsPut9QII1EazNg> <xmx:PCE0XySACyoWAbwX2V_PKLFbhJKuFbUomajgOfU7AL-R56nGHDOvgw> <xmx:PCE0X3tTGdor5rld8XCrSHcGpLej-KQ27jS0ma3B7-aq6t6r2IYOuw> <xmx:PCE0X8q-CW8veyoz7F1z3dROLVjVPsa4fJtRD-ILJJiZ8isFs4FPQg>
Received: from alcoop-m-c46z.fios-router.home (pool-108-51-101-98.washdc.fios.verizon.net [108.51.101.98]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D46C3280066; Wed, 12 Aug 2020 13:05:00 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <37C81F98-368D-4533-8A1E-1C1438E53085@vigilsec.com>
Date: Wed, 12 Aug 2020 13:04:59 -0400
Cc: david.i.allan@ericsson.com, Donald Eastlake <d3e3e3@gmail.com>, "last-call@ietf.org" <last-call@ietf.org>, IETF Gen-ART <gen-art@ietf.org>, "draft-allan-5g-fmc-encapsulation.all@ietf.org" <draft-allan-5g-fmc-encapsulation.all@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D7C55570-B909-4004-A432-9CCD260D20A8@cooperw.in>
References: <159379401341.16286.15071860923365675793@ietfa.amsl.com> <CAF4+nEFJLYh7XHnyZq4rqdAvD4ff5kmwkzBUFDk4oMH-XY2TuQ@mail.gmail.com> <BY5PR15MB3715319F5ABF0A0159BF1DF3D06B0@BY5PR15MB3715.namprd15.prod.outlook.com> <37C81F98-368D-4533-8A1E-1C1438E53085@vigilsec.com>
To: Russ Housley <housley@vigilsec.com>
X-Mailer: Apple Mail (2.3608.120.23.2.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/6mMZIhpUYI3fzHrS7vVmRVx2X_Y>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-allan-5g-fmc-encapsulation-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Aug 2020 17:05:08 -0000

Russ, thanks for your review. Authors, thanks for the document updates. I entered a DISCUSS ballot to chat about a couple of other points.

Alissa


> On Jul 4, 2020, at 4:18 PM, Russ Housley <housley@vigilsec.com> wrote:
> 
> Two responses below.
> 
> Russ
> 
> 
>> On Jul 4, 2020, at 2:01 PM, David Allan I <david.i.allan=40ericsson.com@dmarc.ietf.org> wrote:
>> 
>> Hi Russ:
>> 
>> FWIW I'll echo agreement with Donald here and also express thanks. I would share his concern about depending on a constant URL structure.
>> 
>> Cheers
>> D
>> 
>> -----Original Message-----
>> From: Donald Eastlake <d3e3e3@gmail.com> 
>> Sent: Friday, July 3, 2020 8:07 PM
>> To: Russ Housley <housley@vigilsec.com>
>> Cc: gen-art@ietf.org Review Team <gen-art@ietf.org>rg>; last-call@ietf.org; draft-allan-5g-fmc-encapsulation.all@ietf.org
>> Subject: Re: Genart last call review of draft-allan-5g-fmc-encapsulation-04
>> 
>> Hi Russ,
>> 
>> Thanks for the review. See my responses as one co-author below.
>> 
>> On Fri, Jul 3, 2020 at 12:33 PM Russ Housley via Datatracker <noreply@ietf.org> wrote:
>>> 
>>> Reviewer: Russ Housley
>>> Review result: Almost Ready
>>> 
>>> I am the assigned Gen-ART reviewer for this draft. The General Area 
>>> Review Team (Gen-ART) reviews all IETF documents being processed by 
>>> the IESG for the IETF Chair.  Please treat these comments just like 
>>> any other last call comments.
>>> 
>>> For more information, please see the FAQ at 
>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>> 
>>> Document: draft-allan-5g-fmc-encapsulation-04
>>> Reviewer: Russ Housley
>>> Review Date: 2020-07-03
>>> IETF LC End Date: 2020-07-27
>>> IESG Telechat date: Unknown
>>> 
>>> 
>>> Summary: Almost Ready
>>> 
>>> Major Concerns:
>>> 
>>> Section 2 says:
>>> 
>>>  PPPoE data packet encapsulation is indicated in an IEEE 802[8]
>>>  Ethernet frame by an Ethertype of 0x8864.
>>> 
>>> This is very odd way to introduce this section.  IEEE Std 802-2001 
>>> covers the architecture for Project 802, not just Ethernet frames, 
>>> which are fully specified in IEEE 802.3.  However, the MAC frame, MAC 
>>> addresses, and Ethertypes are all described in this standard.
>>> Second, you need to point to RFC 2516 to talk about PPPoE.  Third, the 
>>> Ethertype is not defined in IEEE Std 802-2001.  I suggest:
>>> 
>>>  The Ethernet payload [8] for PPPoE [3] is indicated by an
>>>  Ethertype of 0x8864.
>> 
>> I'd be fine with that change. (I hope we don't refer to 802.3, last time I looked that document was well over 20,000 pages everything of relevance is in 802.)
>> 
>>> References:  I think that [9] needs to be a normative reference 
>>> because the reader cannot understand the QFI field without it.
>> 
>> OK with me.
>> 
>>> Minor Concerns:
>>> 
>>> Introduction: You spell out the meaning of 5G, but not BBF.  Please 
>>> spell out BBF.  I note that 5G is on the RFC Editor "well known"
>>> list 
>>> (https://protect2.fireeye.com/v1/url?k=c7043a1d-99a4f858-c7047a86-86b5
>>> 68293eb5-c84fc54a0ea60a7c&q=1&e=3bf3375d-077c-4030-87f7-c12d7d44797e&u
>>> =https%3A%2F%2Fwww.rfc-editor.org%2Fmaterials%2Fabbrev.expansion.txt), but BBF is not, so it would be fine to not spell out 5G. Likewise, please spell out p2p, PPPoE, IPoE, DSLAMs, and OLTs the first time the term is used.
>>> 
>>> Please explain the UE in the Introduction so that it is understood by 
>>> the time it is used later.
>> 
>> I think most standards documents use too many acronyms and I do not think the RFC Editor "well known" list authoritatively describes the state of knowledge of every RFC reader. So I'm fine with spelling out more things but would prefer not to drop any existing spelling outs.
>> 
>>> Please use the exact wording from RFC 8174 in the boilerplate:
>>> 
>>>  The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
>>>  NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED",
>>>  "MAY", and "OPTIONAL" in this document are to be interpreted as
>>>  described in BCP 14 [RFC2119] [RFC8174] when, and only when, they
>>>  appear in all capitals, as shown here.
>>> 
>>> I assume that it is okay to use "[1] [2]" instead of "[RFC2119] 
>>> [RFC8174]", but this is not the tradition.
>>> 
>>> Section 2: Please add a reference for the IANA registry.  I think you 
>>> are pointing to here:
>>> 
>>> 
>>> https://www.iana.org/assignments/ppp-numbers/ppp-numbers.xhtml#ppp-num
>>> bers-2
>> 
>> Is IANA's URL structure and URL embedded nomenclature guaranteed to be constant? The draft gives the precise name of the IANA registries web page referenced: "Point-to-Point (PPP) Protocol Field Assignments". I see no need to include a URL. I put through a number of drafts and IANA has never asked me to add a URL to an IANA web page or registry to one of those drafts.
> 
> You can do it in such a way that the RFC Editor drops the pointer from the final document, but the URL makes it absolutely clear to IANA which registry is being updated.
> 
>> 
>>> Section 5: Please add pointers to the registry that is to be updated.
>>> I think you are pointing here:
>>> 
>>> 
>>> https://www.iana.org/assignments/ieee-802-numbers/ieee-802-numbers.xht
>>> ml#ieee-802-numbers-1
>> 
>> Same comment here.
> 
> Me too.
> 
>> 
>>> Nits:
>>> 
>>> Abstract: I suggest that the Abstract say what is provided instead of 
>>> the needs of 5G.  It is also shorter.  I suggest:
>>> 
>>>  As part of providing wireline access to the 5G Core (5GC), deployed
>>>  wireline networks carry user data between 5G residential gateways
>>>  and the 5G Access Gateway Function (AGF). The encapsulation method
>>>  specified in this document supports the multiplexing of traffic for
>>>  multiple PDU sessions within a VLAN delineated access circuit,
>>>  permits legacy equipment in the data path to snoop certain packet
>>>  fields, carries 5G QoS information associated with the packet data,
>>>  and provides efficient encoding.
>> 
>> That looks OK to me.
>> 
>>> Section 4: s/document"s/document's/
>> 
>> Thanks,
>> Donald
>> =============================
>> Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>> 2386 Panoramic Circle, Apopka, FL 33896 USA  d3e3e3@gmail.com
>> -- 
>> last-call mailing list
>> last-call@ietf.org
>> https://www.ietf.org/mailman/listinfo/last-call
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art