IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-prefix-sid-21

"Acee Lindem (acee)" <acee@cisco.com> Wed, 13 June 2018 14:10 UTC

Return-Path: <acee@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA703130E81; Wed, 13 Jun 2018 07:10:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lhr1nj1Ulp1R; Wed, 13 Jun 2018 07:10:25 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 20D14130E36; Wed, 13 Jun 2018 07:08:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=41954; q=dns/txt; s=iport; t=1528898914; x=1530108514; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=RV+4XQ++z3k2z9lbcL4bxngNFCMx901LcRlTs/2ekeU=; b=Lg6Jh7u0JTMRSOt+VMJDk4EmeVX+O/wotrwiqg1s2XtUb7WttBw47t8K 1PJrFAXZka3L9tNjZxi835BV/jv4AxymzSOxymkEF6ZTLC9ZAttujZc+b CoLiWX2LowOExPJk0fEq7MW9MPNEMsPkKp1umt5rqoO14EVm8QInVGyxY w=;
X-Files: Diff draft-ietf-idr-bgp-prefix-sid-21.txt - draft-ietf-idr-bgp-prefix-sid-22.txt : 27590
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DVAABGJCFb/5RdJa1cGQEBAQEBAQEBAQEBAQcBAQEBAYMaLmI3SCgKg2+IBIxpgX+HC41eFIFkCyWERwIXgiAhNBgBAgEBAQEBAQJtHAyFKQYaCUgOEAIBCBICLgICAjAXDgIEAQ0FDoMUAoF/D6wGghyCPYYJgVkPiEuCE4EOASSBan6DBgsBAQIBF4ELWx6CQzGCJAKHLkMDiD2IWQkCg0qCKIJdgm2DPYE/HSSDPYVUgRCBE4oKhwwCERMBgSQdOIFScBU7KgGCGAmCGBeIWYU+bwEBjg6BGgEB
X-IronPort-AV: E=Sophos;i="5.51,219,1526342400"; d="txt'?scan'208";a="409607000"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2018 14:08:32 +0000
Received: from XCH-RTP-014.cisco.com (xch-rtp-014.cisco.com [64.101.220.154]) by rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id w5DE8WsJ010080 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 13 Jun 2018 14:08:32 GMT
Received: from xch-rtp-015.cisco.com (64.101.220.155) by XCH-RTP-014.cisco.com (64.101.220.154) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 13 Jun 2018 10:08:31 -0400
Received: from xch-rtp-015.cisco.com ([64.101.220.155]) by XCH-RTP-015.cisco.com ([64.101.220.155]) with mapi id 15.00.1320.000; Wed, 13 Jun 2018 10:08:31 -0400
From: "Acee Lindem (acee)" <acee@cisco.com>
To: Peter Yee <peter@akayla.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "idr@ietf.org" <idr@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-idr-bgp-prefix-sid.all@ietf.org" <draft-ietf-idr-bgp-prefix-sid.all@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-idr-bgp-prefix-sid-21
Thread-Index: AQHUAuTSNbGBKMSDrE63JPRWxuOGR6ReOjkA
Date: Wed, 13 Jun 2018 14:08:31 +0000
Message-ID: <C43039B7-E8DD-4F46-B5D5-0249C4C663C7@cisco.com>
References: <152887347947.15168.9036207660556378358@ietfa.amsl.com>
In-Reply-To: <152887347947.15168.9036207660556378358@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.116.152.202]
Content-Type: multipart/mixed; boundary="_002_C43039B7E8DD4F46B5D50249C4C663C7ciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/7PX1a5WPx7AShcQVtw2wYkzeH0U>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-prefix-sid-21
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jun 2018 14:10:33 -0000

Hi Peter, 
Thanks for thoroughly reviewing this document again and finding the nits. I incorporated all your comments other than adding "positive" as while it is more precise, it reads better without it and we don't want to imply that a TLV length could ever be negative. See attached diff. 
Thanks,
Acee 

On 6/13/18, 3:04 AM, "Peter Yee" <peter@akayla.com> wrote:

    Reviewer: Peter Yee
    Review result: Ready with Nits
    
    I am the assigned Gen-ART reviewer for this draft. The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed
    by the IESG for the IETF Chair.  Please treat these comments just
    like any other last call comments.
    
    For more information, please see the FAQ at
    
    <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
    
    Document: draft-ietf-idr-bgp-prefix-sid-21
    Reviewer: Peter Yee
    Review Date: 2018-06-12
    IETF LC End Date: 2018-06-12
    IESG Telechat date: Not scheduled for a telechat
    
    Summary: This document is ready for publication, although there are a few nits
    that should be corrected prior to publication.  I am not a routing expert, so I
    cannot vouch for the correctness of this specification, but it otherwise
    appears consistent and reflect s the many iterations it has undergone.
    
    Major issues: None.
    
    Minor issues: None
    
    Nits/editorial comments:
    
    General:
    
    Expand uncommon acronyms on first use.  (See:
    https://www.rfc-editor.org/materials/abbrev.expansion.txt.).  Acronyms need
    expansion include: AS, ECMP, and EBGP.
    
    Specific:
    
    Page 3, 7th paragraph, last sentence: actually, this isn’t a complete sentence.
     I’m not sure what you wanted to do with the fragment.
    
    Page 5, 2nd full paragraph, last sentence: change “prefix-SID” to “BGP
    Prefix-SID” to make usage in the remainder of the document.
    
    Page 7, Section 3.2, 2nd bullet item: insert “positive” before “multiple”.
    
    Page 9, last paragraph, 1st sentence: delete “to”.
    
    Page 12, 1st paragraph after the (unlabeled) Value/Type/Reference table, last
    sentence: insert “ Prefix” before “-SID”.
    
    Page 12, 2nd paragraph after the (unlabeled) Value/Type/Reference table, last
    sentence: insert “ Prefix” before “-SID”.

v2.23.0 | Report a Bug | By Email