Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-prefix-sid-21
Peter Yee <peter@akayla.com> Wed, 13 June 2018 15:28 UTC
Return-Path: <peter@akayla.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BF901130E4B for <gen-art@ietfa.amsl.com>; Wed, 13 Jun 2018 08:28:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gvoTXQMMPUcL for <gen-art@ietfa.amsl.com>; Wed, 13 Jun 2018 08:28:36 -0700 (PDT)
Received: from p3plsmtpa09-10.prod.phx3.secureserver.net (p3plsmtpa09-10.prod.phx3.secureserver.net [173.201.193.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4B383130E48 for <gen-art@ietf.org>; Wed, 13 Jun 2018 08:28:36 -0700 (PDT)
Received: from [192.168.168.55] ([173.8.184.78]) by :SMTPAUTH: with ESMTPSA id T7fAfgCBBaUaoT7fBfa67r; Wed, 13 Jun 2018 08:26:21 -0700
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (1.0)
From: Peter Yee <peter@akayla.com>
X-Mailer: iPhone Mail (15F79)
In-Reply-To: <C43039B7-E8DD-4F46-B5D5-0249C4C663C7@cisco.com>
Date: Wed, 13 Jun 2018 08:26:19 -0700
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "idr@ietf.org" <idr@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-idr-bgp-prefix-sid.all@ietf.org" <draft-ietf-idr-bgp-prefix-sid.all@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1C2C3BB4-600B-4D8E-B2BB-4B01C53D77E4@akayla.com>
References: <152887347947.15168.9036207660556378358@ietfa.amsl.com> <C43039B7-E8DD-4F46-B5D5-0249C4C663C7@cisco.com>
To: "Acee Lindem (acee)" <acee@cisco.com>
X-CMAE-Envelope: MS4wfFZgxaTJ3Pgn1f8moFPlr6nnjRa/6+oMmsHQZmJBoQqgGxpFOqS61WCvS+WrITwFTV1RUNMQEX/TiXnYOfdXE3Ddro2t1l8w26kKfcxURG+R4MyGOlN7 6ZOpuL1qjQUTd2jRPRgyfGSrICAEXySqcUmR66TAYYz/s5LyaGHgqKXes7PCtFocr/7fnOpCrkqX+WgcWHi3YMxE/EDh+WxMDPDZcUicLSyWYZ9/lmEftVEw +Ti5QyIAYgAyKIsi9/CnXWM4+w7HAglvCGb+6HZJ1wuahi8ZkmyahNWZ3cXMyrK9
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/RBzN-GUBdMl0YesIN7vcX5znrRc>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-idr-bgp-prefix-sid-21
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jun 2018 15:28:45 -0000
Acee,
I’m fine with leaving out positive. I was actually trying to cover the case where someone might interpret the TLV definition to allow zero SRGBs. It’s nonsensical, of course, to do so.
-Peter
On Jun 13, 2018, at 7:08 AM, Acee Lindem (acee) <acee@cisco.com> wrote:
Hi Peter,
Thanks for thoroughly reviewing this document again and finding the nits. I incorporated all your comments other than adding "positive" as while it is more precise, it reads better without it and we don't want to imply that a TLV length could ever be negative. See attached diff.
Thanks,
Acee
On 6/13/18, 3:04 AM, "Peter Yee" <peter@akayla.com> wrote:
Reviewer: Peter Yee
Review result: Ready with Nits
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please treat these comments just
like any other last call comments.
For more information, please see the FAQ at
<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
Document: draft-ietf-idr-bgp-prefix-sid-21
Reviewer: Peter Yee
Review Date: 2018-06-12
IETF LC End Date: 2018-06-12
IESG Telechat date: Not scheduled for a telechat
Summary: This document is ready for publication, although there are a few nits
that should be corrected prior to publication. I am not a routing expert, so I
cannot vouch for the correctness of this specification, but it otherwise
appears consistent and reflect s the many iterations it has undergone.
Major issues: None.
Minor issues: None
Nits/editorial comments:
General:
Expand uncommon acronyms on first use. (See:
https://www.rfc-editor.org/materials/abbrev.expansion.txt.). Acronyms need
expansion include: AS, ECMP, and EBGP.
Specific:
Page 3, 7th paragraph, last sentence: actually, this isn’t a complete sentence.
I’m not sure what you wanted to do with the fragment.
Page 5, 2nd full paragraph, last sentence: change “prefix-SID” to “BGP
Prefix-SID” to make usage in the remainder of the document.
Page 7, Section 3.2, 2nd bullet item: insert “positive” before “multiple”.
Page 9, last paragraph, 1st sentence: delete “to”.
Page 12, 1st paragraph after the (unlabeled) Value/Type/Reference table, last
sentence: insert “ Prefix” before “-SID”.
Page 12, 2nd paragraph after the (unlabeled) Value/Type/Reference table, last
sentence: insert “ Prefix” before “-SID”.
<Diff draft-ietf-idr-bgp-prefix-sid-21.txt - draft-ietf-idr-bgp-prefix-sid-22.txt>
- Re: [Gen-art] Genart last call review of draft-ie… Peter Yee
- Re: [Gen-art] Genart last call review of draft-ie… Acee Lindem (acee)
- [Gen-art] Genart last call review of draft-ietf-i… Peter Yee