Re: [Gen-art] Gen-ART review of draft-ietf-opsec-ip-security-05

[Fernando Gont <[e-mail]>]

Hi, Vijay,

On 03/01/2011 07:03 p.m., Vijay K. Gurbani wrote:

>>> 6) S3.7 --- when discussing the Fragment Offset, is it worth
>>>   stating that the Fragment Offset is measured in units of 8 octets
>>>   (thereby giving the magic number 65528 = 8191*8)?
>>
>> This *is* mentioned in the first paragraph of Section 3.7, as follows:
>>
>> ---- cut here ----
>>     It indicates where in the original datagram payload
>>     the payload of the fragment belongs, and is measured in units of
>>     eight bytes.
>> ---- cut here ----
>>
>> So I assume no changes needed here?
> 
> Well, following the principle of being explicit with magic numbers
> dictates that 65528 be explained.  Something like the following may
> help in being more explicit:
> 
>   s/an offset 65528 bytes/an offset 65528 (8191*8) bytes/

Sounds reasonable. Will do.



> Thanks for entertaining my rather late review.

Thanks *you* for your feedback!

Best regards,
-- 
Fernando Gont
e-mail: [e-mail] || [e-mail]
PGP Fingerprint: 7809 84F5 322E 45C7 F1C9 3945 96EE A9EF D076 FFF1