Re: [Gen-art] Gen-ART review of draft-ietf-mboned-auto-multicast-17

Alexey Melnikov <alexey.melnikov@isode.com> Mon, 30 June 2014 12:17 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A7861A0275; Mon, 30 Jun 2014 05:17:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.751
X-Spam-Level:
X-Spam-Status: No, score=-0.751 tagged_above=-999 required=5 tests=[BAYES_20=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RP_MATCHES_RCVD=-0.651] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bIKSdfUX_tjL; Mon, 30 Jun 2014 05:17:07 -0700 (PDT)
Received: from waldorf.isode.com (ext-bt.isode.com [217.34.220.158]) by ietfa.amsl.com (Postfix) with ESMTP id 1E3FB1A026E; Mon, 30 Jun 2014 05:17:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1404130626; d=isode.com; s=selector; i=@isode.com; bh=mu69JeqtplLlaVOQ+I3BcoCe9CJsfDyZjc7kg/e1ayY=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=s9z38cuvZNdghTN9WytxiheyKM7jONiUBIro7MmZ//DeyAksm5u3Rqm5hLKqgx9b+2Ha6l bpc1OO+1BsBaH+f7woqgNqVQIad/NClP/hdaznIAfoe1Z6IiWmvLmXYRQEAMgPyI4Dhe+L dQKyx0m5VMCGYPDR7Ux3GGN78eETmIM=;
Received: from [172.20.1.47] ((unknown) [217.34.220.158]) by waldorf.isode.com (submission channel) via TCP with ESMTPA id <U7FVPgAvQzjl@waldorf.isode.com>; Mon, 30 Jun 2014 13:17:05 +0100
X-SMTP-Protocol-Errors: NORDNS
Message-ID: <53B15583.8040101@isode.com>
Date: Mon, 30 Jun 2014 13:18:11 +0100
From: Alexey Melnikov <alexey.melnikov@isode.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
To: Greg Bumgardner <gbumgard@gmail.com>, Jari Arkko <jari.arkko@ericsson.com>
References: <53830DC9.7070202@isode.com> <B8C8F975-C157-4BE5-ADB1-6E2E5EA5BF4F@ericsson.com> <CAJkfEFoc1a8Y=XfQp7T=nr0mfzEOkQPVUDKxPimrD-KgbWagqg@mail.gmail.com>
In-Reply-To: <CAJkfEFoc1a8Y=XfQp7T=nr0mfzEOkQPVUDKxPimrD-KgbWagqg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="------------040508090704030804010304"
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/8P_0_yv6y2ULska8_FM-jsmwdgE
Cc: draft-ietf-mboned-auto-multicast.all@tools.ietf.org, "General Area Review Team (gen-art@ietf.org)" <gen-art@ietf.org>, The IESG <iesg@ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-mboned-auto-multicast-17
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jun 2014 12:17:09 -0000

On 25/06/2014 19:23, Greg Bumgardner wrote:
> Hi all,
Hi all,
Sorry for the slow response.
>
> For some reason, I missed Alexey's e-mail, but I do have a response to 
> these two comments.
>
> Version numbers: As you guessed, the version field is basically a 
> stub. The version number field was added late in the process "just in 
> case" we need it to indicate the addition of fields, primarily flag 
> bits. Careful reading of the spec will reveal that several flags were 
> obviously added late in the designed process that would not be 
> supported by existing implementations of the protocol (which, 
> unfortunately, were deployed prior to final design of the protocol as 
> described by the ID). I've assumed that the issue of backwards 
> compatibility would be addressed in any subsequent protocol 
> descriptions that might be produced.
I am concerned that if you don't think about versionning now, it would 
be hard to fix it later. Is there any expectation on backward 
compatibility between different versions (e.g. are the same messages 
allowed in future versions or are they allowed to have different format, 
etc.).

But if the WG thinks that new versions are unlikely, then it might be Ok 
to defer this till you need to change the version.
> IPv6 checksums. IPv6 doesn't use checksums. The checksum in MLD 
> messages is computed over a virtual header of IPv6 fields and the MLD 
> payload according to the rules defined by ICMPv6.

Ok, thanks.

Best Regards,
Alexey
>
> Thanks,
>
> -g.b.
>
>
> On Wed, Jun 25, 2014 at 8:37 AM, Jari Arkko <jari.arkko@ericsson.com 
> <mailto:jari.arkko@ericsson.com>> wrote:
>
>     Is there a response to Alexey’s questions?
>
>     That being said, ALexey, can you point to what specifically you
>     are worried with in the below arrangement on version numbers? A
>     number version comes along, and those implementations handle other
>     version numbers, while being able to downgrade to 0...
>
>     Jari
>
>     On 26 May 2014, at 10:47, Alexey Melnikov
>     <alexey.melnikov@isode.com <mailto:alexey.melnikov@isode.com>> wrote:
>
>     > I am the assigned Gen-ART reviewer for this draft. For background on
>     > Gen-ART, please see the FAQ at
>     >
>     > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>     >
>     > Please resolve these comments along with any other Last Call
>     comments
>     > you may receive.
>     >
>     > Document: draft-ietf-mboned-auto-multicast-17
>     > Reviewer: Alexey Melnikov
>     > Review Date: May 26, 2014
>     > IETF LC End Date: May 26, 2014
>     >
>     > Summary:  Nearly ready for publication as a Proposed Standard.
>     >
>     > Major issues:
>     >
>     >
>     > In the document, I am seeing:
>     >
>     > 5.1.1.1.  Version (V)
>     >
>     >   [And in several other similar sections]
>     >
>     >   The protocol version number for this message is 0.
>     >
>     > 5.2.3.2.  Handling AMT Messages
>     >
>     >   A gateway that conforms to this specification MUST ignore any
>     message
>     >   with a Version field value other than zero.
>     >
>     > 5.3.3.1.  Handling AMT Messages
>     >
>     >   A relay that conforms to this specification MUST ignore any
>     message
>     >   with a Version field value other than zero.
>     >
>     >
>     >
>     > This might not actually be an issue, if it was discussed in the
>     WG. But I am wondering if the WG thought about versioning,
>     backward compatibility and other related issues.
>     > How likely is it that a new version of AMT is going to be
>     designed? At the moment the document reads like "we have a stub
>     field for future versions, but we haven't thought about how they
>     are going to be handled yet".
>     >
>     >
>     > Minor issues: None
>     >
>     > Nits/editorial comments:
>     >
>     > 5.3.3.4.  Handling a Membership Update Message
>     >
>     >  o  The computed checksums for the encapsulated IP datagram and its
>     >      payload MUST match the values contained therein.  Checksum
>     >      computation and verification varies by protocol; See
>     [RFC0791] for
>     >      IPv4, [RFC3376] for IGMPv3, and [RFC4443] for MLD (ICMPv6).
>     >
>     > Any recommendation for IPv6 or is it covered by one of the other
>     choices?
>     >
>     > _______________________________________________
>     > Gen-art mailing list
>     > Gen-art@ietf.org <mailto:Gen-art@ietf.org>
>     > https://www.ietf.org/mailman/listinfo/gen-art
>
>