Re: [Gen-art] Genart last call review of draft-ietf-ntp-using-nts-for-ntp-22

Ragnar Sundblad <ragge@netnod.se> Fri, 28 February 2020 00:24 UTC

Return-Path: <ragge@netnod.se>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 66C0B3A09F5 for <gen-art@ietfa.amsl.com>; Thu, 27 Feb 2020 16:24:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=netnod-se.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FawXrGC6Dj_u for <gen-art@ietfa.amsl.com>; Thu, 27 Feb 2020 16:24:39 -0800 (PST)
Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 902153A09F0 for <gen-art@ietf.org>; Thu, 27 Feb 2020 16:24:39 -0800 (PST)
Received: by mail-lj1-x230.google.com with SMTP id x7so1356453ljc.1 for <gen-art@ietf.org>; Thu, 27 Feb 2020 16:24:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netnod-se.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=HSMVP6CygzSzK33fUzNkXkQfCKGhcqy5DOv7A5XcWpA=; b=sDnm7DRcblmMFKBGqN7RRkaNHQwb/KsNq8ABMf4tzm1AAG0NHd4G8Pq76UiigJRDuV Spz2jOoIW1bZ39k6i2WDinsofqVM7lo53LdSObQxeJTELCzwGSyIHgD3heIi3mKNPOgO lVCYyxdmwuRTy1lq9U24aP5LoWnIb0Vnh1ri3t59jNez2HYcBE53siNo6srRj8wYAVLV 3cjq2gG2UN51xJWark0IKY+ud22MSe5fxCR1ofWGm3ppWFzgRHtJS/uNioDvuMM9MURf i2in32p3WLpy13fdwvvt2UBBJh4tGj/kE/K2yuZyOMF3bo1wWdSx+r4wRotcA1Y4zCMs EFNw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=HSMVP6CygzSzK33fUzNkXkQfCKGhcqy5DOv7A5XcWpA=; b=b4dUDMvs3WTZWe/40/rZpizPEkXx1oHR2VDzWfr3qop0hbNrKMw5cBChVwOdKh2qqu lPQ9qWIsp83tBXh3Uh6y2kzq98vM+29wHkbTqv5aR6RZ18JB+e8T8N+6d/sgTUNUpp8x ZYNaXJ8xeH/ZWrLLA+FtYjbCQpt4BuwG9YivJNj5Jmdg9zvRZnUzN/4cVshrToCFaj0a LYeGUohmwfrpElDu6XbUAiPjROAs7LQDvxrUmjBkKNY6LKhXB5la06T62EKL/BNIdGUx Ltc+m4u5VUu+J82ilL8RhMYTNJdEAKFXfliZozL1GRmzbY5ESFWg6KEXLM6njwHU5aGa //NA==
X-Gm-Message-State: ANhLgQ0UciwMgm4EVFQTmUyPwmchi+Kx9JAajs+0K57ubCr9rfjNN908 b1iZUCF2lHyAP+BmVGYeoD6QYA==
X-Google-Smtp-Source: ADFU+vvHJGwb6G4HQAVCzAxusK+ItHKY1itKHCiRf9yk9avN/J2lShnTbADwdrvKlGDZxtLknEiUJQ==
X-Received: by 2002:a2e:a553:: with SMTP id e19mr1039467ljn.64.1582849477803; Thu, 27 Feb 2020 16:24:37 -0800 (PST)
Received: from [10.0.1.14] (h-122-211.A530.priv.bahnhof.se. [213.80.122.211]) by smtp.gmail.com with ESMTPSA id x18sm3696463lfc.42.2020.02.27.16.24.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Feb 2020 16:24:36 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
From: Ragnar Sundblad <ragge@netnod.se>
In-Reply-To: <CAFgnS4VLFWG8-knrbBFPbzX4tjcLmkrdutpGfJNVeDqSrGS0FA@mail.gmail.com>
Date: Fri, 28 Feb 2020 01:24:35 +0100
Cc: gen-art <gen-art@ietf.org>, draft-ietf-ntp-using-nts-for-ntp.all@ietf.org, ntp@ietf.org, last-call@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <750D7FC7-1C6B-4A5D-ACF3-E4DCE6A6182F@netnod.se>
References: <158271156883.17827.13215176673371446527@ietfa.amsl.com> <28B9F231-09E7-4EC4-ACB3-1A9C4BFB8513@netnod.se> <CAFgnS4VLFWG8-knrbBFPbzX4tjcLmkrdutpGfJNVeDqSrGS0FA@mail.gmail.com>
To: Dan Romascanu <dromasca@gmail.com>
X-Mailer: Apple Mail (2.3608.60.0.2.5)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/9BzV6XoKWGZofhdYHy1u-K_8h9I>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-ntp-using-nts-for-ntp-22
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2020 00:24:43 -0000

Hi Dan,

> On 27 Feb 2020, at 21:31, Dan Romascanu <dromasca@gmail.com> wrote:
> 
> Thanks Ragnar, for the quick answer. 
> 
> See in-line. 
> 
> Regards,
> 
> Dan
> 
> 
> On Thu, Feb 27, 2020 at 6:56 PM Ragnar Sundblad <ragge@netnod.se> wrote:
> 
> Hi Dan,
> 
> Thank you for reviewing!
> 
> On 26 Feb 2020, at 11:06, Dan Romascanu via Datatracker <noreply@ietf.org> wrote:
> > 
> > Reviewer: Dan Romascanu
> > Review result: Ready with Issues
> > 
> > I am the assigned Gen-ART reviewer for this draft. The General Area
> > Review Team (Gen-ART) reviews all IETF documents being processed
> > by the IESG for the IETF Chair.  Please treat these comments just
> > like any other last call comments.
> > 
> > For more information, please see the FAQ at
> > 
> > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> > 
> > Document: draft-ietf-ntp-using-nts-for-ntp-22
> > Reviewer: Dan Romascanu
> > Review Date: 2020-02-26
> > IETF LC End Date: 2020-02-28
> > IESG Telechat date: Not scheduled for a telechat
> > 
> > Summary:
> > 
> > Ready with one minor issue to be discussed.
> > 
> > A very clear, well written, nicely organized document.
> > 
> > Major issues:
> > 
> > Minor issues:
> > 
> > 1. The tables in Sections 7.6, 7.7, 7.8 state that all undefined values in the
> > registries start immediately after the values defined by this document with
> > 'Reserved for Private and Experimental Use'. What about future extensions in
> > future versions of the document? Would not it be better to leave a range for
> > future extensions and start the values for private and experimental use farther
> > in the total spaces?
> 
> We are not sure what you mean - we believe that the tables say that the upper halves of the spaces are 'Reserved for Private and Experimental Use’, while the lower halves are unallocated except for those values that are specified in the draft. 
> 
> Do you have an example of how you would want it to be written/formatted instead?
> 
> It would be more clear if you added in the table in Section 7.6 for example: 
> 
> 8 - 16383 - Reserved for Future Standard Use

That information is in the "policy for allocation allocation of new entries" in a table (without frames) above the table for "the initial contents of the table" (with frames). I believe there was some reason for this, but I don’t know what it was.

I guess we have to investigate this ASAP.

> > Nits/editorial comments:
> > 
> > 1. In the (very useful) Appendix A for Terms and Abbreviations, there are a few
> > abbreviations usually considered part of the shared basis terms in IETF
> > documents (like TCP, UDP, IANA, ...)
> 
> Ok - Marcus is doing that right now.
> 
> Best regards,
> 
> Ragnar
>