[Gen-art] 答复: Review of draft-ietf-ccamp-flexible-grid-ospf-ext-08

Zhenghaomian <zhenghaomian@huawei.com> Mon, 13 February 2017 01:22 UTC

Return-Path: <zhenghaomian@huawei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 178A712954D; Sun, 12 Feb 2017 17:22:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.221
X-Spam-Level:
X-Spam-Status: No, score=-4.221 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nql-ZQeSjjOU; Sun, 12 Feb 2017 17:22:46 -0800 (PST)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 36CF912954B; Sun, 12 Feb 2017 17:22:45 -0800 (PST)
Received: from 172.18.7.190 (EHLO lhreml704-cah.china.huawei.com) ([172.18.7.190]) by lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id DAM02882; Mon, 13 Feb 2017 01:22:39 +0000 (GMT)
Received: from SZXEMA416-HUB.china.huawei.com (10.82.72.35) by lhreml704-cah.china.huawei.com (10.201.5.130) with Microsoft SMTP Server (TLS) id 14.3.301.0; Mon, 13 Feb 2017 01:22:38 +0000
Received: from SZXEMA504-MBX.china.huawei.com ([169.254.7.215]) by SZXEMA416-HUB.china.huawei.com ([10.82.72.35]) with mapi id 14.03.0235.001; Mon, 13 Feb 2017 09:22:20 +0800
From: Zhenghaomian <zhenghaomian@huawei.com>
To: Pete Resnick <presnick@qti.qualcomm.com>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Review of draft-ietf-ccamp-flexible-grid-ospf-ext-08
Thread-Index: AQHSg/TQqxb6Zkls30GMpx9otGdAXqFmJl+w
Date: Mon, 13 Feb 2017 01:22:20 +0000
Message-ID: <E0C26CAA2504C84093A49B2CAC3261A43988E8F6@SZXEMA504-MBX.china.huawei.com>
References: <148676904616.29176.18172899169844310297.idtracker@ietfa.amsl.com>
In-Reply-To: <148676904616.29176.18172899169844310297.idtracker@ietfa.amsl.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.57.78.114]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0202.58A10A63.00CA, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=169.254.7.215, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 941cf219dc341b2495025955e7d5b76b
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/9MzfCEyyXZKvD0Q8E3aAx9z32LM>
Cc: "draft-ietf-ccamp-flexible-grid-ospf-ext.all@ietf.org" <draft-ietf-ccamp-flexible-grid-ospf-ext.all@ietf.org>, "ccamp@ietf.org" <ccamp@ietf.org>
Subject: [Gen-art] 答复: Review of draft-ietf-ccamp-flexible-grid-ospf-ext-08
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Feb 2017 01:22:48 -0000

Hi, Pete, 

Thanks for your review. Please find my considerations inline...

Best wishes,
Haomian

-----邮件原件-----
发件人: Pete Resnick [mailto:presnick@qti.qualcomm.com] 
发送时间: 2017年2月11日 7:24
收件人: gen-art@ietf.org
抄送: draft-ietf-ccamp-flexible-grid-ospf-ext.all@ietf.org; ccamp@ietf.org
主题: Review of draft-ietf-ccamp-flexible-grid-ospf-ext-08

Reviewer: Pete Resnick
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-ccamp-flexible-grid-ospf-ext-08
Reviewer: Pete Resnick
Review Date: 2017-02-10
IETF LC End Date: 2017-01-31
IESG Telechat date: 2017-02-16

Summary: Ready with Nits

A couple of nits that I mentioned in my earlier review that you might want to address, but none of them are essential. (You may have decided that I was wrong; that's OK too.) I didn't bother Cc'ing the IETF list on this, since they're both very minor.

Major issues: None

Minor issues: None

Nits/editorial comments: 

3.1:

   A set of non-overlapping available frequency ranges MUST be 
   disseminated in order to allow efficient resource management of 
   flexi-grid DWDM links and RSA procedures which are described in 
   Section 4.8 of [RFC7698]. 

Those MUSTs look weird to me. I think instead of "MUST be" you mean "are", since it doesn't look like an implementation really has a choice here.
[Haomian] Noted and will change in next version.


3.2:

   Hence, in order to support all possible applications and 
   implementations the following information should be advertised for
   a flexi-grid DWDM link:
   
Is that "should" in there meant to be normative? That is, do bad things happen if I don't advertise one of those items? Or do you just mean "the following information is advertised..."? 

[Haomian] I feel weird if replace 'should be' with 'is', as you cannot support some application/implementation (rather than do bad things) if you don't advertise... How about following change? 

OLD
   Hence, in order to support all possible applications and 
   implementations the following information should be advertised for
   a flexi-grid DWDM link:
NEW
   Hence, in order to support all possible applications and 
   implementations the following information is required to be advertised
   for a flexi-grid DWDM link: