Re: [Gen-art] review of draft-ietf-teas-gmpls-lsp-fastreroute-09.txt

"Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com> Tue, 11 July 2017 15:29 UTC

Return-Path: <rgandhi@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2CCE913173A; Tue, 11 Jul 2017 08:29:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XEjeUzWVY0ZM; Tue, 11 Jul 2017 08:29:04 -0700 (PDT)
Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 29EBA131731; Tue, 11 Jul 2017 08:29:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=112128; q=dns/txt; s=iport; t=1499786944; x=1500996544; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=B3gYexeIJzEf6Udu+eG5YZtZsCOb3XI8RIvwHKLbyrg=; b=iYXgOTbrOkGj+l4to2QHlYwjKFfJYK+gx7TD07VSWYxo1rAgxwD+5KE+ GH4pdpAG+w+C2OVksgQqduCkGspVgV7jmqO5XB65N7sVsBoOxK+FX0hbp 9mf1ZPrxaJzTANXE5kPCa2vK3/0R7I9LLwt8/qYNhSphZO8snSFuDeYsX U=;
X-Files: Diff_ draft-ietf-teas-gmpls-lsp-fastreroute-09.txt - draft-ietf-teas-gmpls-lsp-fastreroute-10.txt.html : 78932
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CcAACn7WRZ/4kNJK1TChkBAQEBAQEBAQEBAQcBAQEBAYMtLWSBFAeDJoJJiBORbogujVWCES6DaYFfAhqDIz8YAQIBAQEBAQEBayiFGQYMDgkEBhopCRACAQYCEAQkAQkCAgIfESUCBAENBQ6KCQMVEI4hnWOBbDqDO4N0DYN4AQEBAQEBAQEBAQEBAQEBAQEBAQEBDg+DKINNgWABK4J5gldPgQoLBwsBIwcJCRiCWzCCMQWVYIQ2gzSBHzsChCiDHoNFhBGEboIMV4R0ik6LfYlJAR84fwt1FR8qEgGERzkcgWd2AQGFbQcIF4EMAYEMAQEB
X-IronPort-AV: E=Sophos;i="5.40,347,1496102400"; d="html'217?scan'217,208,217";a="453814231"
Received: from alln-core-4.cisco.com ([173.36.13.137]) by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Jul 2017 15:29:01 +0000
Received: from XCH-RCD-017.cisco.com (xch-rcd-017.cisco.com [173.37.102.27]) by alln-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id v6BFT1j9006966 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 11 Jul 2017 15:29:01 GMT
Received: from xch-aln-018.cisco.com (173.36.7.28) by XCH-RCD-017.cisco.com (173.37.102.27) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 11 Jul 2017 10:29:01 -0500
Received: from xch-aln-018.cisco.com ([173.36.7.28]) by XCH-ALN-018.cisco.com ([173.36.7.28]) with mapi id 15.00.1210.000; Tue, 11 Jul 2017 10:29:00 -0500
From: "Rakesh Gandhi (rgandhi)" <rgandhi@cisco.com>
To: Francis Dupont <Francis.Dupont@fdupont.fr>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-teas-gmpls-lsp-fastreroute.all@ietf.org" <draft-ietf-teas-gmpls-lsp-fastreroute.all@ietf.org>
Thread-Topic: review of draft-ietf-teas-gmpls-lsp-fastreroute-09.txt
Thread-Index: AQHS98sPi4SC0Bl9Okuug4aRvcHomqJO1iaA
Date: Tue, 11 Jul 2017 15:29:00 +0000
Message-ID: <71ACE8CC-95C7-4ED6-91C8-AE20AA556A1D@cisco.com>
References: <201707080901.v6891SNE044444@givry.fdupont.fr>
In-Reply-To: <201707080901.v6891SNE044444@givry.fdupont.fr>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1d.0.161209
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [161.44.213.149]
Content-Type: multipart/mixed; boundary="_002_71ACE8CC95C74ED691C8AE20AA556A1Dciscocom_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/BLloSHA3kmb9ytxLJdC_U9f3GW0>
Subject: Re: [Gen-art] review of draft-ietf-teas-gmpls-lsp-fastreroute-09.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jul 2017 15:29:12 -0000

Thank you Francis for the review and your comments.

Please find attached diff file with the suggested changes.

I could not understand your following comment. Are you suggesting to remove last “e” from “Acklowledge” ?

     - ToC page 3 and Acknowledgments page 21:
       Acknowledgements -> AcknowledgDements
    

Thanks,
Rakesh


On 2017-07-08, 5:01 AM, "Francis Dupont" <Francis.Dupont@fdupont.fr> wrote:

    I am the assigned Gen-ART reviewer for this draft. The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed
    by the IESG for the IETF Chair.  Please treat these comments just
    like any other last call comments.
    
    For more information, please see the FAQ at
    
    <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
    
    Document: draft-ietf-teas-gmpls-lsp-fastreroute-09.txt
    Reviewer: Francis Dupont
    Review Date: 20170706
    IETF LC End Date: 20170707
    IESG Telechat date: unknown
    
    Summary: Ready
    
    Major issues: None
    
    Minor issues: None
    
    Nits/editorial comments: 
     - ToC page 3 and Acknowledgments page 21:
       Acknowledgements -> AcknowledgDements
    
     - 1 page 4: you should introduce the LSP abbrev too (BTW if GMPLS
      is a well known abbrev cf
      https://www.rfc-editor.org/materials/abbrev.expansion.txt
      LSP is not, IMHO because this abbrev has some other meanings in
      the IETF scope)
    
     - 4.5.1 page 9: The Node-ID address must match the source -> MUST
      or has to
    
     - 4.5.1 page 9: may -> can (RFC 2119 did not clearly specify that
      keywords are only in uppercase. Note only the previous item is
      really ambiguous).
    
     - 5.1 page 11 and 5.2.2 page 14: e.g. -> e.g.,
    
     - 5.3 page 15 and 6 page 16: may -> can
    
     - 11.1 page 20 RFC3473: should be ReserVation -> ReSerVation
      but the bug is in the RFC 3473 title please don't fix...
    
     - Contributors page 21:
      * Orange CH is ambiguous: there are some cities named Orange,
       for instance a medium one in France. I suggest to put the CH
       on the next line
      * China -> PR China or CN (i.e., follow UPU or IETF specs)
    
    Thanks
    
    Francis.Dupont@fdupont.fr