Re: [Gen-art] Gen-ART Last Call review of draft-ietf-idr-add-paths-13

Jari Arkko <jari.arkko@piuha.net> Wed, 04 May 2016 20:18 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB7F612D594 for <gen-art@ietfa.amsl.com>; Wed, 4 May 2016 13:18:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.896
X-Spam-Level:
X-Spam-Status: No, score=-2.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.996] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yrJXaRp1n4PQ for <gen-art@ietfa.amsl.com>; Wed, 4 May 2016 13:18:00 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id 1429B12D145 for <gen-art@ietf.org>; Wed, 4 May 2016 13:17:59 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id A0BAB2CECE; Wed, 4 May 2016 23:17:57 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8LX1NlbW0kUZ; Wed, 4 May 2016 23:17:57 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 44BAF2CC64; Wed, 4 May 2016 23:17:56 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_45C46EC2-D566-4A36-A691-B1D528AE6EA4"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail 2.5.2
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <D34A239E.122969%aretana@cisco.com>
Date: Wed, 04 May 2016 16:17:52 -0400
Message-Id: <6F278770-22A6-44D2-8A02-A1CB9EF9C758@piuha.net>
References: <ABCAA4EF18F17B4FB619EA93DEF7939A456B7477@eusaamb107.ericsson.se> <D34A239E.122969%aretana@cisco.com>
To: "Alvaro Retana (aretana)" <aretana@cisco.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/F02apxcx3D5FYk4ERzBfGSdhOas>
Cc: "draft-ietf-idr-add-paths.all@tools.ietf.org" <draft-ietf-idr-add-paths.all@tools.ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-idr-add-paths-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2016 20:18:07 -0000

Meral, Alvaro — thanks for the review & updates.

Jari

On 30 Apr 2016, at 20:23, Alvaro Retana (aretana) <aretana@cisco.com> wrote:

> On 4/28/16, 4:24 PM, "Meral Shirazipour" <meral.shirazipour@ericsson.com> wrote:
> 
> Meral:
> 
> Hi!
> 
> Thank you for your review!
> 
> I just posted version –14.
> 
> Thanks!
> 
> Alvaro.
> 
> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.
>> 
>> For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>> 
>> 
>> Document:  draft-ietf-idr-add-paths-13
>> Reviewer: Meral Shirazipour
>> Review Date: 2016-04-28
>> IETF LC End Date: 2016-04-29
>> IESG Telechat date: 2016-05-05
>> 
>> 
>> Summary:
>> This draft is ready to be published as Standards Track RFC but I have some comments.
>> 
>> Major issues:
>> 
>> Minor issues:
>> -[Page 2] The introduction should give a hint of why this extension is necessary. Section 6 (Application) is pretty much empty in content too.
>> It would be important to add a few lines explaining the use cases and if any draft is started on those to give a pointer to them.
>> *An "Add-Paths Applications" section would be useful like the one in draft-ietf-idr-add-paths-guidelines-08.
>> 
>> 
>> -[Page 3],
>> "A BGP
>>   speaker that receives a route SHOULD NOT assume that the identifier
>>   carries any particular semantics; it SHOULD be treated as an opaque
>>   value.
>> "
>> *It would be good to justify why this restriction is imposed. If someone is using BGP add-Path internally, why prevent giving some semantics to the encoding?
>> 
>> 
>> -[Page 6], security section refers to Information guideline draft (draft-ietf-idr-add-paths-guidelines-08).
>> Is this draft also for IBGP only ? this was not clear.
>> 
>> 
>> Nits/editorial comments:
>> -[Page 7], References should be updated to newer versions.
>> 
>> 
>> 
>> 
>> Best Regards,
>> Meral
>> ---
>> Meral Shirazipour
>> Ericsson
>> Research
>> www.ericsson.com
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art