IETF Logo Mail Archive

Re: [Gen-art] Gen-ART Last Call review of draft-ietf-idr-add-paths-13

"Alvaro Retana (aretana)" <aretana@cisco.com> Sun, 01 May 2016 00:23 UTC

Return-Path: <aretana@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A1F0512D1B5 for <gen-art@ietfa.amsl.com>; Sat, 30 Apr 2016 17:23:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.516
X-Spam-Level:
X-Spam-Status: No, score=-15.516 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.996, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RFz_MDgfPkmY for <gen-art@ietfa.amsl.com>; Sat, 30 Apr 2016 17:23:36 -0700 (PDT)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 60E8312D1B4 for <gen-art@ietf.org>; Sat, 30 Apr 2016 17:23:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=11427; q=dns/txt; s=iport; t=1462062215; x=1463271815; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=UPbZ8ZsyzKaSiFoU6LYDee9y1YnBPbUagcvLDxSN4QI=; b=FQ7Nv8NgEmfUi9hgXQ6xmgGORhtiBnHn1s+GNftypIr+3Fs6FrwKI/uF rljTNGea/23JahsWpMQypZEIPMQAkefbGI0LtYhLcfGc5uTIZHQp/zzbu Jp3WEaqVo2JGidH697AvaqreHvqf5OFOFC5DpXlScvGc9JhcrVa310c+V U=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DoAgABTCVX/5RdJa1egmxMU30GhUGvOYRzAQ2BdiKEFoFYAoEdOBQBAQEBAQEBZSeEQgEBBC0cHiICAQgUKwcyFBEBAQQBEogqDsMkAQEBAQEBAQEBAQEBAQEBAQEBAReGIYRMhF2FNgWOD4UUhHEBhXuIHIFnToN/iF2PMAEPDwEBQoFMgh9sAYZ9fwEBAQ
X-IronPort-AV: E=Sophos;i="5.24,559,1454976000"; d="scan'208,217";a="103135226"
Received: from rcdn-core-12.cisco.com ([173.37.93.148]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2016 00:23:34 +0000
Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by rcdn-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id u410NYkg017273 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Sun, 1 May 2016 00:23:34 GMT
Received: from xch-aln-002.cisco.com (173.36.7.12) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Sat, 30 Apr 2016 19:23:33 -0500
Received: from xch-aln-002.cisco.com ([173.36.7.12]) by XCH-ALN-002.cisco.com ([173.36.7.12]) with mapi id 15.00.1104.009; Sat, 30 Apr 2016 19:23:33 -0500
From: "Alvaro Retana (aretana)" <aretana@cisco.com>
To: Meral Shirazipour <meral.shirazipour@ericsson.com>, "draft-ietf-idr-add-paths.all@tools.ietf.org" <draft-ietf-idr-add-paths.all@tools.ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART Last Call review of draft-ietf-idr-add-paths-13
Thread-Index: AdGhi/7KzOJo42TQRDacfxqhNtIwxwBvBCAA
Date: Sun, 01 May 2016 00:23:33 +0000
Message-ID: <D34A239E.122969%aretana@cisco.com>
References: <ABCAA4EF18F17B4FB619EA93DEF7939A456B7477@eusaamb107.ericsson.se>
In-Reply-To: <ABCAA4EF18F17B4FB619EA93DEF7939A456B7477@eusaamb107.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.6.2.160219
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.82.249.22]
Content-Type: multipart/alternative; boundary="_000_D34A239E122969aretanaciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/aa4sdjczAKbIyiPTgxZMYgwkayo>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-idr-add-paths-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 01 May 2016 00:23:38 -0000

On 4/28/16, 4:24 PM, "Meral Shirazipour" <meral.shirazipour@ericsson.com<mailto:meral.shirazipour@ericsson.com>> wrote:

Meral:

Hi!

Thank you for your review!

I just posted version -14.

Thanks!

Alvaro.


I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.


Document:  draft-ietf-idr-add-paths-13
Reviewer: Meral Shirazipour
Review Date: 2016-04-28
IETF LC End Date: 2016-04-29
IESG Telechat date: 2016-05-05


Summary:
This draft is ready to be published as Standards Track RFC but I have some comments.

Major issues:

Minor issues:
-[Page 2] The introduction should give a hint of why this extension is necessary. Section 6 (Application) is pretty much empty in content too.
It would be important to add a few lines explaining the use cases and if any draft is started on those to give a pointer to them.
*An "Add-Paths Applications" section would be useful like the one in draft-ietf-idr-add-paths-guidelines-08.


-[Page 3],
"A BGP
   speaker that receives a route SHOULD NOT assume that the identifier
   carries any particular semantics; it SHOULD be treated as an opaque
   value.
"
*It would be good to justify why this restriction is imposed. If someone is using BGP add-Path internally, why prevent giving some semantics to the encoding?


-[Page 6], security section refers to Information guideline draft (draft-ietf-idr-add-paths-guidelines-08).
Is this draft also for IBGP only ? this was not clear.


Nits/editorial comments:
-[Page 7], References should be updated to newer versions.




Best Regards,
Meral
---
Meral Shirazipour
Ericsson
Research
www.ericsson.com

v2.23.0 | Report a Bug | By Email