Re: [Gen-art] Gen-ART review of draft-ietf-kitten-extended-mech-inquiry-06.txt

Nicolas Williams <Nicolas.Williams@sun.com> Tue, 26 May 2009 23:24 UTC

Return-Path: <Nicolas.Williams@sun.com>
X-Original-To: gen-art@core3.amsl.com
Delivered-To: gen-art@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 7C0063A6B93 for <gen-art@core3.amsl.com>; Tue, 26 May 2009 16:24:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.89
X-Spam-Level:
X-Spam-Status: No, score=-5.89 tagged_above=-999 required=5 tests=[AWL=0.156, BAYES_00=-2.599, HELO_MISMATCH_COM=0.553, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xab2B7PlAixS for <gen-art@core3.amsl.com>; Tue, 26 May 2009 16:24:57 -0700 (PDT)
Received: from brmea-mail-1.sun.com (brmea-mail-1.Sun.COM [192.18.98.31]) by core3.amsl.com (Postfix) with ESMTP id 85B5D3A6818 for <gen-art@ietf.org>; Tue, 26 May 2009 16:24:57 -0700 (PDT)
Received: from dm-central-01.central.sun.com ([129.147.62.4]) by brmea-mail-1.sun.com (8.13.6+Sun/8.12.9) with ESMTP id n4QNQd3t007838 for <gen-art@ietf.org>; Tue, 26 May 2009 23:26:39 GMT
Received: from binky.Central.Sun.COM (binky.Central.Sun.COM [129.153.128.104]) by dm-central-01.central.sun.com (8.13.8+Sun/8.13.8/ENSMAIL, v2.2) with ESMTP id n4QNQcns052796 for <gen-art@ietf.org>; Tue, 26 May 2009 17:26:38 -0600 (MDT)
Received: from binky.Central.Sun.COM (localhost [127.0.0.1]) by binky.Central.Sun.COM (8.14.3+Sun/8.14.3) with ESMTP id n4QN9Ahj013552; Tue, 26 May 2009 18:09:10 -0500 (CDT)
Received: (from nw141292@localhost) by binky.Central.Sun.COM (8.14.3+Sun/8.14.3/Submit) id n4QN97sv013551; Tue, 26 May 2009 18:09:07 -0500 (CDT)
X-Authentication-Warning: binky.Central.Sun.COM: nw141292 set sender to Nicolas.Williams@sun.com using -f
Date: Tue, 26 May 2009 18:09:07 -0500
From: Nicolas Williams <Nicolas.Williams@sun.com>
To: Suresh Krishnan <suresh.krishnan@ericsson.com>
Message-ID: <20090526230907.GQ29258@Sun.COM>
References: <4A1C693C.1060809@ericsson.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <4A1C693C.1060809@ericsson.com>
User-Agent: Mutt/1.5.7i
Cc: kitten-ads@tools.ietf.org, kitten-chairs@tools.ietf.org, General Area Review Team <gen-art@ietf.org>, draft-ietf-kitten-extended-mech-inquiry@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-kitten-extended-mech-inquiry-06.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2009 23:24:58 -0000

On Tue, May 26, 2009 at 06:12:12PM -0400, Suresh Krishnan wrote:
> I am the assigned Gen-ART reviewer for
> draft-ietf-kitten-extended-mech-inquiry-06.txt

Thanks.

> Summary: This draft is almost ready for publication as Proposed Standard.
> 
> Substantial
> ===========
> 
> * Section 3.4.4
> 
> Shouldn't the output "name" be released with GSS_Release_buffer() as well?

No, because it's bound to be a constant.

Background: originally the GSS-API required all gss_OID values to be
released, but in practice it turned out that those were always
effectively constant, thus gss_release_oid() was unnecessary (except
when applied to the output of the obsoleted gss_str_to_oid()).

In this case we're talking about a name that's going to be effectively
constant too.

> Minor
> =====
> 
> * The IANA considerations section describes the policy for future 
> allocations as "IESG Protocol Action". Is it possible to use a known 
> policy (Standards Action or IESG Approval, perhaps) for this?

Oh, that's a mistake.  I need to dig out what the consensus had been in
the WG.  We'll definitely correct that during the publication process.

> * Section 3.4.3
> 
> GSS_Inquire_mech_attrs_for_mech() needs to be replaced by 
> GSS_Inquire_attrs_for_mech() as the former does not exist.

Indeed, that's an editing error on my part.  Good catch.

> Editorial
> ==========
> * Section 3.4.6:
> 
> Replace
> "To avoid this error we hereby define new typdefs which
>                                           ^^^^^^^
> with
> "To avoid this error we hereby define new typedefs which

*nod*

> * IANA Considerations
> 
> s/namsepace/namespace/

*nod*

Thanks!

Nico
--