Re: [Gen-art] [mpls] review: draft-ietf-mpls-extended-admin-group-05

Jari Arkko <jari.arkko@piuha.net> Thu, 15 May 2014 13:27 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8F9781A04C2 for <gen-art@ietfa.amsl.com>; Thu, 15 May 2014 06:27:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.551
X-Spam-Level:
X-Spam-Status: No, score=-2.551 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.651] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GWKGPS3s7Ezb for <gen-art@ietfa.amsl.com>; Thu, 15 May 2014 06:27:01 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id CEB6B1A0063 for <gen-art@ietf.org>; Thu, 15 May 2014 06:27:00 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 81B142CC5D; Thu, 15 May 2014 16:26:53 +0300 (EEST)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id et9cKHJCn9dV; Thu, 15 May 2014 16:26:52 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 47D8A2CC48; Thu, 15 May 2014 16:26:52 +0300 (EEST)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <CA+97oKMcpFDCOBSEzVLibPNu7rTKeXio0ku0BV4qeZ4Qk7CnFg@mail.gmail.com>
Date: Thu, 15 May 2014 15:26:51 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <E335ACAE-D319-4785-8C8A-EA8D8188132E@piuha.net>
References: <53597772.6000401@nostrum.com> <53598854.2010201@joelhalpern.com> <CA+97oKPxMJC2zngqUwfRGCNXtP61rqsoRdCbhLAj+_30dZTVeg@mail.gmail.com> <535A7903.2070704@joelhalpern.com> <CA+97oKPbtmSz8DLP8v6Xt3wwVNQdC7Qib0duj2orgyXwstGaXw@mail.gmail.com> <535A81AF.3030500@joelhalpern.com> <CA+97oKMcpFDCOBSEzVLibPNu7rTKeXio0ku0BV4qeZ4Qk7CnFg@mail.gmail.com>
To: Eric Osborne <eric@notcom.com>
X-Mailer: Apple Mail (2.1510)
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/GM81iKNBl1xcDXgfziLgEzKZfIs
Cc: General Area Review Team <gen-art@ietf.org>, mpls-chairs@tools.ietf.org
Subject: Re: [Gen-art] [mpls] review: draft-ietf-mpls-extended-admin-group-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 15 May 2014 13:27:03 -0000

Thank you Joel and Eric for the review and changes. 

Jari

On Apr 29, 2014, at 2:47 PM, Eric Osborne <eric@notcom.com> wrote:

> Done and posted as -06.
> 
> Chairs: This latest posting has all of the reviews, nits and other
> changes that have been requested.  It is ready for publication.
> 
> 
> 
> eric
> 
> On Fri, Apr 25, 2014 at 11:39 AM, Joel M. Halpern <jmh@joelhalpern.com> wrote:
>> That works for me.
>> Thank you Eric.
>> Yours,
>> Joel
>> 
>> 
>> On 4/25/14, 11:28 AM, Eric Osborne wrote:
>>> 
>>> Works for me.
>>> So
>>> 
>>> " The EAG sub-TLV is used in addition to the Administrative Groups
>>> when an operator wants to make more than 32 colors available for
>>> advertisement in a network"
>>> 
>>> I had gone back and forth with Adrian on language to scope this to a
>>> single LSDB, so as to avoid the discussion of signaling EAG desire in
>>> RSVP or PCEP.  I don't want to add that sort of disclaimer here too,
>>> as it makes the sentence clunky and unweildy.
>>> 
>>> 
>>> 
>>> eric
>>> 
>>> 
>>> On Fri, Apr 25, 2014 at 11:02 AM, Joel Halpern Direct
>>> <jmh.direct@joelhalpern.com> wrote:
>>>> 
>>>> What if instead of "on the link" it is simoply "in the network".  This
>>>> recommend the use of EAG whenever the operators is using more than 32
>>>> colors
>>>> across the link.  It thus actually better aligns with avoiding the
>>>> under-claiming issue by suggesting that operators should use the EAG if
>>>> they
>>>> have more than 32 candidate colors.
>>>> 
>>>> Yours,
>>>> Joel
>>>> 
>>>> PS: substituting wants for wishes is probably reasonable.  If we talk
>>>> about
>>>> network-wide you might even be able to us "intends".
>>>> 
>>>> 
>>>> On 4/25/14, 10:06 AM, Eric Osborne wrote:
>>>>> 
>>>>> 
>>>>> Hi Joel-
>>>>> 
>>>>>    Thanks for the review.  On your minor issue:
>>>>> ---
>>>>>   I believe it is more accurate to say that it is to be used "when a
>>>>> node wishes to advertise colors for a link which are not represented
>>>>> in the first 32 bits of the color mask."  The node may only wish to
>>>>> advertise colors 7 and 60, but that will require the EAG.
>>>>> ---
>>>>> 
>>>>> I see your point, but I'm having trouble coming up with obvious text.
>>>>> Deciding which colors are represented in a color mask is up to the
>>>>> operator, which means it would have to say something like
>>>>> 
>>>>> "when a node wishes to advertise colors for a link which the operator
>>>>> has defined to be outside the first 32 bits of the color mask".
>>>>> 
>>>>> but this would be the only use of 'color mask' in the document, and
>>>>> it's not one I've seen used in any other docs around link coloring.
>>>>> 
>>>>> The whole sentence you refer to is:
>>>>> 
>>>>> " The EAG sub-TLV is used in addition to the Administrative Groups
>>>>> when a node wishes to advertise more than 32 colors for a link."
>>>>> 
>>>>> If I rephrased it as
>>>>> 
>>>>> " The EAG sub-TLV is used in addition to the Administrative Groups
>>>>> when an operator wants to make more than 32 colors available for
>>>>> advertisement on a link"
>>>>> 
>>>>> would that do it?
>>>>> s/wishes/wants/ while I'm here.
>>>>> 
>>>>> 
>>>>> 
>>>>> eric
>>>>> 
>>>>> 
>>>>> On Thu, Apr 24, 2014 at 5:55 PM, Joel M. Halpern <jmh@joelhalpern.com>
>>>>> wrote:
>>>>>> 
>>>>>> 
>>>>>> I am the assigned Gen-ART reviewer for this draft. For background on
>>>>>> Gen-ART, please see the FAQ at
>>>>>> 
>>>>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>>>>> 
>>>>>> Please resolve these comments along with any other Last Call comments
>>>>>> you may receive.
>>>>>> 
>>>>>> Document: draft-ietf-mpls-extended-admin-group-05
>>>>>>      Extended Administrative Groups in MPLS-TE
>>>>>> Reviewer: Joel M. Halpern
>>>>>> Review Date: 24-April-2014
>>>>>> IETF LC End Date: 06-May-2014
>>>>>> IESG Telechat date: N/A
>>>>>> 
>>>>>> Summary: This document is ready for publication as a Proposed Standards
>>>>>> RFC
>>>>>> 
>>>>>> Major issues: N/A
>>>>>> 
>>>>>> Minor issues:
>>>>>>      I believe that the description of when to use this EAG is
>>>>>> slightly
>>>>>> misleading.  The text says that EAG is to be used "when a node wishes
>>>>>> to
>>>>>> advertise more than 32 colors for a link."  I believe it is more
>>>>>> accurate
>>>>>> to
>>>>>> say that it is to be used "when a node wishes to advertise colors for a
>>>>>> link
>>>>>> which are not represented in the first 32 bits of the color mask."  The
>>>>>> node
>>>>>> may only wish to advertise colors 7 and 60, but that will require the
>>>>>> EAG.
>>>>>> 
>>>>>> Nits/editorial comments: N/A
>>>>>> 
>>>>>> _______________________________________________
>>>>>> mpls mailing list
>>>>>> mpls@ietf.org
>>>>>> https://www.ietf.org/mailman/listinfo/mpls
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art