Re: [Gen-art] Gen-ART LC Review of draft-ietf-softwire-dslite-mib-11

"Yu Fu" <fuyu@cnnic.cn> Thu, 26 November 2015 09:13 UTC

Return-Path: <fuyu@cnnic.cn>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 069311B3793; Thu, 26 Nov 2015 01:13:20 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.187
X-Spam-Level:
X-Spam-Status: No, score=-3.187 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.585, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8zPUdj1KplXe; Thu, 26 Nov 2015 01:13:15 -0800 (PST)
Received: from cnnic.cn (smtp13.cnnic.cn [218.241.118.13]) by ietfa.amsl.com (Postfix) with ESMTP id 2923D1B3798; Thu, 26 Nov 2015 01:13:14 -0800 (PST)
Received: from LIUXD (unknown [218.241.103.218]) by ocmail02.zx.nicx.cn (Coremail) with SMTP id AQAAf0DJ0EwjzVZW4EXNCA--.64529S3; Thu, 26 Nov 2015 17:13:07 +0800 (CST)
From: Yu Fu <fuyu@cnnic.cn>
To: "'Matt Miller (mamille2)'" <mamille2@cisco.com>, draft-ietf-softwire-dslite-mib.all@ietf.org, gen-art@ietf.org
References: <5053E81C-A6AF-4398-949F-CBE045F537EA@cisco.com>
In-Reply-To: <5053E81C-A6AF-4398-949F-CBE045F537EA@cisco.com>
Date: Thu, 26 Nov 2015 17:13:13 +0800
Message-ID: <001601d1282a$adc71d20$09555760$@cn>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AQHRHZtjWI6rqNQ420y+H97gCzSU5Z6uFkZA
Content-Language: zh-cn
X-CM-TRANSID: AQAAf0DJ0EwjzVZW4EXNCA--.64529S3
X-Coremail-Antispam: 1UD129KBjvJXoWxWrWDuw1furyruFyDZw1DZFb_yoWrXw15pa 9rC3y2gr4kJwn3Awn7ur48ua4F93s3Ga15AFyUKw1jv3s8W3Z29rW2krWYyFyDGr4kur17 Ar4jkrs8Xa4DZrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkYb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8Jw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lc2xSY4AK67AK6r4fMxAIw28I cxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2 IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc40Y0x0EwIxGrwCI 42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42 IY6xAIw20EY4v20xvaj40_Gr0_Zr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280 aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU5WHq3UUUUU==
X-CM-SenderInfo: pix13q5fqqxugofq/
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/GvcdeGvpg_lFNZ7qruWxTzBED0U>
Subject: Re: [Gen-art] Gen-ART LC Review of draft-ietf-softwire-dslite-mib-11
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Nov 2015 09:13:20 -0000

Hi Matt,

Thanks for your review. All the nits have been corrected in the updated
version.

Thanks again

BR
Yu

-----Original Message-----
From: Matt Miller (mamille2) [mailto:mamille2@cisco.com] 
Sent: Friday, November 13, 2015 6:42 AM
To: draft-ietf-softwire-dslite-mib.all@ietf.org; gen-art@ietf.org
Subject: Gen-ART LC Review of draft-ietf-softwire-dslite-mib-11

I am the assigned Gen-ART reviewer for this draft. The General Area Review
Team (Gen-ART) reviews all IETF documents being processed by the IESG for
the IETF Chair.  Please treat these comments just like any other last call
comments.

For more information, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-softwire-dslite-mib-11
Reviewer: Matthew Miller
Review Date: 2015-11-12
IETF LC End Date: 2015-11-15
IESG Telechat date: N/A

Summary:

This document is ready to be published as a Standards Track RFC, but with
nits that ought to be addressed before publication.

Major issues:

Minor issues:

Nits/editorial comments:

* Note that draft-perrault-behave-natv2-mib is now RFC 7659; the reference
should be updated when (if) this document is updated.

* In section 4. "Relationship to the IF-MIB", "(physical or virtual)has an
ifEntry"
is missing a space between "virtual)" and "has".

* In section 5. "Difference from the IP tunnel MIB and NATV2-MIB", the fifth
paragraph was difficult for me to understand at first.
Assuming I understood the idea being expressed, maybe the following is
better:

OLD:

   In the DS-Lite scenario, the Address Family Transition Router (AFTR)
   is not only the tunnel end concentrator, but also a 4-4 translator.
   So as defined in [RFC6333] , when the IPv4 packets come back from the
   Internet to AFTR, the AFTR knows how to reconstruct the IPv6
   encapsulation by doing a reverse lookup in the extended IPv4 NAT
   binding table.  So the NAT binding table in the AFTR MUST be extended
   to include the IPv6 address of the tunnel initiator.  But the tunnel
   information defined in NATV2-MIB is on the address level.  Because
   the TUNNEL-MIB defined the objects on the view of interface, the DS-
   Lite-MIB need define the tunnel objects to extend the NAT binding
   entry by interface for accordance.  Therefore, a combined MIB is
   necessary.

NEW:

   In the DS-Lite scenario, the Address Family Transition Router (AFTR)
   is not only the tunnel end concentrator but also a 4-4 translator.
   As defined in [RFC6333], when the IPv4 packets come back from the
   Internet to the AFTR, it knows how to reconstruct the IPv6
   encapsulation by doing a reverse lookup in the extended IPv4 NAT
   binding table.  The NAT binding table in the AFTR MUST be extended
   to include the IPv6 address of the tunnel initiator.  However, the
   tunnel information defined in NATV2-MIB is on the address level.
   Because the TUNNEL-MIB defined the objects on the view of interface
   rather than the address, the DS-Lite-MIB needs to define the tunnel
   objects to extend the NAT binding entry by interface.  Therefore, a
   combined MIB is necessary.

* In section 6. "Structure of the MIB Module", "a" should be added between
"in" and "DS-Lite" in the sentence "The DS-Lite MIB provides a way to
monitor and manage the devices (AFTRs) in DS-Lite scenario through SNMP."

* In section 6.1.1. "The dsliteTunnel Subtree", "DS- Lite" should be
"DS-Lite".

* In section 6.1.1., the phrasing of "some objects defined in the IP Tunnel
MIB are not read-write and read-only" is confusing to me.  I'm not sure this
means "are not read-write but are read-only" or "are not readable" (which
there's a definition in section 9); are one of these interpretations
correct?

* In Section 9. "Security Considerations", the phrase "even then" seems to
be superfluous, and can be removed.

* In section 10. "IANA Considerations", "IP Tunnel MIB[RFC4087]" should be
"IP Tunnel MIB [RFC4087]".


--
- m&m

Matt Miller <mamille2@cisco.com>
Cisco Systems, Inc.