Re: [Gen-art] Gen-ART review of draft-ietf-ccamp-attribute-bnf-02

Lou Berger <lberger@labn.net> Wed, 19 October 2011 00:23 UTC

Return-Path: <lberger@labn.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D633A1F0C36 for <gen-art@ietfa.amsl.com>; Tue, 18 Oct 2011 17:23:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -100.025
X-Spam-Level:
X-Spam-Status: No, score=-100.025 tagged_above=-999 required=5 tests=[AWL=0.136, BAYES_00=-2.599, FH_RELAY_NODNS=1.451, HELO_MISMATCH_COM=0.553, IP_NOT_FRIENDLY=0.334, RDNS_NONE=0.1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uSaD-LGim3uX for <gen-art@ietfa.amsl.com>; Tue, 18 Oct 2011 17:23:40 -0700 (PDT)
Received: from oproxy3-pub.bluehost.com (oproxy3.bluehost.com [IPv6:2605:dc00:100:2::a3]) by ietfa.amsl.com (Postfix) with SMTP id 314DB1F0C35 for <gen-art@ietf.org>; Tue, 18 Oct 2011 17:23:39 -0700 (PDT)
Received: (qmail 25418 invoked by uid 0); 19 Oct 2011 00:23:39 -0000
Received: from unknown (HELO box313.bluehost.com) (69.89.31.113) by oproxy3.bluehost.com with SMTP; 19 Oct 2011 00:23:39 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=labn.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=1KV1xe7SPba3UXv3pZI0Ty8bVe6yQkcjR+FpjffrWXk=; b=zSGBkBIgP2RiOLqrRVZ53H9k3wkxgLXnMgYI84j4SKn3jQTHusMqvh50jpZqjXi+DZPoJDlgZUpfyA+Y9b4PD0X2kNLcr8bQe3AlK2AaOnFFYwiLfcMCzbK6Wo0ZGMCg;
Received: from box313.bluehost.com ([69.89.31.113] helo=[127.0.0.1]) by box313.bluehost.com with esmtpa (Exim 4.76) (envelope-from <lberger@labn.net>) id 1RGJwY-0002C0-N6; Tue, 18 Oct 2011 18:23:38 -0600
Message-ID: <4E9E188B.2080002@labn.net>
Date: Tue, 18 Oct 2011 20:23:39 -0400
From: Lou Berger <lberger@labn.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.9) Gecko/20100722 Eudora/3.0.4
MIME-Version: 1.0
To: adrian@olddog.co.uk
References: <008001cc8de2$2a2d02e0$7e8708a0$@olddog.co.uk>
In-Reply-To: <008001cc8de2$2a2d02e0$7e8708a0$@olddog.co.uk>
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Identified-User: {1038:box313.bluehost.com:labnmobi:labn.net} {sentby:smtp auth 69.89.31.113 authed with lberger@labn.net}
Cc: 'General Area Review Team' <gen-art@ietf.org>, draft-ietf-ccamp-attribute-bnf@tools.ietf.org, dbrungard@att.com
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-ccamp-attribute-bnf-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Oct 2011 00:23:40 -0000

Sounds just right to me.  Much thanks.

Lou

On 10/18/2011 6:06 PM, Adrian Farrel wrote:
> Hi,
> 
> There is already an RFC Editor Note saying...
> 
> Please edit for consistency:
>     The objects are called "LSP Attributes" and "LSP Required Attributes"
> 
> Let me know if anything else needs to be added.
> 
> Thanks,
> Adrian
> 
>> -----Original Message-----
>> From: Lou Berger [mailto:lberger@labn.net]
>> Sent: 18 October 2011 22:56
>> To: Vijay K. Gurbani
>> Cc: draft-ietf-ccamp-attribute-bnf@tools.ietf.org; dbrungard@att.com; Adrian
>> Farrel; General Area Review Team
>> Subject: Re: Gen-ART review of draft-ietf-ccamp-attribute-bnf-02
>>
>> Vijay,
>>
>> Please see below.
>>
>> On 10/17/2011 5:18 PM, Vijay K. Gurbani wrote:
>>> I am the assigned Gen-ART reviewer for this draft. For background on
>>> Gen-ART, please see the FAQ at
>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>>
>>> Please resolve these comments along with any other Last Call comments
>>> you may receive.
>>>
>>> Document: draft-ietf-ccamp-attribute-bnf-02
>>> Reviewer: Vijay K. Gurbani
>>> Review Date: Oct-17-2011
>>> IETF LC End Date: Not known.
>>> IESG Telechat date: Oct-20-2011
>>>
>>> Summary: This draft is ready as a Proposed Standard.
>>>
>>> Major issues: 0
>>> Minor issues: 2
>>> Nits/editorial comments: 3
>>>
>>> Minor:
>>> * S2: In the phrase, "... implementations must be capable ..."
>>>   is this a normative MUST?
>>>
>>> * S3: In the phrase, "... implementations must be capable ..."
>>>   is this a normative MUST?
>>>
>>
>> These are both in text quoted from RFC5420, so the comment applies to
>> that RFC.  Clearly we can't change it in this document. (BTW usage of
>> 'must' as in the English/informative usage is still legitimate.)
>>
>>> Nits:
>>> * Abstract: s/how LSP attribute are/how LSP attributes are/
>>>
>>
>> "LSP Attributes" is a term/name defined in RFC5420.
>>
>> This does point out that in three places in the document, the following
>> is needed:
>>  s/LSP attributes/LSP Attributes
>>
>>> * S1: "Two LSP Attributes related objects ..." --- This reads
>>>   funny.  Did you mean "Two LSP Attribute related objects..."?
>>>   This oversight, if indeed it is an oversight, is repeated else-
>>>   where in the document as well.
>>>
>>>   At other places (e.g., S3.2.1), you simply use "LSP Attribute object".
>>>   So I am not sure which one is correct.
>>>
>>
>> good catch!  it should be:
>> s/LSP Attribute/LSP Attributes
>>
>>> * S2.1: s/LSP attributed related objects/LSP attributes related objects/
>>>    or maybe "LSP Attribute related objects"?
>>
>> another good catch:
>>  s/LSP attributed/LSP Attributes
>>>
>>> - vijay
>>
>> Much thanks!
>>
>> Lou
> 
> 
> 
> 
>