IETF Logo Mail Archive

Re: [Gen-art] Gen-ART Telechat review of draft-ietf-pcp-third-party-id-option-04.txt

Jari Arkko <jari.arkko@piuha.net> Wed, 18 November 2015 22:31 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E3F51B3285; Wed, 18 Nov 2015 14:31:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.485
X-Spam-Level:
X-Spam-Status: No, score=-2.485 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.585] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V0C9JNjCu2za; Wed, 18 Nov 2015 14:31:45 -0800 (PST)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id 8D9471B3273; Wed, 18 Nov 2015 14:31:44 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id DCE582CC5D; Thu, 19 Nov 2015 00:31:43 +0200 (EET) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hBMO8h0qiOrO; Thu, 19 Nov 2015 00:31:43 +0200 (EET)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id DEB232CC52; Thu, 19 Nov 2015 00:31:42 +0200 (EET) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_B66071BA-EA58-4940-9D70-CFA87674D91D"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail 2.5.1
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <E87B771635882B4BA20096B589152EF63AA5ABFC@eusaamb107.ericsson.se>
Date: Thu, 19 Nov 2015 00:31:43 +0200
Message-Id: <1A1F1CA6-67F6-4E5B-AF60-7C4F55FF0A44@piuha.net>
References: <E87B771635882B4BA20096B589152EF63AA5ABFC@eusaamb107.ericsson.se>
To: Suresh Krishnan <suresh.krishnan@ericsson.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/Nsi0vVHR-n4wnbiOwKG3EPUc3L4>
Cc: "draft-ietf-pcp-third-party-id-option.all@ietf.org" <draft-ietf-pcp-third-party-id-option.all@ietf.org>, General Area Review Team <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART Telechat review of draft-ietf-pcp-third-party-id-option-04.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Nov 2015 22:31:46 -0000

Hmm. Thanks for your review, Suresh. Authors, any comments?

Jari

On 18 Nov 2015, at 06:15, Suresh Krishnan <suresh.krishnan@ericsson.com> wrote:

> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
> 
> Please wait for direction from your document shepherd or AD before
> posting a new version of the draft.
> 
> Document: draft-ietf-pcp-third-party-id-option-04.txt
> Reviewer: Suresh Krishnan
> Review Date: 2015/11/17
> IESG Telechat date: 2015/11/19
> 
> Summary: The draft is almost ready for publication as a Proposed Standard but
> I do have a major issue that needs to be addressed.
> 
> Major
> =====
> 
> * Section 5.2
> 
> The draft is a bit underspecified on how the THIRD_PARTY_ID carried in the
> option is compared to existing entries in the mapping table in the processing
> of request messages. Given that the option itself is loosely specified
> (allowing pretty much anything to be used as the ID) I think it is going to
> be very difficult to realize interoperable implementations unless the
> comparison method is clearly specified. e.g. Consider one of the options for
> THIRD_PARTY_ID described in the document - the MAC address. It could be
> carried as 48 bits binary (aabbccddeeff), hyphen delimited string of hex
> digits ("aa-bb-cc-dd-ee-ff") , colon delimited string of hex digits
> ("aa:bb:cc:dd:ee:ff") with upper case and lower case variants. If you intend
> this to be an exact bit by bit comparison, it would be helpful if you state
> it explicitly. If not, please state that as well.
> 
> Minor
> =====
> 
> * IANA considerations
> 
> "  [NOTE for IANA: Please allocate a PCP Option Code at
>    http://www.iana.org/assignments/pcp-parameters/pcp-
>    parameters.xml#option-rules]"
> 
> The URL for this registry is wrong. Did you mean
> 
> http://www.iana.org/assignments/pcp-parameters/pcp-parameters.xml#options
> 
> instead?
> 
> Thanks
> Suresh
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email