Re: [Gen-art] Gen-ART LC Review of draft-ietf-radext-ieee802ext-10

Jouni Korhonen <jouni.nospam@gmail.com> Wed, 26 March 2014 09:41 UTC

Return-Path: <jouni.nospam@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C84A61A02E2 for <gen-art@ietfa.amsl.com>; Wed, 26 Mar 2014 02:41:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k6ThTlYzbj8B for <gen-art@ietfa.amsl.com>; Wed, 26 Mar 2014 02:41:37 -0700 (PDT)
Received: from mail-lb0-x22d.google.com (mail-lb0-x22d.google.com [IPv6:2a00:1450:4010:c04::22d]) by ietfa.amsl.com (Postfix) with ESMTP id 011371A01FF for <gen-art@ietf.org>; Wed, 26 Mar 2014 02:41:36 -0700 (PDT)
Received: by mail-lb0-f173.google.com with SMTP id p9so1281666lbv.18 for <gen-art@ietf.org>; Wed, 26 Mar 2014 02:41:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rgLpCWzi7Njz9UDeZ7ip0oebhrZKJes6KdcJ1m90Wrw=; b=EhxkF02xfQ6xzNv1yG8cxAKnQA3lV7bMmBMSY+jgit6YU5s9SdxR5Yhe4yMFMIar/J aYJuTp9QNGQGvHTh2R1sUt7jsbrHasv91IZmgXHkdkex829jW/sYPtyP5KbMHlK7Kdsh /bvqiUck82HWD3JjGPf3O/e6nB/U+nMUjIXhFN8CLiElp4++v1ArBu/T/vNZIBwWCsdv 7E8W+bNkPMaQN+2GHAyDCY3tmw5GmyEZmw7OT670fl4okiPEPNS+0H30OrHmoVJrwfPE g6jI1JaKgPFFgL0StBhaAel753lWO/GJLEQZ0hoDzOreGTzeJeDaD862+rlGXTSzFzcT Qq0Q==
X-Received: by 10.112.30.233 with SMTP id v9mr5302442lbh.35.1395826894909; Wed, 26 Mar 2014 02:41:34 -0700 (PDT)
Received: from [188.117.15.107] ([188.117.15.107]) by mx.google.com with ESMTPSA id q8sm13611024lbr.3.2014.03.26.02.41.31 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 26 Mar 2014 02:41:32 -0700 (PDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: Jouni Korhonen <jouni.nospam@gmail.com>
In-Reply-To: <0B1AE081-091D-4EEE-A658-D0D80998EC0E@piuha.net>
Date: Wed, 26 Mar 2014 11:41:30 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <DD025780-6108-44DF-9226-0535B6089204@gmail.com>
References: <8C9EE7F2-AA3D-482A-B469-4A147D143954@nostrum.com> <530F38BE.3030508@cisco.com> <0B1AE081-091D-4EEE-A658-D0D80998EC0E@piuha.net>
To: Jari Arkko <jari.arkko@piuha.net>
X-Mailer: Apple Mail (2.1510)
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/NxS_Qe1x6axqRPek43MFuM--wFk
Cc: Benoit Claise <bclaise@cisco.com>, Ben Campbell <ben@nostrum.com>, "gen-art@ietf.org Team (gen-art@ietf.org)" <gen-art@ietf.org>, draft-ietf-radext-ieee802ext.all@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART LC Review of draft-ietf-radext-ieee802ext-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Mar 2014 09:41:40 -0000

I don't think there is anything that needs to be done for 2.2. It is
a normal capability exchange type of mechanism.

The text is IMHO clear:
"in situations where the Attribute is required to provision service.."

Then the lack of EAP-Key-Name means the service cannot be provisioned
and the NAS can safely interpret that as an Access-Reject, when 
appropriate by the deployment.

NAS doesn't include the attribute if it is not needed. And if it does,
the current text allows still accepting the service regardless the
lack of the attribute in the Access-Accept.


- Jouni


On Mar 26, 2014, at 8:55 AM, Jari Arkko <jari.arkko@piuha.net> wrote:

> Thanks for the review. I did not see a response or change regarding 2.1 or 2.2. Does this need to be addressed? Authors?
> 
> Jari
> 
> On Feb 27, 2014, at 9:08 PM, Benoit Claise <bclaise@cisco.com> wrote:
> 
>> Dear authors,
>> 
>> Can you please follow up on that one.
>> 
>> Regards, Benoit
>>> I am the assigned Gen-ART reviewer for this draft. For background on
>>> Gen-ART, please see the FAQ at
>>> 
>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>> 
>>> Please resolve these comments along with any other Last Call comments
>>> you may receive.
>>> 
>>> Document: draft-ietf-radext-ieee802ext-10
>>> Reviewer: Ben Campbell
>>> Review Date: 2014-01-31
>>> IETF LC End Date: 2014-02-04
>>> 
>>> Summary: This draft is almost ready for publication as a standards track RFC. I have a small number of minor comments that may be worth considering prior to publication.
>>> 
>>> Major issues: None
>>> 
>>> Minor issues:
>>> 
>>> -- 2.1, last paragraph:
>>> 
>>> Does the last sentence imply Allowed-Called-Station-Id actually should (or SHOULD) not be used in non-wireless scenarios? (I note that the Network-Id-Name section talks about how 802.1X NID-Names should not be included in Called-Station-Id, but rather put in Network-Id-Name. Does that apply here as well?
>>> 
>>> -- 2.2, last paragraph: "Since a NAS will typically only include a EAP-Key-Name Attribute in an Access-Request in situations where the Attribute is required to provision service, if an EAP-Key-Name Attribute is included in an Access-Request but is not present in the Access-Accept, the NAS SHOULD treat the Access-Accept as though it were an Access-Reject. "
>>> 
>>> Is there a backwards compatibility issue? What if a NAS sends the field to a server that doesn't implement this draft? Is there an assumption that a NAS that supports this draft will only work with a server that also supports it?
>>> 
>>> Or more to the point, is the "...typically only include...where required..." strong enough to require a normative SHOULD? Seems like this would discourage the inclusion of EAP-Key-Name in the non-typical case of it _not_ being required. Is that the intent?
>>> 
>>> Nits/editorial comments:
>>> 
>>> -- section 2.8:
>>> 
>>> It might be worth expanding "EAPoL"
>>> 
>>> 
>>> 
>>> .
>>> 
>> 
>> _______________________________________________
>> Gen-art mailing list
>> Gen-art@ietf.org
>> https://www.ietf.org/mailman/listinfo/gen-art
>