Re: [Gen-art] Gen-ART LC Review of draft-ietf-radext-ieee802ext-10

Jari Arkko <jari.arkko@piuha.net> Thu, 27 March 2014 07:04 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A129A1A0471 for <gen-art@ietfa.amsl.com>; Thu, 27 Mar 2014 00:04:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QH3Ge4LHAfQO for <gen-art@ietfa.amsl.com>; Thu, 27 Mar 2014 00:04:46 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [193.234.218.130]) by ietfa.amsl.com (Postfix) with ESMTP id 2B2281A0470 for <gen-art@ietf.org>; Thu, 27 Mar 2014 00:04:30 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 37C552CC5F; Thu, 27 Mar 2014 09:04:27 +0200 (EET)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5_35yFVjzZAQ; Thu, 27 Mar 2014 09:04:25 +0200 (EET)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 3D1DE2CC48; Thu, 27 Mar 2014 09:04:24 +0200 (EET)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <E3DBC2F0-A164-41E4-BB28-C511AF502644@nostrum.com>
Date: Thu, 27 Mar 2014 09:04:24 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <D743BCD0-19F7-4564-A2A5-34CFF5B13183@piuha.net>
References: <8C9EE7F2-AA3D-482A-B469-4A147D143954@nostrum.com> <530F38BE.3030508@cisco.com> <0B1AE081-091D-4EEE-A658-D0D80998EC0E@piuha.net> <DD025780-6108-44DF-9226-0535B6089204@gmail.com> <BLU406-EAS63EE021E0D191EB124819B93640@phx.gbl> <E3DBC2F0-A164-41E4-BB28-C511AF502644@nostrum.com>
To: Ben Campbell <ben@nostrum.com>
X-Mailer: Apple Mail (2.1510)
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/UTqKdec-PFajGC6q2LdVFAm-fQ4
Cc: Bernard Aboba <bernard_aboba@hotmail.com>, Benoit Claise <bclaise@cisco.com>, Jouni Korhonen <jouni.nospam@gmail.com>, "draft-ietf-radext-ieee802ext.all@tools.ietf.org" <draft-ietf-radext-ieee802ext.all@tools.ietf.org>, "gen-art@ietf.org Team (gen-art@ietf.org)" <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART LC Review of draft-ietf-radext-ieee802ext-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2014 07:04:50 -0000

Thanks, I have placed a no-obj position on the ballot. I agree with Ben that additional explanation might be useful.

Jari

On Mar 27, 2014, at 6:18 AM, Ben Campbell <ben@nostrum.com> wrote:

> I'm satisfied with the responses. I think it would not hurt to add some of the explanations from the various emails into the draft, but that's by no means a show stopper.
> 
> Thanks!
> 
> Ben.
> 
> On Mar 26, 2014, at 7:17 AM, Bernard Aboba <bernard_aboba@hotmail.com> wrote:
> 
>> In 802.1X-2010, the EAP Key Name is  actually needed to calculate the session keys. So if it is unavailable, the NAS won't be able to decrypt traffic. Therefore treating the Accept as a Reject is probably the only viable option.
>> 
>>> On Mar 26, 2014, at 5:42 AM, "Jouni Korhonen" <jouni.nospam@gmail.com> wrote:
>>> 
>>> 
>>> I don't think there is anything that needs to be done for 2.2. It is
>>> a normal capability exchange type of mechanism.
>>> 
>>> The text is IMHO clear:
>>> "in situations where the Attribute is required to provision service.."
>>> 
>>> Then the lack of EAP-Key-Name means the service cannot be provisioned
>>> and the NAS can safely interpret that as an Access-Reject, when 
>>> appropriate by the deployment.
>>> 
>>> NAS doesn't include the attribute if it is not needed. And if it does,
>>> the current text allows still accepting the service regardless the
>>> lack of the attribute in the Access-Accept.
>>> 
>>> 
>>> - Jouni
>>> 
>>> 
>>>> On Mar 26, 2014, at 8:55 AM, Jari Arkko <jari.arkko@piuha.net> wrote:
>>>> 
>>>> Thanks for the review. I did not see a response or change regarding 2.1 or 2.2. Does this need to be addressed? Authors?
>>>> 
>>>> Jari
>>>> 
>>>>> On Feb 27, 2014, at 9:08 PM, Benoit Claise <bclaise@cisco.com> wrote:
>>>>> 
>>>>> Dear authors,
>>>>> 
>>>>> Can you please follow up on that one.
>>>>> 
>>>>> Regards, Benoit
>>>>>> I am the assigned Gen-ART reviewer for this draft. For background on
>>>>>> Gen-ART, please see the FAQ at
>>>>>> 
>>>>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>>>>> 
>>>>>> Please resolve these comments along with any other Last Call comments
>>>>>> you may receive.
>>>>>> 
>>>>>> Document: draft-ietf-radext-ieee802ext-10
>>>>>> Reviewer: Ben Campbell
>>>>>> Review Date: 2014-01-31
>>>>>> IETF LC End Date: 2014-02-04
>>>>>> 
>>>>>> Summary: This draft is almost ready for publication as a standards track RFC. I have a small number of minor comments that may be worth considering prior to publication.
>>>>>> 
>>>>>> Major issues: None
>>>>>> 
>>>>>> Minor issues:
>>>>>> 
>>>>>> -- 2.1, last paragraph:
>>>>>> 
>>>>>> Does the last sentence imply Allowed-Called-Station-Id actually should (or SHOULD) not be used in non-wireless scenarios? (I note that the Network-Id-Name section talks about how 802.1X NID-Names should not be included in Called-Station-Id, but rather put in Network-Id-Name. Does that apply here as well?
>>>>>> 
>>>>>> -- 2.2, last paragraph: "Since a NAS will typically only include a EAP-Key-Name Attribute in an Access-Request in situations where the Attribute is required to provision service, if an EAP-Key-Name Attribute is included in an Access-Request but is not present in the Access-Accept, the NAS SHOULD treat the Access-Accept as though it were an Access-Reject. "
>>>>>> 
>>>>>> Is there a backwards compatibility issue? What if a NAS sends the field to a server that doesn't implement this draft? Is there an assumption that a NAS that supports this draft will only work with a server that also supports it?
>>>>>> 
>>>>>> Or more to the point, is the "...typically only include...where required..." strong enough to require a normative SHOULD? Seems like this would discourage the inclusion of EAP-Key-Name in the non-typical case of it _not_ being required. Is that the intent?
>>>>>> 
>>>>>> Nits/editorial comments:
>>>>>> 
>>>>>> -- section 2.8:
>>>>>> 
>>>>>> It might be worth expanding "EAPoL"
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> .
>>>>> 
>>>>> _______________________________________________
>>>>> Gen-art mailing list
>>>>> Gen-art@ietf.org
>>>>> https://www.ietf.org/mailman/listinfo/gen-art
>>> 
>> 
>> _______________________________________________
>> Gen-art mailing list
>> Gen-art@ietf.org
>> https://www.ietf.org/mailman/listinfo/gen-art
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art