Re: [Gen-art] review of draft-ietf-httpauth-digest-15.txt
Jari Arkko <jari.arkko@piuha.net> Tue, 21 April 2015 07:03 UTC
Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C55A11B36A2 for <gen-art@ietfa.amsl.com>; Tue, 21 Apr 2015 00:03:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d2DwVn1DYOTw for <gen-art@ietfa.amsl.com>; Tue, 21 Apr 2015 00:03:37 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [IPv6:2a00:1d50:2::130]) by ietfa.amsl.com (Postfix) with ESMTP id EF6C81B3691 for <gen-art@ietf.org>; Tue, 21 Apr 2015 00:03:27 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 205B72CC5F; Tue, 21 Apr 2015 10:03:27 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NP51r7hbBSsq; Tue, 21 Apr 2015 10:03:25 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 44DC02CC5D; Tue, 21 Apr 2015 10:03:25 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Content-Type: multipart/signed; boundary="Apple-Mail=_306BB2EA-A7CE-4AC7-B960-BEA29B2F5588"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <CAGL6epJgyeq8d+_gWVRmocsqshF14LAaszxWMY30Rdfah3bNwQ@mail.gmail.com>
Date: Tue, 21 Apr 2015 10:03:24 +0300
Message-Id: <2AEF5D11-155B-4F4F-AFE5-569685CDA8D0@piuha.net>
References: <201504061758.t36HwgRi005964@givry.fdupont.fr> <CAGL6epJgyeq8d+_gWVRmocsqshF14LAaszxWMY30Rdfah3bNwQ@mail.gmail.com>
To: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/Ny_pUxGb9mxyKs-Zwn4Som8HquQ>
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, draft-ietf-httpauth-digest.all@tools.ietf.org
Subject: Re: [Gen-art] review of draft-ietf-httpauth-digest-15.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2015 07:03:38 -0000
Thanks for your review, Francis, and for your responses, Rifaat. Jari On 06 Apr 2015, at 23:01, Rifaat Shekh-Yusef <rifaat.ietf@gmail.com> wrote: > Hi Francis, > > Thanks for your review and comments. I will address the nits in the next version of the draft. > Please, see my reply to some of your comments inline... > > Regards, > Rifaat > > > On Mon, Apr 6, 2015 at 1:58 PM, Francis Dupont <Francis.Dupont@fdupont.fr> wrote: > I am the assigned Gen-ART reviewer for this draft. For background on > Gen-ART, please see the FAQ at > > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > > Please resolve these comments along with any other Last Call comments > you may receive. > > Document: draft-ietf-httpauth-digest-15.txt > Reviewer: Francis Dupont > Review Date: 20150402 > IETF LC End Date: 20150402 > IESG Telechat date: unknown > > Summary: Ready > > Major issues: None > > Minor issues: None > > Nits/editorial comments: > I reviewed the 15 version but I can see the 16 one is already available > so I'll try to update my comments. > > - first I was a bit surprised nobody just asked to jump to HTTPS (or > HSTS) but reading the document it seems there are still good use > of the digest authentication scheme... > > - 3.3 page 5: IMHO the "opaque" field is clearly a nonce > (i.e., more a nonce than the "nonce" field) but I understand this > was inherited from RFC 2617... > > - 3.3 page 7 (algorithm, twice) and some other places: > e.g. -> e.g., > > - 3.3 page 7 (algorithm): I noted the algo protocol is still > a keyed one vs. HMAC (cf. AH which switched from keyed to HMAC > between RFC 1826 and RFC 2402) but I believed you have a good > reason to do this (and the secdir will say if it is OK anyway). > > > Good question. > Using HMAC would impact the H(A1) calculation and the KD function, but it would definitely work. > If there is interest and support for adding HMAC, I would be happy to do that. > > > - 3.4.2 page 11: e.g. -> e.g., (again but this one is at the end of a line) > > - 3.4.2 page 11: cnounce -> cnonce > > - 3.4.2 page 11: the presentation of this definition is very > misleading: > > A1 = H( unq(username) ":" unq(realm) > ":" passwd ) > ":" unq(nonce-prime) ":" unq(cnonce-prime) > > I strongly suggest something like: > > A1 = H( unq(username) ":" unq(realm) ":" passwd ) > ":" unq(nonce-prime) ":" unq(cnonce-prime) > > > Sure. > > > - 3.4.2 page 11: the server need only use > ^ needs > > - 3.5 page 14: affects -> effects > > - 5.2 page 21: this information need not be decrypted > ^ needs > > - 6.1 page 27: can you instantiate the RFC XXX: > MD5: RFC 1321 > SHA-256: FIPS 180-2 > SHA-512/256: FIPS 180-4? > > > The RFC used in the table should point to the current draft which does not have an RFC # yet. > Kathleen has already raised an issue about this and she suggested a text that was added to v16. > > Regards, > Rifaat > > > - A page 30: negotitation -> negotiation > > Regards > > Francis.Dupont@fdupont.fr > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] review of draft-ietf-httpauth-digest-15… Francis Dupont
- Re: [Gen-art] review of draft-ietf-httpauth-diges… Rifaat Shekh-Yusef
- Re: [Gen-art] review of draft-ietf-httpauth-diges… Jari Arkko