Re: [Gen-art] Gen-ART review of draft-ietf-ccamp-lmp-behavior-negotiation-10

Lou Berger <lberger@labn.net> Tue, 05 February 2013 14:53 UTC

Return-Path: <lberger@labn.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EF19921F88B4 for <gen-art@ietfa.amsl.com>; Tue, 5 Feb 2013 06:53:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.492
X-Spam-Level:
X-Spam-Status: No, score=-101.492 tagged_above=-999 required=5 tests=[AWL=0.773, BAYES_00=-2.599, IP_NOT_FRIENDLY=0.334, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gKtH6rn+chHp for <gen-art@ietfa.amsl.com>; Tue, 5 Feb 2013 06:53:57 -0800 (PST)
Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by ietfa.amsl.com (Postfix) with SMTP id 369EF21F88B5 for <gen-art@ietf.org>; Tue, 5 Feb 2013 06:53:57 -0800 (PST)
Received: (qmail 20318 invoked by uid 0); 5 Feb 2013 14:53:31 -0000
Received: from unknown (HELO box313.bluehost.com) (69.89.31.113) by cpoproxy3.bluehost.com with SMTP; 5 Feb 2013 14:53:31 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=labn.net; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=Zp/lg88axpdkqgMzJIPHgbhQmWfOAxKzzPMhW9VJ3l0=; b=f+dvtRQio8Dzg27E2nABalxNQJdlAXTN24yXWc5Rj7+f69KplZG7BbSuI/iAX3nSk8+jCMMg4xZ68vSGtpmf2QLNOYzyJpFXgtzifjaoRuuKPbjKxTvJnMzi51mIuP0J;
Received: from box313.bluehost.com ([69.89.31.113]:48237 helo=[127.0.0.1]) by box313.bluehost.com with esmtpa (Exim 4.80) (envelope-from <lberger@labn.net>) id 1U2jtq-0003zi-Q2; Tue, 05 Feb 2013 07:53:31 -0700
Message-ID: <51111CE8.2060204@labn.net>
Date: Tue, 05 Feb 2013 09:53:28 -0500
From: Lou Berger <lberger@labn.net>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2
MIME-Version: 1.0
To: Richard Barnes <rbarnes@bbn.com>
References: <543BED18-B326-4649-A35C-0BFB2FAA2E35@bbn.com>
In-Reply-To: <543BED18-B326-4649-A35C-0BFB2FAA2E35@bbn.com>
X-Enigmail-Version: 1.5
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Identified-User: {1038:box313.bluehost.com:labnmobi:labn.net} {sentby:smtp auth 69.89.31.113 authed with lberger@labn.net}
Cc: draft-ietf-ccamp-lmp-behavior-negotiation@tools.ietf.org, "gen-art@ietf.org" <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, The IESG <iesg@ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-ccamp-lmp-behavior-negotiation-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Feb 2013 14:53:58 -0000

Richard,
	Thank you for the review.  I have one additional question/response on
your comments:

On 2/3/2013 2:13 PM, Richard Barnes wrote:
> I have been selected as the General Area Review Team (Gen-ART) reviewer for this draft (for background on Gen-ART, please seehttp://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).
> 
> Please wait for direction from your document shepherd or AD before posting a new version of the draft.
> 
> Document: draft-ietf-ccamp-lmp-behavior-negotiation-10
> Reviewer: Richard Barnes
> Review Date: 2013-02-02
> IETF LC End Date: 2012-01-21
> IESG Telechat date: 2012-02-07
> 
> Summary:  Ready, with a couple of minor questions / clarifications.
> 
> Comment:
> 
> Overall, this document seems very clear and readable.  Thanks!  The one concern I have is over the use of "likely" in the discussion of backward compatibility; I would like to see more precise language there.
> 
> Section 2.1.  Would be helpful to either include the old formats and/or say explicitly what is changing. 
> 
> Section 2.2.  
> "Nodes which support" -> "nodes that support"  
> "Ordering of CONFIG objects" -> "... With different C-type values"
> 
> Section 3.1.MBZ. Might help to clarify that this means that the
> number of bits MUST be a multiple of 32. (I got a little confused
> between bits and bytes here.)
> 

I think you're right.  The current text can easily result in confision
between the size of the MBZ field and the setting of the length field
define in RFC4204.  It's probably best to just remove the reference to
the length field. How about this:

OLD
The number of bits present is based on the Length field of the LMP
object header and MUST include enough bits so the Length field MUST be
at least 8, and MUST be a multiple of 4.

NEW
This field MUST be sized to ensure 32 bit alignment of the object.

Lou
(co-author)

> Section 4. "Likely"
> Is it possible for a 4204-compliant implementation to not do one of these?  If so then remove "likely".  If not, then why happens on the exceptional case?
> 
> 
>