[Gen-art] Genart last call review of draft-ietf-avtcore-cryptex-05

Linda Dunbar via Datatracker <noreply@ietf.org> Tue, 05 April 2022 18:18 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 991C43A0E4D; Tue, 5 Apr 2022 11:18:31 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Linda Dunbar via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: avt@ietf.org, draft-ietf-avtcore-cryptex.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.46.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <164918271145.1399.16972717746743002964@ietfa.amsl.com>
Reply-To: Linda Dunbar <linda.dunbar@futurewei.com>
Date: Tue, 05 Apr 2022 11:18:31 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/OSDyO_tiu5StDZyyJjwRP-Nvj-M>
Subject: [Gen-art] Genart last call review of draft-ietf-avtcore-cryptex-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Apr 2022 18:18:32 -0000

Reviewer: Linda Dunbar
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-avtcore-cryptex-05
Reviewer: Linda Dunbar
Review Date: 2022-04-05
IETF LC End Date: 2022-04-05
IESG Telechat date: Not scheduled for a telechat

Summary:
This document specifies a new mechanism that completely encrypts header
extensions and CSRCs for RTP.

Major issues: None

Minor issues: None

Nits/editorial comments:

a couple of questions:
- Section 4: this document defines a new "a=cryptex" Session Description
Protocol (SDP) [RFC4566] attribute to indicate support. Then the next sentence
states that "This attribute takes no value".  Why "no value"?  The first
statement already says a new "a=cryptex" attribute.  It is confusing.

-  Section 6.3:  what does "region" mean in the statement?   "The decryption
procedure is identical to that of [RFC3711] except for the region to decrypt" 
Do you mean the "header" to be encrypted by the scheme described in this
document?

Thank you,
Linda Dunbar