Re: [Gen-art] Gen-ART Telechat Call review of draft-ietf-ipsecme-rfc7321bis-05

Daniel Migault <daniel.migault@ericsson.com> Tue, 14 March 2017 22:08 UTC

Return-Path: <daniel.migault@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EEDBC129BAB for <gen-art@ietfa.amsl.com>; Tue, 14 Mar 2017 15:08:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.301
X-Spam-Level:
X-Spam-Status: No, score=-2.301 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gC9rfcKcUePu for <gen-art@ietfa.amsl.com>; Tue, 14 Mar 2017 15:08:03 -0700 (PDT)
Received: from usplmg21.ericsson.net (usplmg21.ericsson.net [198.24.6.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E46EE129406 for <gen-art@ietf.org>; Tue, 14 Mar 2017 15:08:02 -0700 (PDT)
X-AuditID: c6180641-0291898000000a06-d4-58c8236ad043
Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by (Symantec Mail Security) with SMTP id D1.A6.02566.A6328C85; Tue, 14 Mar 2017 18:07:55 +0100 (CET)
Received: from EUSAAMB107.ericsson.se ([147.117.188.124]) by EUSAAHC003.ericsson.se ([147.117.188.81]) with mapi id 14.03.0319.002; Tue, 14 Mar 2017 18:07:58 -0400
From: Daniel Migault <daniel.migault@ericsson.com>
To: Meral Shirazipour <meral.shirazipour@ericsson.com>, "draft-ietf-ipsecme-rfc7321bis.all@tools.ietf.org" <draft-ietf-ipsecme-rfc7321bis.all@tools.ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART Telechat Call review of draft-ietf-ipsecme-rfc7321bis-05
Thread-Index: AdKdAJZ8FTTBicuLQv2tDs7BPp48dQABw+4g
Date: Tue, 14 Mar 2017 22:07:57 +0000
Message-ID: <2DD56D786E600F45AC6BDE7DA4E8A8C118BA5E01@eusaamb107.ericsson.se>
References: <ABCAA4EF18F17B4FB619EA93DEF7939A4F440D0D@eusaamb107.ericsson.se>
In-Reply-To: <ABCAA4EF18F17B4FB619EA93DEF7939A4F440D0D@eusaamb107.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [147.117.188.11]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsUyuXRPoG628okIg4Ygi2lffrNYXH31mcWB yWPJkp9MHl8uf2YLYIrisklJzcksSy3St0vgyph7+D9LwUXRiuk3DrE0MB4W7GLk5JAQMJHo X/aIvYuRi0NIYD2jxPp1F5hBEkICyxklpryKArHZBIwk2g71gxWJCJxilLjRcIwVJCEs4CvR 3bIbrEFEIEBix5dtULaRREPHcjYQm0VAVaJhzRUWEJsXqP7vhw52iAW+Eo27T4HZnAJ+Ev8n bAOrZxQQk/h+ag0TiM0sIC5x68l8JohLBSSW7DnPDGGLSrx8/I8VwlaS+Ph7PjtEvY7Egt2f 2CBsbYllC18zQ+wVlDg58wnLBEaRWUjGzkLSMgtJyywkLQsYWVYxcpQWF+TkphsZbmIEBv0x CTbHHYx7ez0PMQpwMCrx8BqcPR4hxJpYVlyZe4hRgoNZSYRXI/VEhBBvSmJlVWpRfnxRaU5q 8SFGaQ4WJXHe6yH3w4UE0hNLUrNTUwtSi2CyTBycUg2ME0vKHgnOrN+dpvI0mOV/9Q82B+Yp 2xtvOWcv1hWZn/j/27FzgVWcKee0a9Q89nJfO76JM0nwvktelvqEZ6sWHqjy2SIY1Ovw6QtX t0Lcoc/+pxi5ihlEdeMjEwr+CGcFurG09QXw372dvCRJp4+he96xn92x5W+edO03Xij0tLUw PlPGr06JpTgj0VCLuag4EQBqNluCdgIAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/PGB1m-y2vMqioxPKSSr30b1DLag>
Subject: Re: [Gen-art] Gen-ART Telechat Call review of draft-ietf-ipsecme-rfc7321bis-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Mar 2017 22:08:05 -0000

Hi Meral, 

Thank you for the review and your comments. As submission tool is closed until the next IETF, I have not been able to submit the updated version. This will be done as soon as the IETF starts. Please see inline my response.

Yours, 
Daniel

-----Original Message-----
From: Meral Shirazipour [mailto:meral.shirazipour@ericsson.com] 
Sent: Tuesday, March 14, 2017 4:22 PM
To: draft-ietf-ipsecme-rfc7321bis.all@tools.ietf.org; gen-art@ietf.org
Subject: Gen-ART Telechat Call review of draft-ietf-ipsecme-rfc7321bis-05

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-ipsecme-rfc7321bis-05
Reviewer: Meral Shirazipour
Review Date: 2017-03-14
IETF LC End Date: 2017-03-15
IESG Telechat date: 2017-03-16

Summary: This draft is ready to be published as Standards RFC, but I have some comments.

Major issues:
Minor issues:
Nits/editorial comments:
-[Page 4], "downgraded from MUST to MUST-". MUST- is defined later in the document. Perhaps a reference in the text should point to that section on p.5.

MGLT: 
Here is what I propose: 

OLD text:
"""
Unless there are strong security reasons, an algorithm is expected to be
   downgraded from MUST to MUST- or SHOULD, instead of MUST NOT.
"""

NEW text:
"""
Unless there are strong security reasons, an algorithm is expected to be
downgraded from MUST to MUST- or SHOULD, instead of MUST NOT 
(See Section 2 for a definition of the terminology).

"""

-[Page 7], "were not been mentioned"---->"have not been mentioned"

MGLT: corrected

-[Page 7], "this document clarify"---->"this document clarifies"

MGLT: corrected

-[Page 11], "that revisions of that"---->"that revisions of this"

MGLT: corrected

-general, some acronyms are not spelled out...VPN, MTU..

MGLT: These are the acronyms I found, the following acronyms: UNSPECIFIED.  CPU IKEv2 IANA VPN PFS AEAD 
All have been spelled out except IANA and CPU and UNSPECIFIED.  I added a reference to RFC7296 at the first IKEv2 instance


-Tables P.5,6,8,9,10. Giving them a caption would make the document clearer

MGLT: I added the titles, but the output was pretty ugly (in my opinion) due to the postambules. As titles repeat the section title I preferred to remove the titles and let a note to the RFC editor to do what seems to him the most appropriated way to present the tables.