Re: [Gen-art] Genart last call review of draft-ietf-dnsop-svcb-https-07

Ben Schwartz <bemasc@google.com> Mon, 16 August 2021 21:35 UTC

Return-Path: <bemasc@google.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 93D993A143B for <gen-art@ietfa.amsl.com>; Mon, 16 Aug 2021 14:35:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -18.097
X-Spam-Level:
X-Spam-Status: No, score=-18.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.499, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nUqgrRcGOwgn for <gen-art@ietfa.amsl.com>; Mon, 16 Aug 2021 14:35:33 -0700 (PDT)
Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 180813A1427 for <gen-art@ietf.org>; Mon, 16 Aug 2021 14:35:33 -0700 (PDT)
Received: by mail-wm1-x333.google.com with SMTP id q11-20020a7bce8b0000b02902e6880d0accso434912wmj.0 for <gen-art@ietf.org>; Mon, 16 Aug 2021 14:35:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e8oIJlCjlPuurGLxmBq6d4L00vvq4kdr86roQHnrkRw=; b=OwFNPD5VjHE/NPBRz3MpBxHY9XlqTkoSm9SnckLuh+DG9T4bpc37xVl3oFFwlFEjOC 0S0/9o+2ZcVPM+vIHWNiYH4jpzsk18DNAeZmHUxvXgx0xSnATkcDla1w0wduDX1tN/DO Bzl4nLAuJjzyy5wtMhFS8xtZclJLSSBaVIdpQH4OL8Qgq0JFB5Wo0bHLtSDKLFo2Vyan 8BQ6p8TEahJxj1UB0XvWM85YZvSn2BouQfE2CARofb3DGsf3fVSxZaYlMNgx8oaVTUcF KCBxGPRDax1QpsCO8Dra562l5HGdzEYBSRSKJVV0jV4HRwSufItWHXnD1eVDSTd7Gdbw bbjA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e8oIJlCjlPuurGLxmBq6d4L00vvq4kdr86roQHnrkRw=; b=FHN+tx2trr/u6c+n+szOISC4vxV4Mu8qegx+F76mESqlV1qqvUt44nyfNgLIKIWCGT AtTH5T+9kznPTDCMqor5tSXeOHsuFKKThuoD/S6l8xycdWvKzrsCoJKrvgRdoKMdXhMI yXTn3UMGzX9sipLSIYROj9brB6xwQy1zRPLe6k90eo2eImps8xSLYp2POxzGd79AA/Ro g/CJyjQzcmR2Tm5UCUoKf1Xhs6Ih+Mw5VpfnGjOe9wYDaMmKUoJxKtVOq9KKru7R7OQq xUjUZ6kuBiZBWTQaU4IY1wZBNHQhF8vVAikKGSKBgz9aVR3fLgPesJIZbRBAFCemKR1V 4wrg==
X-Gm-Message-State: AOAM532bUtA7QjWRckZ0QAIqgrYpi0npld+ovDWx9d/5iIEUIUzMy/yQ aPoMzu+LICrzm5gQIj4WNyETjGC80tPkWx/2s+bSUA==
X-Google-Smtp-Source: ABdhPJyuFNLw3tnCK2Ez1ox1svIumFFRan8z7IsduW4tjrUepSTvtOAdzISSHpI7nvHON24PdSnh1hiZnYBdrjcoZX0=
X-Received: by 2002:a05:600c:3581:: with SMTP id p1mr169829wmq.1.1629149726059; Mon, 16 Aug 2021 14:35:26 -0700 (PDT)
MIME-Version: 1.0
References: <162894086429.1046.13202224848938625282@ietfa.amsl.com>
In-Reply-To: <162894086429.1046.13202224848938625282@ietfa.amsl.com>
From: Ben Schwartz <bemasc@google.com>
Date: Mon, 16 Aug 2021 17:35:14 -0400
Message-ID: <CAHbrMsBJN-+fyGn__HwNZC5q5SG4Xfca1pR=ipkUQd0u7R5QpA@mail.gmail.com>
To: Dale Worley <worley@ariadne.com>
Cc: gen-art@ietf.org, dnsop <dnsop@ietf.org>, draft-ietf-dnsop-svcb-https.all@ietf.org
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg="sha-256"; boundary="000000000000bdaaa305c9b3fa47"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/R6XCCoHIcXSd-f2mu4uKDoioLMA>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-dnsop-svcb-https-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Aug 2021 21:35:51 -0000

-last-call

Thanks for the detailed review, Dale.  I've posted a proposed change to
incorporate most of your comments:
https://github.com/MikeBishop/dns-alt-svc/pull/335

On Sat, Aug 14, 2021 at 7:34 AM Dale Worley via Datatracker <
noreply@ietf.org> wrote:

> Technical issues:
>
> Whereas SRV records have both a priority and weight field, SVCB
> records have only a priority field.  (This point is not addressed in
> section C.1.)


I've proposed some text on that point for section C.1, but I don't think we
need a Weight field.  As you noted, it doesn't seem to have been widely
used within SRV.

In SVCB, weighted load balancing can be added in the future as a SvcParam
if there is demand, so it seemed wise to exclude it from the base
specification for simplicity.


>
> 2.2.  RDATA wire format
>
>    When the list of SvcParams is non-empty (ServiceMode)
>
> Actually, an AliasMode record can have a non-empty SvcParams, it
> simply SHOULD NOT.  The subtle case is whether an AliasMode record
> with non-empty SvcParams is governed by this section (which requires
> the SvcParams to be properly formatted and "If any RRs are malformed,
> the client MUST reject the entire RRSet") or by section 2.4.2 ("In
> AliasMode, ...  recipients MUST ignore any SvcParams that are
> present.")  I recommend stiffening the requirement so that AliasMode
> records MUST NOT have SvcParams (and having the zone file processor
> enforce it).
>

I've removed the confusing parenthetical, but otherwise I would prefer not
to change the normative requirements here.  While we don't have any clear
use case or semantics for AliasMode SvcParams, I think it's conceivable
that we could discover some in the future, and it might help if current
implementations just ignore them.


>
> 8.1.  Query names for HTTPS RRs
>
>    Reusing the service name also allows ...
>
> I assume this means "Using one record for both HTTP and HTTPS allows ..."
>

No this is about using the same QNAME for HTTPS that we currently use for A
and AAAA.  Clarified.


>
> D.2.  ServiceForm
>
> Is this "ServiceMode"?
>

Yes, fixed.


> This section uses "vector" in three places where "form" or "example"
> would likely be better.
>

"Test vector" is a standard phrase in this context, e.g.
https://datatracker.ietf.org/doc/html/rfc6716#appendix-A.4