Re: [Gen-art] Genart last call review of draft-ietf-stir-passport-shaken-04

Alissa Cooper <alissa@cooperw.in> Tue, 20 November 2018 21:25 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E9D7E124D68; Tue, 20 Nov 2018 13:25:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=tQ0Zre5L; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=disk8D21
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RsdQAcxhVcDD; Tue, 20 Nov 2018 13:25:39 -0800 (PST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E693130DCF; Tue, 20 Nov 2018 13:25:38 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 36D08221AD; Tue, 20 Nov 2018 16:25:37 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 20 Nov 2018 16:25:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm1; bh=d q2W6fN5QcRY2OPpbosT/rUUHVNKL2+T52pGTS/J6kc=; b=tQ0Zre5LMrffXQ7/Y Hbt/Ce4lLTWa3pZLJ/QrVAh1IAIDqRNwAdauPzlBoWJMB/qnozYuXs8G0Vo+CdGz alumWDzwOKDOo/vcgr+X6xr1NaN4SvUXvFq298GBaXKXxM3ieAV6X7sNZcfwR41R j43inoLZ42m6lFjL97I3eetEAJ8v8268HcqAdsJPKog2qD8EGU8GK/txEax+prve hqNbIIK1lQIkP2NyGEJQBir+xridX/NM9dAm5D+Nq+b+/pQG39tsx0WIUZC0zvmy +KZJjQhc4Y8yfhBr8oZ7xBbIrMD5IIQiR+oXNeuweG9AFjEPSrTfZs1RcK/qw/Di WJrIA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=dq2W6fN5QcRY2OPpbosT/rUUHVNKL2+T52pGTS/J6 kc=; b=disk8D212Ep7DPAYOA4fuRFVDncR8NgLSmgGYS7bPeT95vyGsWoPBLS9c WowQ07PQmPvHJN6c2dqnxJXtjmcumBqQBY26FjVO23r8grM2+U1aY25bqgaQxT4i KBmHuy+FN0H5E8AYMfjP+rILjogch8qJZmAydHT1aKEtZUhk8twWpqNuE8r+iqNn CUxDWuNdFl5KI0DD48rvKeGAtsWnIbr3NhN6t12bt1dndJAyhu48Wz3x5WQQYy/E 9tr8uvpOCM6PMS3LBHNGVScZRUsdX1vckD5pPYy+iwFTFgRr1Ep4HVB73Bmg92os wXFDz2TbFESmF5jF4fXu/4s8Lb+FA==
X-ME-Sender: <xms:0Hv0W3zRK05T5P8ha0n_UWUDNUpyZP5geQW_alHZFv8-tPB84bYaSg>
X-ME-Proxy: <xmx:0Hv0Wyhr7khuEjfiVHUZzlgZxpwsPUjdOQdOVxn6CaGzUJ1_qHl4Tg> <xmx:0Hv0W2PtfNf3MvtPBzOp9sXYWTcv-CBti5LA70knb9ho7XbsTrYBLg> <xmx:0Hv0Ww4b6ScA6G4cZtzHBJDPnGcgWv1jr_qkSnlVsX_CqqAExfX2Zg> <xmx:0Hv0WwU2CB-stj5rT59qBmy8-virmdbZGWSbjiKNJtYbCoJSKXkDmw> <xmx:0Hv0WyEuc-kLgLLMo89i5YMfqYRMk0ntBRERWaYdyiE18ytDKkuSNg> <xmx:0Xv0W7A5Vo9putFMYplZZYgw0xrUALStmH9qnmRa-yKEeG_1D5LeYA>
Received: from rtp-alcoop-nitro5.cisco.com (unknown [173.38.117.92]) by mail.messagingengine.com (Postfix) with ESMTPA id 561EB10311; Tue, 20 Nov 2018 16:25:36 -0500 (EST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <154117528787.7013.6199833371829068074@ietfa.amsl.com>
Date: Tue, 20 Nov 2018 16:25:35 -0500
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-stir-passport-shaken.all@ietf.org, stir@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <158B9954-2651-47F4-97FE-5BF82DA7D21E@cooperw.in>
References: <154117528787.7013.6199833371829068074@ietfa.amsl.com>
To: Francesca Palombini <francesca.palombini@ericsson.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/SJbYvhu0oUKyx-1xG9Th0zJTHV0>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-stir-passport-shaken-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 21:25:42 -0000

Francesca, thanks for your review. All, thanks for addressing Francesca’s comments. I entered a No Objection ballot but I think there is more to say about the privacy implications of origids — to be discussed in the thread about Eric’s ballot.

Thanks,
Alissa

> On Nov 2, 2018, at 12:14 PM, Francesca Palombini <francesca.palombini@ericsson.com>; wrote:
> 
> Reviewer: Francesca Palombini
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>;.
> 
> Document: draft-ietf-stir-passport-shaken-04
> Reviewer: Francesca Palombini
> Review Date: 2018-11-02
> IETF LC End Date: 2018-11-02
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: This draft is on the right track but has open issues, described in the
> review.
> 
> Major issues:
> 
> * This draft defines the new claim "origid" for the Personal Attestation Token
> used in the SHAKEN framework, but does not give any privacy considerations
> about it and its use. [RFC6973] suggests that the privacy considerations of
> IETF protocols be documented. As required by [RFC7258], work on IETF protocols
> needs to consider the effects of pervasive monitoring and mitigate them when
> possible. I don't know SHAKEN well enough to comment on privacy issues on that,
> but this draft, as part of the IETF work, should have privacy considerations,
> particularly considering the "origid" claim.
> 
> Minor issues:
> 
> * Section 4: the term "verified association" is not defined in this document,
> nor in [RFC8225], nor in the SHAKEN spec referenced. Is there a way to clarify
> what is meant by it? It could be a reference.
> 
> Nits/editorial comments:
> 
> * Terminology: I would have appreciated a short sentence mentioning [RFC8225]
> in the Terminology section.
> 
> * Section 9: [RFC8224] appears without link.
> 
> * Acknowledgements: "The authors would like
>   acknowledge the work of the ATIS/SIP Forum IP-NNI Task Force to
>   develop the concepts behind this document." -> The authors would like to
>   acknowledge ...
> 
> I do not repeat nits and editorials reported by Adam Roach in his review of
> this version of the document (11-19-2018,
> https://mailarchive.ietf.org/arch/msg/stir/HxVSCLPGfSgwFuvqLkWSVNI0PtQ )
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art