[Gen-art] Gen-art review of draft-ietf-idr-rfc3392bis-02.txt

I have been selected as the General Area Review Team (Gen-ART)
reviewer for this draft (for background on Gen-ART, please see
_http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html_).

Please resolve these comments along with any other Last Call comments
you may receive.

Document: draft-ietf-idr-rfc3392bis-02.txt
Reviewer: Elwyn Davies
Review Date: 12 December 2008
IETF LC End Date: 25/12/2008
IESG Telechat date: (if known) -

Summary:
The document is almost ready for the IESG.  However after diligent 
searching both in the RFCs and on the IANA web site, I believe that 
neither the original BGP RFCs 1771/4671, RFC 3392 nor this draft define 
a registry for the parameter types in OPEN messages.  The CAPABILITY 
parameter is said to be 'Type 2'.  I presume this means the value of 
Parameter Type in the sense of s4.2 of RFC 4671. BTW: Is there a  'Type 
0' or 'Type 1'?

There is also one minor nit and a clarification which would help.

Comments:
IANA Considerations:  There does not appear to be a registry for OPEN 
message (optional) parameter types!

s4: I think it would be helpful to naive readers to make it clear that 
the capability (sub-)TLVs all go 'inside' the overall  CAPABILITY 
parameter TLV in the OPEN message, and the overall length in the 
Parameter TLV covers the whole set of capability options (and in turn 
the total length of all the optional parameters....  you could run out 
of space just counting the counters ;-) )

s4: The encodings of the Capability Type and Length fields are not 
specified.

_______________________________________________
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art