[Gen-art] Gen-art review: draft-ietf-secsh-break-04
Elwyn Davies <elwynd@dial.pipex.com> Tue, 30 August 2005 14:28 UTC
Received: from localhost.localdomain ([127.0.0.1] helo=megatron.ietf.org) by megatron.ietf.org with esmtp (Exim 4.32) id 1EA764-0004Wf-Ju; Tue, 30 Aug 2005 10:28:20 -0400
Received: from odin.ietf.org ([132.151.1.176] helo=ietf.org) by megatron.ietf.org with esmtp (Exim 4.32) id 1EA762-0004Vp-DE for gen-art@megatron.ietf.org; Tue, 30 Aug 2005 10:28:18 -0400
Received: from ietf-mx.ietf.org (ietf-mx [132.151.6.1]) by ietf.org (8.9.1a/8.9.1a) with ESMTP id KAA16194 for <gen-art@ietf.org>; Tue, 30 Aug 2005 10:28:16 -0400 (EDT)
Received: from b.painless.aaisp.net.uk ([81.187.81.52] helo=smtp.aaisp.net.uk) by ietf-mx.ietf.org with esmtp (Exim 4.43) id 1EA77U-0002lX-Uh for gen-art@ietf.org; Tue, 30 Aug 2005 10:29:55 -0400
Received: from [81.187.254.247] (helo=[127.0.0.1]) by smtp.aaisp.net.uk with esmtps (TLSv1:AES256-SHA:256) (Exim 4.43) id 1EA75U-0001QY-Ap; Tue, 30 Aug 2005 15:27:44 +0100
Message-ID: <43146D31.8060303@dial.pipex.com>
Date: Tue, 30 Aug 2005 15:29:05 +0100
From: Elwyn Davies <elwynd@dial.pipex.com>
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: gen-art@ietf.org
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Scan-Signature: 7baded97d9887f7a0c7e8a33c2e3ea1b
Content-Transfer-Encoding: 7bit
Cc: galb-list@vandyke.com, Sam Hartman <hartmans-ietf@mit.edu>, remaker@cisco.com
Subject: [Gen-art] Gen-art review: draft-ietf-secsh-break-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www1.ietf.org/pipermail/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www1.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
Sender: gen-art-bounces@ietf.org
Errors-To: gen-art-bounces@ietf.org
Background for those on the CC list, who may be unaware of GenART: GenART is the Area Review Team for the General Area of the IETF. We advise the General Area Director (i.e. the IETF/IESG chair) by providing more in depth reviews than he could do himself of documents that come up for final decision in IESG telechat. I was selected as the GenART member to review this document. Below is my review, which was written specifically with an eye to the GenART process, but since I believe that it will be useful to have these comments more widely distributed, others outside the GenART group are being copied. Document: draft-ietf-secsh-break-04.txt Intended Status: Proposed Standard Shepherding AD: Sam Hartman Review Trigger: IESG Telechat 1/9/05 Review: This document is almost ready for publication as a proposed standard but it has one possible (minor) issue and a couple of editorial nits. Possible issue: [I say 'possible' because I am not an ssh expert but there is an apparent inconsistency with other ssh documents which makes me wonder]. s2: para 4: The text says 'If the BREAK-length parameter is 0 *or not present*, the BREAK SHOULD be interpreted...'. As far as I can see no other ssh message has optional parameters in this way. Although it would obviously be possible to cope with both cases, it seems to be unusual and makes parsing the message more complex than it needs to be, given that this message is going to be a relative rarity. Was this intended? If so I think it would be desirable to add an explicit note closer to the message definition to point out that the parameter is optional. Otherwise just delete 'or not present'. Editorial: s1: para 1: Add a reference to the SSH Connection protocol [5] after 'session channel'. s3: Choose between 'break-length' (as in message format) and 'BREAK-length' (as in para 4). s3: next to last para: (2 places) s/preformed/performed/ _______________________________________________ Gen-art mailing list Gen-art@ietf.org https://www1.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Gen-art review: draft-ietf-secsh-break-… Elwyn Davies