Re: [Gen-art] (full) review of draft-ietf-lisp-rfc6830bis
Alissa Cooper <alissa@cooperw.in> Thu, 27 September 2018 13:15 UTC
Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0B767130E86; Thu, 27 Sep 2018 06:15:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=cuZy/+Bx; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=SkLROd7f
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FlrD38dJRIoS; Thu, 27 Sep 2018 06:15:08 -0700 (PDT)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 57959130E85; Thu, 27 Sep 2018 06:15:08 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B901621CA5; Thu, 27 Sep 2018 09:15:06 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 27 Sep 2018 09:15:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=c2HyoXbOnxGyjqw564FH3VUIb8H9usKn3ShM6BaI8A0=; b=cuZy/+Bx +5VmgMahuiMTFtpZY2tTX+V2i4Oh8Drs3VG2V4PXby7VajqHUowcIt/NQ0Pub7e6 mA3mNlommoVsO5cONjzppdM7m9SkQ/L8lL/7duvSc8fJA7dxNWe+sCNUd/bbI5OD nw6GTk//sqjWFz0Muvbx9PyE8XPS5FX7BI1uWIoD0OpEUAuH7L+KHjhaXer/5FQt 8fZnPej3qipLltu1AqujuHPomw3IHreUhpIE7G9R95/1rIsjstdSRVfFfBPPVUNF bi2wJAPVkAXczE3AxAfseTa6N843Ve23v0iPrGT2C7uWcvisgAyuQy33unkz/Ju4 X8IZBNHWIs9s+A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=c2HyoXbOnxGyjqw564FH3VUIb8H9u sKn3ShM6BaI8A0=; b=SkLROd7fYtVu6SDgrTAjlvSjSRBg3/qhXRb7WqEq02ich WzWCJ/Y1LVg2Qa1fOBljiV7Cxv4JeWR/JhYs6xSwr74novTCpIFmJ4KrbWJWfPGa m94JNV/Zh6DTFMU4AqMdx4nXiN3qWGxwQMP4S5At5fzabQoAPYYaNdJ2qEcVPkSg rkXlGfwaPCwbUDwEYiGBab2GOPmWrdVgs1zPmgpGBaQGVUMeY2oV5wN25DSSQVKp vHPa1ocYemLS7E++BDKb1/pmhiTeUEd8HhmhZQ9W4UdPY+AEGBDM8/eO23VXPo/Y zyaMwGpeal0HJFDJ/klEEp6LhvJvom5MuYIuw0j3w==
X-ME-Proxy: <xmx:2tesW7xxD4jJMil2COvWeD-En3div2c1fXzSE6frrNzTtrW3r2p3wQ> <xmx:2tesWzvNJM9F5dZUPDTXhFlONFKuDOegk1nmzlRIJ5fVvW_TJlDtbw> <xmx:2tesW2z61EtuXZv2V9PGTuSaPCXyLR_uTMBEFCs8DYSPRy3whVhqzg> <xmx:2tesW1jP5lLF0RgiZ4tjQvzANHHy4um_mqcITVU3_9IHlsSxYHfOeg> <xmx:2tesW8bEPimPNspG8Ado31a0aDI2ASzNY7_SZ3YQYmpwGKu5qORkCQ> <xmx:2tesW8DrYNMurlD_zofgk1vXVRtL-i4xrWAMHmhCN-L7Vd4m4UE1mQ>
X-ME-Sender: <xms:2tesW1hTQozNwRVjz9mMrNGDKawT7BoaULAHnNeHCDzOyNNT6dJbCA>
Received: from [10.71.5.33] (unknown [8.25.222.2]) by mail.messagingengine.com (Postfix) with ESMTPA id 3337CE40A2; Thu, 27 Sep 2018 09:15:05 -0400 (EDT)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <57291F2E-C628-4087-BEC9-D023D6ACD544@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_19AE807E-1618-4899-BB22-EDBF6D2C890E"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Thu, 27 Sep 2018 06:15:18 -0700
In-Reply-To: <2C6AAC15-E92F-4CAB-9AA9-DD6BAFA43DC6@gmail.com>
Cc: draft-ietf-lisp-rfc6830bis.all@ietf.org, General Area Review Team <gen-art@ietf.org>
To: Dino Farinacci <farinacci@gmail.com>, Francis Dupont <Francis.Dupont@fdupont.fr>
References: <201809171624.w8HGOdQC005035@givry.fdupont.fr> <2C6AAC15-E92F-4CAB-9AA9-DD6BAFA43DC6@gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Wo-4uXRbrpC2CU78AGYnOBo05yM>
Subject: Re: [Gen-art] (full) review of draft-ietf-lisp-rfc6830bis
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2018 13:15:11 -0000
Francis, thanks for your review. Dino, thanks for your responses. I have entered a No Objection ballot. Alissa > On Sep 17, 2018, at 10:26 AM, Dino Farinacci <farinacci@gmail.com> wrote: > >> This completes the review I sent last week. >> >> I am the assigned Gen-ART reviewer for this draft. The General Area >> Review Team (Gen-ART) reviews all IETF documents being processed >> by the IESG for the IETF Chair. Please wait for direction from your >> document shepherd or AD before posting a new version of the draft. >> >> For more information, please see the FAQ at >> >> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. >> >> Document: draft-ietf-lisp-rfc6830bis-17.txt >> Reviewer: Francis Dupont >> Review Date: 20180911 >> IESG Telechat date: 20180927 > > Thanks for your review Francis. A new diff file for 6830bis in enclosed at the end. > >> Summary: Ready with Nits >> >> Major issues: None >> >> Minor issues: None >> >> Nits/editorial comments: >> - 3 pages 4-8: some abbrevs are used before being defined *. I don't know >> a good way to fix this and anyway there are only a few specific terms >> so IMHO it is not a real problem. >> * e.g. ETR is used the entry before its definition. > > This was brought up in the RFC6830 review back in 2012. And it was decided by everyone involved at the time to not change anything. > >> - 5.1 page 16: the I bit text is not very clear IMHO both because >> the Instance ID is not defined before section 8 and because L and I >> bits interfere. As the problem comes from RFC 6830 I propose to keep >> the current text. > > Kept. > >> >> - 10.1 pages 26 and 27: the order between nonce word and derivations >> from echo is not very consistent. If you have another reason to revisit >> the section please fix this very minor issue. >> >> - B.3 page 40: implementators -> implementors >> >> - 8.12 page 42: addreses -> addresses > > Both occurrences fixed. > >> - B.13 page 43: Reencapsulating -> Re-encapsulating >> (BTW these spelling errors are in text which should be dropped :-) > > Right, fixed anyways. > >> - as it is a RFC revision perhaps it should be fine to add some words >> about real world deployments of LISP? > > We have an entire deployment draft about this. And we had deployment information in RFC6830 and during the IESG rewview, it was asked to be removed. > > Dino > >> >> Regards >> >> Francis.Dupont@fdupont.fr <mailto:Francis.Dupont@fdupont.fr> > > <rfcdiff-6830bis.html> > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org <mailto:Gen-art@ietf.org> > https://www.ietf.org/mailman/listinfo/gen-art <https://www.ietf.org/mailman/listinfo/gen-art>
- [Gen-art] (full) review of draft-ietf-lisp-rfc683… Francis Dupont
- Re: [Gen-art] (full) review of draft-ietf-lisp-rf… Dino Farinacci
- Re: [Gen-art] (full) review of draft-ietf-lisp-rf… Alissa Cooper