IETF Logo Mail Archive

Re: [Gen-art] (full) review of draft-ietf-lisp-rfc6830bis

Dino Farinacci <farinacci@gmail.com> Mon, 17 September 2018 17:26 UTC

Return-Path: <farinacci@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C678130E5E; Mon, 17 Sep 2018 10:26:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.403
X-Spam-Level:
X-Spam-Status: No, score=0.403 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_COMMENT_SAVED_URL=1.391, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AERIkarZ7BGh; Mon, 17 Sep 2018 10:26:47 -0700 (PDT)
Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A45941200D7; Mon, 17 Sep 2018 10:26:46 -0700 (PDT)
Received: by mail-pg1-x544.google.com with SMTP id b129-v6so7975971pga.13; Mon, 17 Sep 2018 10:26:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=p0O5XG5CYzBNu8+oMD3epWN00WBu+Eig+9St+3uzF3Q=; b=PwCU+PKFGVsJhtcgCbmjKHzXJnxSLiz98p30N6hTKeOyn/HuOecuD4k+nJQz5WMSrB lggVoWvuFuQGbvvX7S+w3Y7wQI3sjHbXdlwXTh2xC9UDz5UK1f2cZmkCKqPwss39hN5F bMxLUhKmA2zymmZwaHs387jKpqyvvPUPl1UZlS7oV5LSWs0bK2IVC/Rurmbol4D/jDjG M+DBo4NO/E8cO5kvac5cMvnWw7Gka+BYeQxSHwg0z+VgmG9R44eq0YP74uBw9u3jlTGp rJzgdpkTvRI8M8h5+yF0P6TkRWxeWwKMCQ8qfw5I1mNKo6p8DU7muJ84aarZtS/H+UBy lktQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=p0O5XG5CYzBNu8+oMD3epWN00WBu+Eig+9St+3uzF3Q=; b=FcGX9XBqEJmXI3/FAe2rkQ3oAAX3xcyYnzl9DjB8r4zIPbQNFLK75eWyy0zDBDBr+g wNzZCugfAbT2yxy09jPFKQ0Nh4xwY1mMJT+tYBPHklEqjxyEl6HvYiUoH8rBVn4lOuGL nqVskllfHcrnBJ2DW3L/8qFA82k9wBNAb/GiBKXPpOzDNInBAu1b8I/kTbODraSk+5tH /vnprnk9mBOuufER1ooQomEoMQvlqNSy/rZ8bKpvqYUKlvSuOWgzl0sL2DIgS8FKmM+K ImPRbOCbhWXfkvuVRYKg7k7XO8p3RQHjXNBK4gDT/T43a+NB5w19ivkNo/KuLXH+P2v8 bD6w==
X-Gm-Message-State: APzg51Dr4dV6j2osScZr5H4vVntLijUwDge3EkM1y6q7xRxywMtirEIi 8WKtoxwAmCC0bBe7s+8ZgIQ=
X-Google-Smtp-Source: ANB0VdZMLxmlVWScjsX4+eFehQsjzbwdPerSFyccAAFFwywI27y0PQshfmq3FO8OATAqgL/tllALug==
X-Received: by 2002:a63:cf52:: with SMTP id b18-v6mr23909772pgj.194.1537205206179; Mon, 17 Sep 2018 10:26:46 -0700 (PDT)
Received: from [10.10.10.70] ([4.28.87.67]) by smtp.gmail.com with ESMTPSA id e73-v6sm29135117pfb.153.2018.09.17.10.26.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Sep 2018 10:26:45 -0700 (PDT)
From: Dino Farinacci <farinacci@gmail.com>
Message-Id: <2C6AAC15-E92F-4CAB-9AA9-DD6BAFA43DC6@gmail.com>
Content-Type: multipart/mixed; boundary="Apple-Mail=_8E0B43A0-5455-4E8B-9DBC-8D40E4B6C2D4"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Mon, 17 Sep 2018 10:26:44 -0700
In-Reply-To: <201809171624.w8HGOdQC005035@givry.fdupont.fr>
Cc: gen-art@ietf.org, draft-ietf-lisp-rfc6830bis.all@ietf.org
To: Francis Dupont <Francis.Dupont@fdupont.fr>
References: <201809171624.w8HGOdQC005035@givry.fdupont.fr>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/GTSAgx23T9KvPh1PolaCno3Zo2c>
Subject: Re: [Gen-art] (full) review of draft-ietf-lisp-rfc6830bis
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 17:26:52 -0000

> This completes the review I sent last week.
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-lisp-rfc6830bis-17.txt
> Reviewer: Francis Dupont
> Review Date: 20180911
> IESG Telechat date: 20180927

Thanks for your review Francis. A new diff file for 6830bis in enclosed at the end.

> Summary: Ready with Nits
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
> - 3 pages 4-8: some abbrevs are used before being defined *. I don't know
>  a good way to fix this and anyway there are only a few  specific terms
>  so IMHO it is not a real problem.
>  * e.g. ETR is used the entry before its definition.

This was brought up in the RFC6830 review back in 2012. And it was decided by everyone involved at the time to not change anything.

> - 5.1 page 16: the I bit text is not very clear IMHO both because
>  the Instance ID is not defined before section 8 and because L and I
>  bits interfere. As the problem comes from RFC 6830 I propose to keep
>  the current text.

Kept.

> 
> - 10.1 pages 26 and 27: the order between nonce word and derivations
>  from echo is not very consistent. If you have another reason to revisit
>  the section please fix this very minor issue.
> 
> - B.3 page 40: implementators -> implementors
> 
> - 8.12 page 42: addreses -> addresses

Both occurrences fixed.

> - B.13 page 43: Reencapsulating -> Re-encapsulating
>  (BTW these spelling errors are in text which should be dropped :-)

Right, fixed anyways.

> - as it is a RFC revision perhaps it should be fine to add some words
>  about real world deployments of LISP?

We have an entire deployment draft about this. And we had deployment information in RFC6830 and during the IESG rewview, it was asked to be removed.

Dino

> 
> Regards
> 
> Francis.Dupont@fdupont.fr

v2.23.0 | Report a Bug | By Email