Re: [Gen-art] Genart last call review of draft-ietf-tsvwg-rlc-fec-scheme-07

Vincent Roca <vincent.roca@inria.fr> Wed, 19 September 2018 11:01 UTC

Return-Path: <vincent.roca@inria.fr>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A7753130FF6; Wed, 19 Sep 2018 04:01:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.9
X-Spam-Level:
X-Spam-Status: No, score=-6.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ObqkTJ4Dz0BW; Wed, 19 Sep 2018 04:01:11 -0700 (PDT)
Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2E92D131008; Wed, 19 Sep 2018 04:01:09 -0700 (PDT)
X-IronPort-AV: E=Sophos;i="5.53,393,1531778400"; d="scan'208";a="279382809"
Received: from demeter.inrialpes.fr ([194.199.28.3]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2018 13:01:07 +0200
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Vincent Roca <vincent.roca@inria.fr>
In-Reply-To: <153696195894.17616.15063590534202634959@ietfa.amsl.com>
Date: Wed, 19 Sep 2018 13:01:07 +0200
Cc: Vincent Roca <vincent.roca@inria.fr>, gen-art@ietf.org, ietf@ietf.org, draft-ietf-tsvwg-rlc-fec-scheme.all@ietf.org, tsvwg@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <E93DFC91-03E0-4E36-87AD-DE68A808452F@inria.fr>
References: <153696195894.17616.15063590534202634959@ietfa.amsl.com>
To: Russ Housley <housley@vigilsec.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Ej6GUu4-m3aT8CR8203Hb0n8U1A>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-tsvwg-rlc-fec-scheme-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Sep 2018 11:01:23 -0000

Hello Russ,

Thanks a lot for this review.

> Le 14 sept. 2018 à 23:52, Russ Housley <housley@vigilsec.com> a écrit :
> 
> Reviewer: Russ Housley
> Review result: Almost Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-tsvwg-rlc-fec-scheme-07
> Reviewer: Russ Housley
> Review Date: 2018-09-14
> IETF LC End Date: 2018-09-24
> IESG Telechat date: unknown
> 
> Summary: Almost Ready
> 
> 
> Major Concerns:
> 
> None.
> 
> 
> Minor Concerns:
> 
> Section 2: Please update the first paragraph to reference RFC 8174
> in addition to RFC 2119, as follows: 
> 
>   The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
>   "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and
>   "OPTIONAL" in this document are to be interpreted as described in BCP
>   14 [RFC2119] [RFC8174] when, and only when, they appear in all
>   capitals, as shown here.

I was not aware of RFC 8174. Done.
I will updated to companion I-D (draft-ietf-tsvwg-fecframe-ext) in a similar way.


> Section 2: Please add the definition of ^^.

Done.

NEW:
   a^^b     a to the power of b

> Section 12.1: Please add a normative reference to RFC 8174.

Of course.

> 
> The code in Appendix A will not compile using gcc unless you add:
> 
> 	#include <stdint.h>

Done.

Regards,

  Vincent and Belkacem