Re: [Gen-art] Genart last call review of draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04

Christer Holmberg <christer.holmberg@ericsson.com> Wed, 01 September 2021 09:16 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E16583A13EC; Wed, 1 Sep 2021 02:16:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.552
X-Spam-Level:
X-Spam-Status: No, score=-2.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.452, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iXg7FcoyFoDj; Wed, 1 Sep 2021 02:16:39 -0700 (PDT)
Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10069.outbound.protection.outlook.com [40.107.1.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5D4A33A13E9; Wed, 1 Sep 2021 02:16:35 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J+Rr5F5Ci358/OgYp8h14WGrQM3L3tJDtoxlLv8JyoyLpAiC7GcKH+Nq9gc7IyyvliQzw9EejZgSYqb0jCZ71nJqHY77/x+VLL2w1effo9067LBjSJpvxYmQwambR1Bx+jPBFhXDxcR7b27hptDUE7G+SnYhi1nmlLJHmmCasEb3RG7sbWseKtIxsHX+OlU4HK87b1oQ93GwboRlN2/OxQHX1ogF2QapWZnpAkSgJYnutNGMAHV67VjFP79ny/DHN6scZDqflhBdY6fiC/53uU85fAYYsDpHPBPy/f/zdgVmbM0woRioaNLnLR+0mZr6I58PFCyD24BRgC0hb4qJFQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=beg/e84lCdeq7/+htg6ZiMb3BuQJFUKs7OcP4PVezw8=; b=MOY+5gkmsRP8cWDTZ99CWvI8zunCLpxhs/Sze9hcjj17vgXdUYshlfxc9iusC4hp2+1P4cI/0VMSC7/OiMY8iXvYOUEYmhEup+2B5R9DGFMl94d49UXDh0mxZPSg+FpGA1BWvOMxiBGYV0cZhdGWset5fys5x5ZqK9IVzIM4MlaM7LsgScp7oSDbOHX31g3qYU2mHjsOhADCONG1Trgdj3sLlU8QMhwp7m6CFgV5SYByDb42HdQybI2GSwOO8/Z47iAWF/v6zJ+6qYOepvx+vcEbLoA3/0Y0ojBSQTG4BxH8xiO5Qgy3XkG/+gDqhA/uAVp1rywzbW5A065UoeU52A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=beg/e84lCdeq7/+htg6ZiMb3BuQJFUKs7OcP4PVezw8=; b=aa+YnIgAJzP1IOSzKfa6RYx4+PpJfAsguw32+a9K2/z85A3kk9wrnlF9xcnM7un/WR9vuV9BJP2dqvNc533GpFXvCTfs0P7WTM4LZZl682Ot73gy+gy8uLbZXfcvKwQhgBEia9Vz/OcuDy70hA8Nniz8oYM9veDZ/Cz/8KmWULI=
Received: from HE1PR07MB4441.eurprd07.prod.outlook.com (2603:10a6:7:9f::27) by HE1PR07MB3099.eurprd07.prod.outlook.com (2603:10a6:7:39::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.16; Wed, 1 Sep 2021 09:16:32 +0000
Received: from HE1PR07MB4441.eurprd07.prod.outlook.com ([fe80::49b7:5cc:5aeb:fb2a]) by HE1PR07MB4441.eurprd07.prod.outlook.com ([fe80::49b7:5cc:5aeb:fb2a%4]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 09:16:32 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "Nagendra Kumar Nainar (naikumar)" <naikumar@cisco.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-mpls-lsp-ping-ospfv3-codepoint.all@ietf.org" <draft-ietf-mpls-lsp-ping-ospfv3-codepoint.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04
Thread-Index: AQHXXpec1zu04rbx2U+Ck8sb/ET/a6uOjmxPgADYOyA=
Date: Wed, 1 Sep 2021 09:16:32 +0000
Message-ID: <HE1PR07MB4441B874BCE8E1E726F982FC93CD9@HE1PR07MB4441.eurprd07.prod.outlook.com>
References: <162339832253.24163.8210945265296547396@ietfa.amsl.com> <BL3PR11MB57323916C0DCD4511B9B8D35C6CC9@BL3PR11MB5732.namprd11.prod.outlook.com>
In-Reply-To: <BL3PR11MB57323916C0DCD4511B9B8D35C6CC9@BL3PR11MB5732.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: cisco.com; dkim=none (message not signed) header.d=none;cisco.com; dmarc=none action=none header.from=ericsson.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 08840fcd-4391-4cf7-c569-08d96d29306b
x-ms-traffictypediagnostic: HE1PR07MB3099:
x-microsoft-antispam-prvs: <HE1PR07MB3099C7175AA60D429831F54693CD9@HE1PR07MB3099.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: kz9uQ40GJq8pFVaoUbJr+TmpyTFqJ2lN125SLJ9clsDPrbBmrsMVKvvBboK555ToWy+GHTdhzP62183T43YywOD3ZQUrahgwNYLSW3hIMA2q8Z3PlPwyfVZpC1oiEw5zhT4kulg9u2MZzwI37q/t3ziOu25Ttn5KuT2QuhBdI6xjH8t6MkCk+eyTRzeFpLeVKjlvA1rXW/wUDGs0+KgbvVDliQg9MkWC+W20q7BybxhBdMAIiild88AkKsbHbXwxZP1j5HyIijD/1D6eaUhw/9/xIyF027jlKq/7gOxgmIWfVeD7YSsztClV3PIkMaONhZnWQrBRgr9gYkQbzE560Yq3T2PSB88+v6N2r1IvYWWh99hhGo7p5mT1Tc+KSEG1A5a3tS3jgwuIJHob/7WQKvCPi2+KC5Q9wTnwXAsxvQY96rKhPmrVz/jOzHJUyG/TFLswbpq7CPOWpU8Ix3wjDZjamc9gRQTBEySEE2pBgbWKfLfto2ev7+xyrtby72ozH9uEoa0o8fHIj/QCSt3+gv3nUsiotAtvh1XGbsm2/YAfUrPxXBH10VMsqjkwgDQzlergjmk2y2ieE1m9dtCkMZZEL4GKNddQszNrSIB3VODkhI8HNNu4babOlgIqT5gn2w+P4lbMLXAwQVRfB1QAbukkcTs+iGWS6uocvYvpVzaKa/50w1TOFJ8LY5QQnnh+aMVKy6UTCv3Dfzw9PT3GJem0W52HQ6CbiFy0WUiONPk921EW2MeCl7GidebhHc5j/IIjg5pc6uSTSQ1RtX93bwvpuIr/xVqyuNS/WqYtFKo=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR07MB4441.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(346002)(39860400002)(136003)(396003)(6506007)(53546011)(166002)(44832011)(33656002)(186003)(54906003)(52536014)(66476007)(316002)(110136005)(2906002)(8936002)(9686003)(26005)(8676002)(55016002)(76116006)(38070700005)(66446008)(122000001)(86362001)(64756008)(66556008)(71200400001)(38100700002)(4326008)(7696005)(5660300002)(478600001)(83380400001)(66946007); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+s61wdGhza1780EIvUJ8dpV6agR4uy7Yw6PYZNLCT6iE/t/gyXikTIB4mZz3?= =?us-ascii?Q?8exB7hN4dHcaLKXCfvyYxn/3dV/ZDJPA0ZlcIsYcZSZ4ZvNklCIDvBE50fUR?= =?us-ascii?Q?3Jg6OugvwxEXFYHUou7rotM7pxvBDAJFi9rAUorMbO0WmRopnDDxVS4fiyuP?= =?us-ascii?Q?2jjbJdkuqufGOuWWo2SEds3rDJRygjdRWYrOPWNjJ6j8QDzjpNZ22QKF+PIF?= =?us-ascii?Q?Gv2IRfLxUIM626Zy8UwjLVRB6c2mu2SpBFfE0oKYN5OCSd4f0qOptAu5c7JW?= =?us-ascii?Q?xyV1WMh/+GNSlUp2QqZzpOwNJWOnInwXoQvFO/9yyZoe4LXjIDgBv3Qf0m+d?= =?us-ascii?Q?cifsZExjLJUY7VyKNhSOoa/zZLTV/Bp2iNOKtl/b0HUlRclTi8wEHElSvT8V?= =?us-ascii?Q?GIKHW4kujs37j1U7amL92hlp+vPQdcSp0ipgY9+dYS+gfRsuf2AXjonKk95w?= =?us-ascii?Q?IwcVnKy4b6JzIiuEcYBkPFMgWvV0eJFc24ijAkOo3PHIgQUxSPH9axZQtnvm?= =?us-ascii?Q?7RBf1s8NxRLSDlmA4C8bkEaKod2rPNks4RQVzZNTks9RMTVMYSWhGbln6Q+o?= =?us-ascii?Q?7yV6Y5QfbCnemaoN903cSWdNM2MQfAk9Q42GMRofrwjU9Uht1GtkIeSEhIyP?= =?us-ascii?Q?ywhOsxqja25OQbPPMRwWfASysYWTZd8sQYsRBxEjt6/fipXV/StW+J5pU5ya?= =?us-ascii?Q?MxL3o5ZOoD0xUjvxwRiXypQF7KlLM6UxO9pK6taxwpzCT/BWcZXuLZ71IP6p?= =?us-ascii?Q?GqzwgnvfeqS9vwm7ZwLrlRTrwYD+LtUQvVcMHPjs8j/tXx8/BHANbVF+fvj0?= =?us-ascii?Q?wWunuy2DeluPtdP22YLMk7LSLO0MHGGQ1cvMjuCC2W5XF0T/FJ9RGPadhCDU?= =?us-ascii?Q?bJ0cJVPrc5AaY65xFi8IzrFARabelS9Bpx+UjSVAdQuQqQHEwsp7P0PxWoY4?= =?us-ascii?Q?rNgqZZIN5adLXZPvIls/THkNXSXa4exLnibiNCavospG7umUpcUQ04zcO81W?= =?us-ascii?Q?8gNbKnCOnhZTDeB+XLORvqp0danee+DO1a3N3fnwuha3Du9SHXwXoslSl6xI?= =?us-ascii?Q?x+LAoom/VEzont6ghViRL3fJKMFcQ5FO1ZILX2pSfm2bnEJ64/Uo0PuHcM+C?= =?us-ascii?Q?gOipaf66eKgxkhyoNlug+CfIGnel57/IK/6+66rBx/lA5P7oKyoWSfG96k2f?= =?us-ascii?Q?0dSXhnw349BQtu0JV/6OddrK+NEYEskTG2TRcPweXhayMNgLE8/5odjd5gER?= =?us-ascii?Q?aSoVP3AbGZvtJ/OQJRnPYI324H5+HRIcBMw3jby29+2fT2B5RRhQC9yPUZ7U?= =?us-ascii?Q?9TzBDwnaSSNk5HAFy0BIk7ow?=
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_HE1PR07MB4441B874BCE8E1E726F982FC93CD9HE1PR07MB4441eurp_"
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: HE1PR07MB4441.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08840fcd-4391-4cf7-c569-08d96d29306b
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 09:16:32.1512 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bUlPJJByofPuFhxRg6Gf3j357qW2Gc44PvFDCUWLEM9F48LUyqk1YQ/8R98Kuk19Fy2yRg9rVt8DMNbDckhuLk3bj85gThm293Sg/0xhl84=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB3099
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/XfQN_Sb5Ar0eoY_8KxHbfiOObUY>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Sep 2021 09:16:49 -0000

Hi Nagendra,

Thank You for addressing my issues! I am happy with the outcome, and have no further issues.

Regards,

Christer

From: Nagendra Kumar Nainar (naikumar) <naikumar@cisco.com>
Sent: tiistai 31. elokuuta 2021 23.22
To: Christer Holmberg <christer.holmberg@ericsson.com>om>; gen-art@ietf.org
Cc: draft-ietf-mpls-lsp-ping-ospfv3-codepoint.all@ietf.org; last-call@ietf.org; mpls@ietf.org
Subject: Re: Genart last call review of draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04

Hi Christer,

Thank you for the detailed review and apologies for the very late response. Please find the response below:


Q1:

The Abstract and Introductions says:

   "This document proposes the code point to be used in the Segment ID
     Sub-TLV and Downstream Detailed Mapping TLV when the IGP is OSPFv3."

I suggest to say "specifies" or "defines" instead of "proposes".

<Authors> Sure. We will update the same.

Q2:

Would it be more clear to call Section 6 "Update to RFC 8287"?

<Authors> Ok.

Q3:

Section 6 says:

   "This document specifies that the above code points will be used only for
   OSPFv2."

I suggest to be more explicit, and say something like:

   "This document updates RFC 8287, by specifying that the "OSPF" code points
   will be used only for OSPFv2."

<Authors> Ok.

Q4:

Section 7.2 adds a note to the IANA registry for the existing "OSPF" code
point. Should this specification also be added as a reference for the existing
"OSPF" code point (in addition to RFC 8287?

<Authors>It already includes the code point as below:

"IANA is also requested to add a note for the existing entry for code
   point 1 (OSPF) to read: - "To be used for OSPFv2 only".
"
Please let us know if you are referring to something else.

Thanks,
Nagendra


Thanks,
Nagendra


From: Christer Holmberg via Datatracker <noreply@ietf.org<mailto:noreply@ietf.org>>
Date: Friday, June 11, 2021 at 3:58 AM
To: gen-art@ietf.org<mailto:gen-art@ietf.org> <gen-art@ietf.org<mailto:gen-art@ietf.org>>
Cc: draft-ietf-mpls-lsp-ping-ospfv3-codepoint.all@ietf.org<mailto:draft-ietf-mpls-lsp-ping-ospfv3-codepoint.all@ietf.org> <draft-ietf-mpls-lsp-ping-ospfv3-codepoint.all@ietf.org<mailto:draft-ietf-mpls-lsp-ping-ospfv3-codepoint.all@ietf.org>>, last-call@ietf.org<mailto:last-call@ietf.org> <last-call@ietf.org<mailto:last-call@ietf.org>>, mpls@ietf.org<mailto:mpls@ietf.org> <mpls@ietf.org<mailto:mpls@ietf.org>>
Subject: Genart last call review of draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04
Reviewer: Christer Holmberg
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-mpls-lsp-ping-ospfv3-codepoint-04
Reviewer: Christer Holmberg
Review Date: 2021-06-11
IETF LC End Date: 2021-06-21
IESG Telechat date: Not scheduled for a telechat

Summary: The document is easy to read, and is almost ready for publication.
However, I do have a few editorial comments that I would like the authors to
address.

Major issues: N/A

Minor issues: N/A

Nits/editorial comments:

Q1:

The Abstract and Introductions says:

   "This document proposes the code point to be used in the Segment ID
     Sub-TLV and Downstream Detailed Mapping TLV when the IGP is OSPFv3."

I suggest to say "specifies" or "defines" instead of "proposes".

Q2:

Would it be more clear to call Section 6 "Update to RFC 8287"?

Q3:

Section 6 says:

   "This document specifies that the above code points will be used only for
   OSPFv2."

I suggest to be more explicit, and say something like:

   "This document updates RFC 8287, by specifying that the "OSPF" code points
   will be used only for OSPFv2."

Q4:

Section 7.2 adds a note to the IANA registry for the existing "OSPF" code
point. Should this specification also be added as a reference for the existing
"OSPF" code point (in addition to RFC 8287?