Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-httpbis-cache-16

Lars Eggert <lars@eggert.org> Fri, 11 June 2021 12:08 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 246D43A355A; Fri, 11 Jun 2021 05:08:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JENi1tovOzW6; Fri, 11 Jun 2021 05:07:55 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2B56D3A3559; Fri, 11 Jun 2021 05:07:55 -0700 (PDT)
Received: from smtpclient.apple (unknown [212.68.24.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 60B2160031C; Fri, 11 Jun 2021 15:07:47 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1623413267; bh=DWchFnp0V9FR6vIEscI4OK4iCfysMyzxqUTc1iowygQ=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=Aym/+55agpj7dSdPz7ZtDN4FtkyhhZqM6mbmfIh/CnwBU3rTR2QMdbLwAPO2x2rhr VziAJaP6BdYlaQqhRcwElL1O+GrlHXf5+c0ZhVCRoESzkYbdce3RHMAW7Suq3diAr8 p+kx4G6rzte5sNh/cTd+b3Ep1pRLXJXzLeEn04Tk=
From: Lars Eggert <lars@eggert.org>
Message-Id: <6A7829D0-EE11-4E80-A2F8-3D5FF03881D1@eggert.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_BD589000-2598-4122-BD06-3E84EBAC8E14"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\))
Date: Fri, 11 Jun 2021 15:07:46 +0300
In-Reply-To: <162238407309.22812.14001073203740035939@ietfa.amsl.com>
Cc: General Area Review Team <gen-art@ietf.org>, last-call@ietf.org, ietf-http-wg@w3.org, draft-ietf-httpbis-cache.all@ietf.org
To: Mohit Sethi <mohit.m.sethi@ericsson.com>
References: <162238407309.22812.14001073203740035939@ietfa.amsl.com>
X-MailScanner-ID: 60B2160031C.AF6E9
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/YfSbusZFJhdvg9y7r0dJJMh-hk0>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-httpbis-cache-16
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Jun 2021 12:08:00 -0000

Mohit, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2021-5-30, at 17:14, Mohit Sethi via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Mohit Sethi
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-httpbis-cache-16
> Reviewer: Mohit Sethi
> Review Date: 2021-05-30
> IETF LC End Date: 2021-06-10
> IESG Telechat date: 2021-06-17
> 
> Summary: This draft specification defines HTTP caches and header fields for
> controlling the cache behavior.
> 
> Major issues:
> 
> Minor issues:
> - In the HTML version of the draft, the reference to [Semantics] does not work
> properly. I looked at the xml source which looks fine. I suspect it is
> something to do with the tooling.
> 
> - It is not clear to me which draft is creating the "Hypertext Transfer
> Protocol (HTTP) Field Name Registry". It seems both this draft and
> draft-ietf-httpbis-semantics are creating it? Perhaps you could remove the text
> in this draft saying "introduce the new" and just ask IANA to update the
> registry with fields in Table 1 of this draft.
> 
> Nits/editorial comments:
> 
> - Section 1: When does a client or server act as "tunnel"? I don't know if it
> is absolutely necessary to explain the term. You can decide.
> 
> - Section 1: HTTP caching's goal is significantly improving performance -> HTTP
> caching's goal is to significantly improve performance?
> 
> - Section 1.3: Maybe it is obvious to many readers, but I was not sure what is
> meant by a "canned string"?
> 
> - Section 3 vs Section 4: "A cache MUST NOT store a response to a request
> unless:" does not have a comma before unless while "When presented with a
> request, a cache MUST NOT reuse a stored response, unless:" has a comma before
> unless?
> 
> - Some of the bullets in section 3 and 4 were hard to parse. Take for example:
> "When presented with a request, a cache MUST NOT reuse a stored response,
> unless: the stored response does not contain the no-cache cache directive
> (Section 5.2.2.4), unless it is successfully validated (Section 4.3), and". I
> am not sure how to simplify the text on all these requirements.
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call