Re: [Gen-art] Gen-Art review of draft-ietf-netext-access-network-option-10.txt

Alexey Melnikov <alexey.melnikov@isode.com> Mon, 07 May 2012 09:40 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B67E821F858F; Mon, 7 May 2012 02:40:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.513
X-Spam-Level:
X-Spam-Status: No, score=-102.513 tagged_above=-999 required=5 tests=[AWL=0.086, BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fUdQcMUqNjAh; Mon, 7 May 2012 02:40:30 -0700 (PDT)
Received: from rufus.isode.com (cl-125.lon-03.gb.sixxs.net [IPv6:2a00:14f0:e000:7c::2]) by ietfa.amsl.com (Postfix) with ESMTP id A26E621F8570; Mon, 7 May 2012 02:40:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1336383627; d=isode.com; s=selector; i=@isode.com; bh=l1m2rqWpBNHgcq24BpyCgKcQsNS3lN0wf4KQhqAVrDM=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=Z9IkZh79e4aeY+x644u3TDnmBhWnSJpOj/169ew6GgdwS0pMH52fmhXizKkAeoz/kL3lk8 xyeJbqd4B1yE7ILVxqEMvm6nlrvx5YMfop25Np/ioYzhtWaLSuwHaPm846VfaFSrGnYkdY 2LPiklih54i9sHHD22b3HdDn1B2AMqY=;
Received: from [172.16.1.29] (shiny.isode.com [62.3.217.250]) by rufus.isode.com (submission channel) via TCP with ESMTPSA id <T6eYigB=g4me@rufus.isode.com>; Mon, 7 May 2012 10:40:27 +0100
X-SMTP-Protocol-Errors: PIPELINING
Message-ID: <4FA798B8.7070702@isode.com>
Date: Mon, 07 May 2012 10:41:12 +0100
From: Alexey Melnikov <alexey.melnikov@isode.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
To: jouni korhonen <jouni.nospam@gmail.com>
References: <CADhm99oKj8Trcx5o37kg=xZ85ut1iT4xcog+mBO_GP1T4Xnxqg@mail.gmail.com> <01b401cd13d3$322bc950$96835bf0$@isode.com> <3B677B5C-CC21-4252-B343-C6C4A57BBE5B@isode.com> <021901cd1447$39b550f0$ad1ff2d0$@isode.com> <24541053-C0B1-47B3-B866-19E0909BB176@isode.com> <021f01cd1491$13104820$3930d860$@isode.com> <E30B4753-60B8-470B-A1DF-E2ABD31D62E0@isode.com> <47440497-5003-4067-97D5-5426099AFECC@gmail.com>
In-Reply-To: <47440497-5003-4067-97D5-5426099AFECC@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: "Gen-art@ietf.org" <Gen-art@ietf.org>, "draft-ietf-netext-access-network-option.all@tools.ietf.org" <draft-ietf-netext-access-network-option.all@tools.ietf.org>, "iesg@ietf.org" <iesg@ietf.org>
Subject: Re: [Gen-art] Gen-Art review of draft-ietf-netext-access-network-option-10.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 May 2012 09:40:30 -0000

On 06/05/2012 20:58, jouni korhonen wrote:
> Alexey,
Hi Jouni,
> Thanks for the review. See some initial comments inline.
>
>
> On May 5, 2012, at 8:58 PM, Alexey Melnikov wrote:
>
>> I am the assigned Gen-ART reviewer for this draft. For background on
>> Gen-ART, please see the FAQ at
>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>>
>> Please resolve these comments along with any other Last Call comments
>> you may receive.
>>
>> Document: draft-ietf-netext-access-network-option-10.txt
>> Reviewer: Alexey Melnikov
>> Review Date: 5 May 2012
>> IETF LC End Date: 9 May 2012
>> IESG Telechat date: Unknown
>>
>> Summary: This draft is ready as a Proposed Standard
>>
>> Major issues: none
>>
>> Minor issues:
>>
>> Minor: [ANI] and [TS23003] seem to be Normative (as per their use in 3.1.1)
> If it is OK from the RFC process point of view, we can put these
> non-IETF references into the normative section.
I think that is fine in general. You should double check with the 
responsible AD whether the references are stable (as otherwise they 
might not be suitable for referencing normatively).
>> Nits/editorials:
>>
>> 1.  Introduction
>>
>>     This document defines a new mobility option, the Access Network
>>     Identifier (ANI) option and its sub-options for Proxy Mobile IPv6,
>>     that can be used by the mobile access gateway to signal the access
>>     network information to the local mobility anchor.  The specific
>>     details on how the local mobility anchor uses this information are
>>     out-of-scope for this document.  These mobility options are optional
>>     and are not mandatory for the Proxy Mobile IPv6 protocol.
>>
>> Nit: Last sentence: "optional" and "not mandatory" are the same thing on my book.
> Proposal for new text:
>
>     "These mobility options are optional for the Proxy Mobile IPv6 protocol."
Perfect :-).
>> Strictly speaking PEN numbers are not limited to 4 bytes. However you have a registry for types of identifiers, so a new value can be allocated for bigger-than-4-bytes PENs.
> Right. So we could just remove the 4 octet length requirement and use a
> "natural" length indicated octet coding for the PENs. For example
>
> ANI Length = 1 ->  PENs 0-255
> ANI Length = 2 ->  PENs 0-65535
> ANI Length = 3 ->  PENs 0-16777216
> ...
>
> That would be ok?
That would work, as long as the extra complexity (which is marginal in 
this case) is Ok with the WG.