Re: [Gen-art] Gen-ART LC review of draft-ietf-ospf-rfc6506bis-01.txt

Acee Lindem <acee.lindem@ericsson.com> Tue, 12 November 2013 21:03 UTC

Return-Path: <acee.lindem@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB6D921F9D0A; Tue, 12 Nov 2013 13:03:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.636
X-Spam-Level:
X-Spam-Status: No, score=-2.636 tagged_above=-999 required=5 tests=[AWL=-0.037, BAYES_00=-2.599]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fm5skO5YubE4; Tue, 12 Nov 2013 13:03:38 -0800 (PST)
Received: from usevmg21.ericsson.net (usevmg21.ericsson.net [198.24.6.65]) by ietfa.amsl.com (Postfix) with ESMTP id 3712621F9D46; Tue, 12 Nov 2013 13:03:37 -0800 (PST)
X-AuditID: c6180641-b7fbd8e0000011cc-70-528297a752c8
Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 43.82.04556.7A792825; Tue, 12 Nov 2013 22:03:35 +0100 (CET)
Received: from EUSAAMB101.ericsson.se ([147.117.188.118]) by EUSAAHC006.ericsson.se ([147.117.188.90]) with mapi id 14.02.0328.009; Tue, 12 Nov 2013 16:03:33 -0500
From: Acee Lindem <acee.lindem@ericsson.com>
To: Brian E Carpenter <brian.e.carpenter@gmail.com>, "draft-ietf-ospf-rfc6506bis.all@tools.ietf.org" <draft-ietf-ospf-rfc6506bis.all@tools.ietf.org>, General Area Review Team <gen-art@ietf.org>
Thread-Topic: Gen-ART LC review of draft-ietf-ospf-rfc6506bis-01.txt
Thread-Index: AQHO39vOy8Bio82VGEO7K/9iIETwV5oh40aA
Date: Tue, 12 Nov 2013 21:03:34 +0000
Message-ID: <94A203EA12AECE4BA92D42DBFFE0AE47030DDF4F@eusaamb101.ericsson.se>
In-Reply-To: <52827EA9.7040706@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/14.3.6.130613
x-originating-ip: [147.117.188.134]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1DDB137E21B9EA4C8D422F71E1FECF74@ericsson.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsUyuXRPlO7y6U1BBpdOKlq0XdzHZLFkTjeb xdVXn1ksnm2cz+LA4rFz1l12jyVLfjJ5fLn8mS2AOYrLJiU1J7MstUjfLoEr4/C6f4wFt8Uq Ds39ydTA+FOwi5GTQ0LARGLGhZvMELaYxIV769m6GLk4hASOMEpc7LoC5SxnlNj4egEjSBWb gI7E80f/mEESIgLHGSXut04FSzALaEj0nf3IBmILCzhLbJq+GywuIuAisX/FMyCbA8g2kpjb FA8SZhFQldh2+CrYZl4BX4m5W7+ClXAKaEr8u+UOEmYEOuj7qTVMENPFJW49mc8EcaiAxJI9 56GOFpV4+fgfK4gtKqAn0T1rOStEXFliyZP9LBC9OhILdn9ig7CtJf5tOAxla0ssW/ga6gRB iZMzn7BMYBSfhWTdLCTts5C0z0LSPgtJ+wJG1lWMHKXFqWW56UaGmxiBMXdMgs1xB+OCT5aH GKU5WJTEeb+8dQ4SEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwJhtH8WzOeOhwKbgnKtC5/tm 5nZ1nHEwvxBxbbbxqsoNjaqrFcOmiooEX7H91G3wLfLVnvAQ5tOb66UbP5zufn48dn06cw3H 54QLrf+SfwU7uaTOaGLvEHyiXXf8yDbO6cyaQisTMnMZrN7fz2gw7PlgPE20YFUws8Jy01mf QnaJSd57ltf8RYmlOCPRUIu5qDgRABM0zeWHAgAA
Cc: IETF discussion list <ietf@ietf.org>
Subject: Re: [Gen-art] Gen-ART LC review of draft-ietf-ospf-rfc6506bis-01.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Nov 2013 21:03:43 -0000

Hi Brian, 
Thanks much for the review. I believe I've added all your comments - see
inline. 

On 11/12/13 11:16 AM, "Brian E Carpenter" <brian.e.carpenter@gmail.com>
wrote:

>[Resending again with abject apologies for a typo in the To address.]
>
>[Resending with CC to the IETF list, since the ospf WG list
>automatically rejects non-subscriber messages.]
>
>I am the assigned Gen-ART reviewer for this draft. For background on
>Gen-ART, please see the FAQ at
><http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>
>Please resolve these comments along with any other Last Call comments
>you may receive.
>
>Document: draft-ietf-ospf-rfc6506bis-01.txt
>Reviewer: Brian Carpenter
>Review Date: 2013-11-12
>IETF LC End Date: 2013-11-26
>IESG Telechat date:
>
>Summary:  Ready with issues
>--------
>
>Major issue:
>------------
>
>The listed changes from RFC 6506 include:
>
>>    2.  Section 3 previously advocated usage of an expired key for
>>        transmitted OSPFv3 packets when no valid keys existed.  This
>>        statement has been removed.
>
>I cannot see where this has been removed. In the last paragraph of
>Section 3, the text starting:
>
>> In the event that the last key associated with an interface expires,...
>
>has not been changed. Isn't that the text that should be removed? In fact,
>shouldn't it be explicitly contradicted, to ensure that implementations
>are changed to fail-secure rather than run-insecure?

Sigh - good catch. We actually discussed the text on the list but I
neglected to update it in the final revision. This is how the paragraph
will read in the next revision.

Key storage SHOULD persist across a system restart, warm or cold, to
   avoid operational issues.  In the event that the last key associated
   with an interface expires, the network operator SHOULD be notified
   and the OSPFv3 packet MUST NOT be transmitted unauthenticated.









>
>
>Nits:
>-----
>
>"errata" is a plural, often misused in this draft as a singular. The
>singular
>noun is "erratum".

I replaced the 3 instances of "errata" with "erratum" in section 1.2. In
the acknowledgements, the instances of "errata" were correct.


>
>	
>> This document may contain material from IETF Documents or IETF	
>> Contributions published or made publicly available before November	
>> 10, 2008. The person(s) controlling the copyright in some of this	
>  ...
>
>This disclaimer logically cannot be needed, since RFC6506 was published
>after Nov. 10, 2008.

I've removed this by updating the xml ipr tag to simply "trust200902".


>
>
>
>> 6.  Security Considerations
>...
>>   It addresses all the security
>>   issues that have been identified in [RFC6039].
>
>and in [RFC6506] (judging by section 1.2).

Added the reference to RFC 6506.

Thanks,
Acee 




>
>