[Gen-art] Gen-ART telechat review of draft-ietf-idr-ls-distribution-10

Alexey Melnikov <alexey.melnikov@isode.com> Sun, 10 May 2015 16:14 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BCF5F1A6F38 for <gen-art@ietfa.amsl.com>; Sun, 10 May 2015 09:14:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 2.695
X-Spam-Level: **
X-Spam-Status: No, score=2.695 tagged_above=-999 required=5 tests=[BAYES_20=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FH_RELAY_NODNS=1.451, HELO_MISMATCH_COM=0.553, RDNS_NONE=0.793, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uvFM0KmPo3Gn for <gen-art@ietfa.amsl.com>; Sun, 10 May 2015 09:14:23 -0700 (PDT)
Received: from statler.isode.com (unknown [217.34.220.151]) by ietfa.amsl.com (Postfix) with ESMTP id A4E401A6F30 for <gen-art@ietf.org>; Sun, 10 May 2015 09:14:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1431274462; d=isode.com; s=selector; i=@isode.com; bh=nxFZoj73uuBCLxnN4ZuvEfVNe+NdrqF4riJdmvlrnC8=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=Yl49+5GCT5rs9RqY9BQfTATTzONB0xnRAyNBK5c4Ul+66fEpG25thQTQa5KTW3eFQZc4Tv NokeUkfZltpDjWagmd6/awhtJP/zxg80/IyJ9v1LY/GX/hchJwh8DdPQ7I83qbnzRC26Ql RMOCJAW8AsHfuOKZOh05nyHo3/aTYAQ=;
Received: from [192.168.0.5] (cpc5-nmal20-2-0-cust24.19-2.cable.virginm.net [92.234.84.25]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <VU-D3QAne68E@statler.isode.com>; Sun, 10 May 2015 17:14:22 +0100
X-SMTP-Protocol-Errors: PIPELINING
Message-ID: <554F83E2.6060408@isode.com>
Date: Sun, 10 May 2015 17:14:26 +0100
From: Alexey Melnikov <alexey.melnikov@isode.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
To: draft-ietf-idr-ls-distribution-10.all@ietf.org, General Area Review Team <gen-art@ietf.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-transfer-encoding: quoted-printable
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/dyvc7jyqx4hXly9PlmwWnkMHP8o>
Subject: [Gen-art] Gen-ART telechat review of draft-ietf-idr-ls-distribution-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 10 May 2015 16:14:24 -0000

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
< http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please wait for direction from your document shepherd
or AD before posting a new version of the draft.

Document: draft-ietf-idr-ls-distribution-10.txt
Reviewer: Alexey Melnikov
Review Date: 2015-05-10
IETF LC End Date: 2015-04-08
IESG Telechat date: N/A

My apologies for the late review of this document.

Summary: Ready with nits


Minor (but some of these might be more serious):

In 6.2.2:

If an implementation of BGP-LS detects a malformed attribute, then it
    SHOULD use the ’Attribute Discard’ action as per
    [I-D.ietf-idr-error-handling] Section 2.

This needs to be a Normative reference. Or you can keep it as 
Informative, if you change the sentence not to use RFC 2119 language.

In 3.3.1.1 - does this need a new IANA registry? (I am fine if you think 
you don't).

In 3.3.1.3/3.3.2.7 - what is "subset of the FQDN"?

In 3.3.2.3:

       The TE Default Metric TLV carries the TE-metric for this link.
       The length of this TLV is fixed at 4 octets.

I am probably showing my ignorance, but is the term "TE-metric" defined 
somewhere? The description below suggests it has substructure, which I 
don't know anything about.

        If a source protocol (e.g.
        IS-IS) does not support a Metric width of 32 bits then the high
        order octet MUST be set to zero.

Best Regards,
Alexey