Re: [Gen-art] Gen-ART Telechat review of draft-ietf-i2rs-yang-dc-fabric-network-topology-07
"Zhuangyan (Yan)" <zhuangyan.zhuang@huawei.com> Wed, 04 April 2018 09:30 UTC
Return-Path: <zhuangyan.zhuang@huawei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 78DF412D87D; Wed, 4 Apr 2018 02:30:03 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.211
X-Spam-Level:
X-Spam-Status: No, score=-4.211 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4M8_g0KLboGH; Wed, 4 Apr 2018 02:29:57 -0700 (PDT)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EEA1212EAD3; Wed, 4 Apr 2018 02:29:53 -0700 (PDT)
Received: from LHREML710-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id F08BF7BA506EF; Wed, 4 Apr 2018 10:29:49 +0100 (IST)
Received: from NKGEML412-HUB.china.huawei.com (10.98.56.73) by LHREML710-CAH.china.huawei.com (10.201.108.33) with Microsoft SMTP Server (TLS) id 14.3.382.0; Wed, 4 Apr 2018 10:29:51 +0100
Received: from NKGEML513-MBS.china.huawei.com ([169.254.2.231]) by nkgeml412-hub.china.huawei.com ([10.98.56.73]) with mapi id 14.03.0361.001; Wed, 4 Apr 2018 17:29:46 +0800
From: "Zhuangyan (Yan)" <zhuangyan.zhuang@huawei.com>
To: Paul Kyzivat <pkyzivat@alum.mit.edu>, "draft-ietf-i2rs-yang-dc-fabric-network-topology.all@ietf.org" <draft-ietf-i2rs-yang-dc-fabric-network-topology.all@ietf.org>
CC: General Area Review Team <gen-art@ietf.org>
Thread-Topic: Gen-ART Telechat review of draft-ietf-i2rs-yang-dc-fabric-network-topology-07
Thread-Index: AQHTyRSY0uqBjxvyxUONDFPIGPrdm6PsuEtggAHv1ICAAbKMwA==
Date: Wed, 04 Apr 2018 09:29:46 +0000
Message-ID: <9B4BC45FDEDDD84F813E9E4A5BAF8785A96B72FF@nkgeml513-mbs.china.huawei.com>
References: <3932ca75-95ae-64bc-be66-b189386c8d4a@alum.mit.edu> <9B4BC45FDEDDD84F813E9E4A5BAF8785A96B65D8@nkgeml513-mbs.china.huawei.com> <c307f8fe-4162-6e23-f61c-6292ec37cc1e@alum.mit.edu>
In-Reply-To: <c307f8fe-4162-6e23-f61c-6292ec37cc1e@alum.mit.edu>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.135.170.230]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/fl7Xl3QlphPDvxb-PTOcskYvghE>
Subject: Re: [Gen-art] Gen-ART Telechat review of draft-ietf-i2rs-yang-dc-fabric-network-topology-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2018 09:30:03 -0000
Hi Paul, Thank you very much for the reply. We will fix those nits in next version. Some replies below. Best Regards, Yan -----Original Message----- From: Paul Kyzivat [mailto:pkyzivat@alum.mit.edu] Sent: Tuesday, April 03, 2018 11:27 PM To: Zhuangyan (Yan) <zhuangyan.zhuang@huawei.com>; draft-ietf-i2rs-yang-dc-fabric-network-topology.all@ietf.org Cc: General Area Review Team <gen-art@ietf.org> Subject: Re: Gen-ART Telechat review of draft-ietf-i2rs-yang-dc-fabric-network-topology-07 On 4/1/18 11:09 PM, Zhuangyan (Yan) wrote: > Hi Paul, > > Thank you very much for your review and comments. > Some responses below. > > Best Regards, > > Yan > > -----Original Message----- > From: Paul Kyzivat [mailto:pkyzivat@alum.mit.edu] > Sent: Sunday, April 01, 2018 1:20 AM > To: draft-ietf-i2rs-yang-dc-fabric-network-topology.all@ietf.org > Cc: General Area Review Team <gen-art@ietf.org> > Subject: Gen-ART Telechat review of > draft-ietf-i2rs-yang-dc-fabric-network-topology-07 > > I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft. For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > > Document: draft-ietf-i2rs-yang-dc-fabric-network-topology-07 > Reviewer: Paul Kyzivat > Review Date: 2018-03-31 > IETF LC End Date: 2018-04-03 > IESG Telechat date: 2018-04-05 > > Summary: > > This draft is basically ready for publication, but has nits that should be fixed before publication. > > Disclaimer: > > I conducted this review without any knowledge of YANG modeling. So the sort of review I can do is superficial. > > Issues: > > Major: 0 > Minor: 0 > Nits: 4 > > (1) NIT: > > In my opinion many of the normative references aren't actually > normative, and can/should be changed to informative references. In > particular the following all seem likely candidates: RFC5246 (TLS), > RFC6241 and RFC6242 (NETCONF), RFC8040 (RESTCONF), RFC8342 (NMDA), RFC8346. There may be others. > [Yan] For RFC5246 (TLS), RFC6241, RFC6242 (NETCONF), RFC8040 (RESTCONF) and RFC8342 (NMDA), they are building blocks for YANG module usage and definition, hence referenced as normative. I get your point, but as best I can tell there is no normative dependency on any of them. They are all *possible* substrates for using this work, but none of them are required. But it is your call. [Yan] Thank you : ) we will follow relative RFCs to keep aligned. > (3) NIT: > > IdNits reports 3 errors and 7 warnings, regarding long lines, references that are missing, unused, obsolete, and a downref. Please fix the errors and review the warnings. > [Yan] I checked v-07 with idnits 2.15.01, there is no errors/warnings or nits found...can you direct me to the tool you use? I'm sorry. I actually reviewed -08, even though my message said I reviewed -07. I looked at the HTMLized version: https://tools.ietf.org/html/draft-ietf-i2rs-yang-dc-fabric-network-topology-08 and then cliced [Nits] at the top: https://tools.ietf.org/idnits?url=https://tools.ietf.org/id/draft-ietf-i2rs-yang-dc-fabric-network-topology-08.txt [Yan] thanks a lot. We'll fix them in next version. Thanks, Paul
- [Gen-art] Gen-ART Telechat review of draft-ietf-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Telechat review of draft-ie… Zhuangyan (Yan)
- Re: [Gen-art] Gen-ART Telechat review of draft-ie… Paul Kyzivat
- Re: [Gen-art] Gen-ART Telechat review of draft-ie… Zhuangyan (Yan)