[Gen-art] Gen-ART Telechat review of draft-ietf-i2rs-yang-dc-fabric-network-topology-07

Paul Kyzivat <pkyzivat@alum.mit.edu> Sat, 31 March 2018 17:20 UTC

Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 28FE012D872; Sat, 31 Mar 2018 10:20:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.21
X-Spam-Level:
X-Spam-Status: No, score=-4.21 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id abJ7_MIu2zs3; Sat, 31 Mar 2018 10:20:21 -0700 (PDT)
Received: from alum-mailsec-scanner-4.mit.edu (alum-mailsec-scanner-4.mit.edu [18.7.68.15]) by ietfa.amsl.com (Postfix) with ESMTP id 0C75E126FDC; Sat, 31 Mar 2018 10:20:17 -0700 (PDT)
X-AuditID: 1207440f-53fff700000068d7-62-5abfc34d0647
Received: from outgoing-alum.mit.edu (OUTGOING-ALUM.MIT.EDU [18.7.68.33]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by alum-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP id AB.70.26839.E43CFBA5; Sat, 31 Mar 2018 13:20:14 -0400 (EDT)
Received: from PaulKyzivatsMBP.localdomain (c-24-62-227-142.hsd1.ma.comcast.net [24.62.227.142]) (authenticated bits=0) (User authenticated as pkyzivat@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.13.8/8.12.4) with ESMTP id w2VHKClN019149 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 31 Mar 2018 13:20:13 -0400
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
To: draft-ietf-i2rs-yang-dc-fabric-network-topology.all@ietf.org
Cc: General Area Review Team <gen-art@ietf.org>
Message-ID: <3932ca75-95ae-64bc-be66-b189386c8d4a@alum.mit.edu>
Date: Sat, 31 Mar 2018 13:20:12 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsUixO6iqOt3eH+Uwbw1VhYLu2Usrr76zOLA 5LFkyU+mAMYoLpuU1JzMstQifbsErowzq2+zFszkrXhx+S17A+NVri5GTg4JAROJ5Z++sHQx cnAICexgkrhb2sXIBWQ+ZJJYMGMCO0gNm4CWxJxD/1lAbGGBCImZE5aC2SICDhLXPk5lBrGZ BfQl/j5ZzARi8wrYS8x49gjMZhFQlTj+fh0biC0qkCZxqXkrM0SNoMTJmU9YIHrNJOZtfgg1 R1zi1pP5TBC2vETz1tnMExj5ZiFpmYWkZRaSlllIWhYwsqxilEvMKc3VzU3MzClOTdYtTk7M y0st0jXRy80s0UtNKd3ECAlB/h2MXetlDjEKcDAq8fAyxO+LEmJNLCuuzD3EKMnBpCTKm9cG FOJLyk+pzEgszogvKs1JLT7EKMHBrCTCK5a0P0qINyWxsiq1KB8mJc3BoiTOy2qyN0pIID2x JDU7NbUgtQgmK8PBoSTBe/8gUKNgUWp6akVaZk4JQpqJgxNkOA/Q8FKQGt7igsTc4sx0iPwp RmOOKc/7e5g5Tryf0sMsxJKXn5cqJc5bBVIqAFKaUZoHNw2WRl4xigM9J8zbcwioigeYguDm vQJaxQS0SqRmD8iqkkSElFQDo/LEVUfry5MuhS7gvRbSMu2W1iXz/+/6LmflipzefdPit9V7 74qKMu/I94rTE/KWH925yTUo7OTjnhqrNp8fteWfTs75r6Re/Xti2x8f785Mteti1iEyRcLf i7bWKutadeQu+yD/5lyo7fZ9v/OFwmo91W+K3rsrtzAuUzFC0valSN8GHeMLSizFGYmGWsxF xYkASnfxhv4CAAA=
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/w3CVTRf8y-ezymrLU7Qi_lewacs>
Subject: [Gen-art] Gen-ART Telechat review of draft-ietf-i2rs-yang-dc-fabric-network-topology-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Mar 2018 17:20:23 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area 
Review Team (Gen-ART) reviews all IETF documents being processed by the 
IESG for the IETF Chair. Please wait for direction from your document 
shepherd or AD before posting a new version of the draft. For more 
information, please see the FAQ at 
<​http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-i2rs-yang-dc-fabric-network-topology-07
Reviewer: Paul Kyzivat
Review Date: 2018-03-31
IETF LC End Date: 2018-04-03
IESG Telechat date: 2018-04-05

Summary:

This draft is basically ready for publication, but has nits that should 
be fixed before publication.

Disclaimer:

I conducted this review without any knowledge of YANG modeling. So the 
sort of review I can do is superficial.

Issues:

Major: 0
Minor: 0
Nits:  4

(1) NIT:

In my opinion many of the normative references aren't actually 
normative, and can/should be changed to informative references. In 
particular the following all seem likely candidates: RFC5246 (TLS), 
RFC6241 and RFC6242 (NETCONF), RFC8040 (RESTCONF), RFC8342 (NMDA), 
RFC8346. There may be others.

(2) NIT:

In the IANA Considerations section the formatting is hard to read. 
Distinct elements for the registry (e.g., "URI:" and "Registrant 
Contact:") are run together. For readability they should be on separate 
lines.

(3) NIT:

IdNits reports 3 errors and 7 warnings, regarding long lines, references 
that are missing, unused, obsolete, and a downref. Please fix the errors 
and review the warnings.

(4) NIT:

In the title of section 2:

s/Definitions an Acronyms/Definitions and Acronyms/