Re: [Gen-art] Genart last call review of draft-ietf-6tisch-6top-protocol-10

Brian E Carpenter <brian.e.carpenter@gmail.com> Sat, 31 March 2018 21:28 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5835D1241F3; Sat, 31 Mar 2018 14:28:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QVdrPOuh_tqG; Sat, 31 Mar 2018 14:28:04 -0700 (PDT)
Received: from mail-pf0-x236.google.com (mail-pf0-x236.google.com [IPv6:2607:f8b0:400e:c00::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6D3B21242EA; Sat, 31 Mar 2018 14:28:04 -0700 (PDT)
Received: by mail-pf0-x236.google.com with SMTP id y69so7557186pfb.5; Sat, 31 Mar 2018 14:28:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UAubDV/BrOJ08xrFG+DCAIAEPwEoRlXIbaRjZl3zlSU=; b=cFkCV2OMk04YWFxI7+5BnbNsK/CW7PBC31VOMj4945DwFE2Nng9yoI38uIGEtRywqR Y5bPuRtFIYkaDzPXz4S9RJKvRkbaF+4ktIc3q+0ynKXTE2W6ukLSgWoRYjVTEftUONjY eitP/G6v50eQ/x3XKj7GfmklnvYQh5Ozv4ob7hZphxEn71pWV11iywGTlqj4kMY4Eu+u TRpyqlWK6m9KaZongqvQI3HK02TS8Bi+T0odxWRf+ciA/koiCUQjl5VKTPgMcjK5Ojk5 tNH9Uygy6YztPhW0WXtuH8j1Tq+cFM7O45qVBHpY8BGZNwBlfrCYWBbqoPxa4K3+JN2+ 4ZHw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UAubDV/BrOJ08xrFG+DCAIAEPwEoRlXIbaRjZl3zlSU=; b=iNNlsaR4nc71uXCu7oWCeP2b1D05ofuLt/pK9V4B/ery7pCnFxeYA5K2LULKMLJtDQ XGHQZ1hOKRkZDsDBSripICzHCFWEtUhamZi0EOU81tST7fa5qwLXriRjYeiP8PzupBHz TcWvGr5t2Sy6a0nAfBYiZV2oGi3iJMcbU5jdTxwsMAn4s0FaFK/5xrYZhz0WGZe1aPxN bwyaNXe2hVyOeG9/P3t1k0UOezv98TKRN1nYcR/JrS5eiAkJeTOoyoMOHN4ETKzI/Yk0 5qoTGnpKkxnW68IInydjW5uFQ0NqePK8VTgmqUKYTpl3XBhDpEZhHL/w3M+SwRgIMuf6 xVvg==
X-Gm-Message-State: AElRT7HamuwvZswwob6oBFtqZLNXGmSobq3pKOnnR7xmg5OwHXI9XnP7 98dSSjIb1FXG32NV23sHL4Mk6A==
X-Google-Smtp-Source: AIpwx48pYUO5rRl8k+5lu329pOdrBXxXu9saC1YRqEqvg9CQeuhJJWCAKvHkNLRoJe71Whl0J08dww==
X-Received: by 10.98.87.151 with SMTP id i23mr3046619pfj.175.1522531683684; Sat, 31 Mar 2018 14:28:03 -0700 (PDT)
Received: from [192.168.178.26] ([118.148.78.146]) by smtp.gmail.com with ESMTPSA id x14sm21543641pgo.82.2018.03.31.14.28.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Mar 2018 14:28:02 -0700 (PDT)
To: Xavi Vilajosana Guillen <xvilajosana@uoc.edu>
Cc: gen-art@ietf.org, draft-ietf-6tisch-6top-protocol.all@ietf.org, tisch <6tisch@ietf.org>
References: <1795952350.395820.1520737954029.JavaMail.root@canet.uoc.es> <CAC9+vPiqHw1F7Nc+J5vQJreahHDfusBtgVMn03W=xa+TJN2HSw@mail.gmail.com> <03aaa42a-e65f-fc2f-9805-fbeec311c865@gmail.com>
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
Organization: University of Auckland
Message-ID: <9c248d9a-445f-ad4a-9f8c-f6d84c5cd882@gmail.com>
Date: Sun, 01 Apr 2018 09:28:08 +1200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <03aaa42a-e65f-fc2f-9805-fbeec311c865@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/v0hrVWDqPwVCgQnC7JAFdEykgI8>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-6tisch-6top-protocol-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Mar 2018 21:28:06 -0000

Hi,

The published -11 text is even better than the proposal below.

Thanks
   Brian Carpenter

On 23/03/2018 08:10, Brian E Carpenter wrote:
> That looks good to me. I think it will help implementers.
> 
> Thanks
>    Brian Carpenter
> 
> On 22/03/2018 21:41, Xavi Vilajosana Guillen wrote:
>> Dear Brian,
>>
>> after the WG meeting we proceed to resolve your pointed issue. Thanks so
>> much for going through the draft again.
>>
>> We will publish v11 with the following update on the text as you suggested.
>> We hope this clarifies your point.
>>
>>
>> In section 3.1.1.  2-step 6P Transaction
>> we added:
>> Race conditions MAY happen when a timeout expires while a 6P
>>        Response is on the air.  Other inconsistencies can also happen
>>        when the last L2 ACK for a 6P Response is lost or when one of the
>>        nodes is power cycled.  6P provides an inconsistency detection
>>        mechanism described in Section 3.4.6.1 to cope with such
>>        situations.
>>
>>
>> In section 3.1.2.  3-step 6P Transaction
>> we added:
>>   Race conditions MAY happen when a timeout expires while a 6P
>>        Confirmation is on the air.  Other inconsistencies can also
>>        happen when the last L2 ACK for a 6P Confirmation is lost or when
>>        one of the nodes is power cycled.  6P provides an inconsistency
>>        detection mechanism described in Section 3.4.6.1 to cope with
>>        such situations.
>>
>>
>> kind regards
>> Xavi
>>
>>
>> 2018-03-11 4:11 GMT+01:00 Brian Carpenter <brian.e.carpenter@gmail.com>:
>>
>>> Reviewer: Brian Carpenter
>>> Review result: Ready
>>>
>>> I am the assigned Gen-ART reviewer for this draft. The General Area
>>> Review Team (Gen-ART) reviews all IETF documents being processed
>>> by the IESG for the IETF Chair.  Please treat these comments just
>>> like any other last call comments.
>>>
>>> For more information, please see the FAQ at
>>>
>>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>>>
>>> Document: draft-ietf-6tisch-6top-protocol-10
>>> Reviewer: Brian Carpenter
>>> Review Date: 2018-03-10
>>> IETF LC End Date: 2018-03-26
>>> IESG Telechat date: 2018-04-05
>>>
>>> Summary: Ready
>>>
>>> Comment:
>>>
>>> Most of my previous comments have been fixed, thanks. I still disagree
>>> with the authors on one point, but not enough to delay the draft:
>>>
>>> In section 3.1.1 "2-step 6P Transaction" there seems to be a rare race
>>> condition
>>> if A's timeout expires while B's Response is in flight. This will be
>>> detected
>>> later as an inconsistency (section 3.4.6.2). The authors don't think it's
>>> necessary
>>> to mention this in 3.1.1. IMHO it would be useful to mention. (Similarly
>>> for
>>> section 3.1.2, 3-step transaction.)
>>>
>>>
>>>
>>
>>