[Gen-art] Gen-ART review of draft-ietf-ipsecme-dh-checks-04

"Romascanu, Dan (Dan)" <dromasca@avaya.com> Mon, 13 May 2013 10:30 UTC

Return-Path: <dromasca@avaya.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2DAC821F944F for <gen-art@ietfa.amsl.com>; Mon, 13 May 2013 03:30:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -103.599
X-Spam-Level:
X-Spam-Status: No, score=-103.599 tagged_above=-999 required=5 tests=[AWL=0.001, BAYES_00=-2.599, RCVD_IN_DNSWL_LOW=-1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fULs0EG2zbS8 for <gen-art@ietfa.amsl.com>; Mon, 13 May 2013 03:30:43 -0700 (PDT)
Received: from co300216-co-outbound.net.avaya.com (co300216-co-outbound.net.avaya.com [198.152.13.100]) by ietfa.amsl.com (Postfix) with ESMTP id B8A7621F9428 for <gen-art@ietf.org>; Mon, 13 May 2013 03:30:43 -0700 (PDT)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AgMFAAH/ZlGHCzI1/2dsb2JhbABQgmUhNsFIgQcWdIIhAQEDEigxDhIBFQcOFEImAQQODRMHh3IBC6A8nSOOZTGCZ2EDmCOFBopogwuCKA
X-IronPort-AV: E=Sophos;i="4.87,456,1363147200"; d="scan'208";a="10904167"
Received: from unknown (HELO p-us1-erheast.us1.avaya.com) ([135.11.50.53]) by co300216-co-outbound.net.avaya.com with ESMTP; 13 May 2013 06:30:42 -0400
Received: from unknown (HELO AZ-FFEXHC02.global.avaya.com) ([135.64.58.12]) by p-us1-erheast-out.us1.avaya.com with ESMTP; 13 May 2013 06:26:55 -0400
Received: from AZ-FFEXMB04.global.avaya.com ([fe80::6db7:b0af:8480:c126]) by AZ-FFEXHC02.global.avaya.com ([135.64.58.12]) with mapi id 14.02.0328.009; Mon, 13 May 2013 06:30:40 -0400
From: "Romascanu, Dan (Dan)" <dromasca@avaya.com>
To: General Area Review Team <gen-art@ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-ipsecme-dh-checks-04
Thread-Index: Ac5PxOpSKJSOZmkPTSywzPeMi8NITQ==
Date: Mon, 13 May 2013 10:30:40 +0000
Message-ID: <9904FB1B0159DA42B0B887B7FA8119CA16ABFB@AZ-FFEXMB04.global.avaya.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [135.64.58.45]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "draft-ietf-ipsecme-dh-checks.all@tools.ietf.org" <draft-ietf-ipsecme-dh-checks.all@tools.ietf.org>
Subject: [Gen-art] Gen-ART review of draft-ietf-ipsecme-dh-checks-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 May 2013 10:30:49 -0000

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments you may receive.

Document: draft-ietf-ipsecme-dh-checks-04
Reviewer: Dan Romascanu
Review Date: 5/13/13
IETF LC End Date: 5/20/13
IESG Telechat date: 

Summary:

This document is Ready. It is clearly written and easy to follow, even for a non-expert in security. I appreciated the sections that describe the transition to implementations that support the update and the ones that describe behavior upon test failures - which are of value to implementers and operators. One minor issue related to the IANA registry may be only an issue of clarification. 

Major issues:

Minor issues:

The IANA Considerations Sections mention that Groups 27-30 have been recently defined in [I-D.merkle-ikev2-ke-brainpool]. This is an Informational Reference which is somehow odd, because without this reference the IANA actions could not be completed. On the other hand making [I-D.merkle-ikev2-ke-brainpool] Normative Reference would create a downref because the later is informational. I believe this is OK, because I see the document in RFC Editor Queue waiting for IANA actions, which may actually be exactly the ones described in this I-D, but a cleaner solution would have been not defining at all Groups 27-30 here. 

Nits/editorial comments: