Re: [Gen-art] Genart last call review of draft-ietf-babel-dtls-05

David Schinazi <dschinazi.ietf@gmail.com> Tue, 25 June 2019 18:29 UTC

Return-Path: <dschinazi.ietf@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 95757120997; Tue, 25 Jun 2019 11:29:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2N6MUsJ-7t5t; Tue, 25 Jun 2019 11:29:37 -0700 (PDT)
Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5D859120379; Tue, 25 Jun 2019 11:29:29 -0700 (PDT)
Received: by mail-lf1-x132.google.com with SMTP id 136so13366946lfa.8; Tue, 25 Jun 2019 11:29:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fZK+jtCYP5vZZGaBRKfeO1bOYp3LwA4rsRa0q0xYVdk=; b=H2/9Ao+q43hsRsXOoT/5NQGH6z+2kOOR0R3Pocsk/c0uJYONCMPzUqZo/baIRnsmwy nb+4voZkvyU3FtRfTamj8JzN6thIHrN/vjT99d+A4yvHvwN2cAvTGZAxZ082xw4nK7gs mzLjkoIIh/KN9txxPW5klvV0U/KvmF0WmEXbU7LebMPXatWT5f/8XeTSmnAqiEjJUth1 /kEs/Nnx7I6+oL2IO3yk1STczj58aiCUK7mJ+RvADRVUII/8zZom05O7uLmn9FpaxNHT 22oKHZ3jon8OvvY0mX7geYdGkwEm7UPDqdWYO5G1iCdDNBo2JZMsa74v2mux7S0HqtD6 F84A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fZK+jtCYP5vZZGaBRKfeO1bOYp3LwA4rsRa0q0xYVdk=; b=EC0MAgdhJLK1fWDMTqDPLeIG8a16z8wpFMHszZ1L39blUO2ZJZgS3a3y77/GlQgHTk ox0L07URNSG4u+Fo01vUaIRZWGMBOGKya/kpas7SDcqshbW2TssZSsQ8NFJ1P/C6Sb1+ vab3mKiFCyQBmy9PPgDJM+bdirvFGnw4jsiRXIcWJpp6AOYq6LK56SHN1qddeUR1gH/W KEvvcVlxT5gpQZW/+AYUvqou6ONtOmCUL7YvZ6tlOniOwvN4uZKJ++YVk74Z611dLjAG 6rlmDCWdykqfQmZ55Essaw73Y7IYzRGzHR0n2BRr9kVpuN6aoQmK/r/9rDDe0nag5JC/ 2utQ==
X-Gm-Message-State: APjAAAXImW9UUONqIWT5gOdWpPt6+6yOMwNq9QwZvXa97aBx2Buy7TVs hJboFiAvw4wc2vhY/vTqeni4mJ+oiD3fDhs+qOA=
X-Google-Smtp-Source: APXvYqy/M4wcLGSIgUS/U9ShzfrcymNHLcXIxlPeYMMrJ9VSexWsaRxS+r9mrYT7YaufI+iQ+mAZk8Lftp5RGTizw4g=
X-Received: by 2002:a05:6512:51c:: with SMTP id o28mr112017lfb.67.1561487367412; Tue, 25 Jun 2019 11:29:27 -0700 (PDT)
MIME-Version: 1.0
References: <156148141106.31261.11148445355862352575@ietfa.amsl.com>
In-Reply-To: <156148141106.31261.11148445355862352575@ietfa.amsl.com>
From: David Schinazi <dschinazi.ietf@gmail.com>
Date: Tue, 25 Jun 2019 11:29:16 -0700
Message-ID: <CAPDSy+5RSzULfPF71Uq-Jkrm7XH7Quj00_jZ9WcdpbaX3qk5bA@mail.gmail.com>
To: Dan Romascanu <dromasca@gmail.com>
Cc: gen-art@ietf.org, draft-ietf-babel-dtls.all@ietf.org, IETF Discussion <ietf@ietf.org>, Babel at IETF <babel@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000db1e06058c2a1b33"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/g697u-RHRlmy9sytsHUls-6C24Y>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-babel-dtls-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jun 2019 18:29:39 -0000

Hello Dan, and thanks for your review. Comments inline.

1. In section 2.1:
>
> > The default port
>    for Babel over DTLS is registered with IANA as the "babel-dtls" port
>    (UDP port TBD, see Section 4), and the port exchanging unencrypted
>    Babel traffic is registered as the "babel" port (UDP port 6696).
>
> A reference would be desirable here.
>

What reference do you have in mind? This paragraph already has a
reference to Section 4 (IANA Considerations).


> 2. In section 2.4
>
> > Nodes MUST silently ignore any unprotected
>    packet sent over unicast.  When parsing an unprotected packet, a node
>    MUST silently ignore all TLVs that are not of type Hello.  Nodes MUST
>    also silently ignore any unprotected Hello with the Unicast flag set.
>
> Is the last sentence necessary? Is this case not covered by the statement
> in
> the first sentence?
>

The Unicast flag is a bit in the Babel packet. This statement instructs
nodes
to ignore a Hello TLV which was received over multicast but has the unicast
flag set.

Thanks,
David