Re: [Gen-art] Genart last call review of draft-ietf-babel-dtls-05

Dan Romascanu <dromasca@gmail.com> Tue, 25 June 2019 18:41 UTC

Return-Path: <dromasca@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8D1B3120995; Tue, 25 Jun 2019 11:41:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QuHFADUkTu-H; Tue, 25 Jun 2019 11:41:04 -0700 (PDT)
Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9CBE61202E0; Tue, 25 Jun 2019 11:41:04 -0700 (PDT)
Received: by mail-io1-xd2c.google.com with SMTP id n5so272979ioc.7; Tue, 25 Jun 2019 11:41:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LKwxavEBodJ3OPwazuUaCUziZ6MQqRiwwFKpeAK3IrE=; b=OLob05BrlSX42IvLKbvgI8t5WBPYKs4/1Rawn5PwBCGemNnbMgsuDhSGEz28HbCazT gv/sfOwyh9RY/aiGp4ShDWw6/bVI0HxQOxv3mz9y+RkT8jRA0BuZE8SUNM+/U0bacCrx mctjiPwaJUsNagTSOtuTRWvFgvli2V4NmDgKgRfLAKvjin/AZbpLvKTCu/LStfH3Hmec 7cxlzXdgmmq8pOF3CHW/1J5SxLABtTkG4qfmdqpyb1ErbvrXzVvOmdMXBYVLC1OD85BF 3Fiw26L+dbhZ06sgDhTCTvz5ruNbDWVLkbKs5+CAhpmLgh3IfQL5hv7m4VDeDo7tkVVg Hf1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LKwxavEBodJ3OPwazuUaCUziZ6MQqRiwwFKpeAK3IrE=; b=HBBoByiPrJ1PVzAHMMC0LdLGo06/u8gXoNRrqSn2mmBJfUlOmxs7O6ORb3o3Eyn4nh L/INvzuD9DyR3GihOzu+u8g0ibmfGbS88jvb04eXW/5DvZe8QLQEyaa2NHSE/rpBGlFI ka5ukfRELfswFDFucHcQ3XUuGYwZbD/O2b9QFZCgQuFxMyn3snloTxJniuaza+KjHqEA xa7onfUkgtXVPGueQJs7Xr2SQm4+CnU2OsaqPpT3ti3Ulx6g61wtxjaBeucxTObHJF1C PP4UsF599mrfCD5O5P9qsaSZJkMSnWkWLIUqVjDHBWidP9lxiSfxYQ073WwD51+dEgwK i7PQ==
X-Gm-Message-State: APjAAAVwEjlAf4AYAH+qgXB5nsdz++FUcASf4+jBd4GTjELg9pGEftA7 4AWyNO5hG9YMJ0/EMmKQSXBtFm4jasYmFL16rr4=
X-Google-Smtp-Source: APXvYqzb7yh/Dui2LjwDzb8hMTPlNhoj/7oaqGexufNmdtR6xrsq/7VxcuEwjGoHUTOhCiwkt5LFExR3Hs545KzcRzM=
X-Received: by 2002:a5d:8451:: with SMTP id w17mr63532ior.226.1561488063907; Tue, 25 Jun 2019 11:41:03 -0700 (PDT)
MIME-Version: 1.0
References: <156148141106.31261.11148445355862352575@ietfa.amsl.com> <CAPDSy+5RSzULfPF71Uq-Jkrm7XH7Quj00_jZ9WcdpbaX3qk5bA@mail.gmail.com>
In-Reply-To: <CAPDSy+5RSzULfPF71Uq-Jkrm7XH7Quj00_jZ9WcdpbaX3qk5bA@mail.gmail.com>
From: Dan Romascanu <dromasca@gmail.com>
Date: Tue, 25 Jun 2019 21:40:51 +0300
Message-ID: <CAFgnS4Wmk9C1fVjMZa_Q0MXbSCoxd+fUDK62kKTJsdwHA8YROg@mail.gmail.com>
To: David Schinazi <dschinazi.ietf@gmail.com>
Cc: gen-art <gen-art@ietf.org>, draft-ietf-babel-dtls.all@ietf.org, IETF Discussion <ietf@ietf.org>, Babel at IETF <babel@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000005ec9ca058c2a454d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/yiydaMux2wdhLrIXSb9D0nyPYgI>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-babel-dtls-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jun 2019 18:41:06 -0000

Thanks for the quick reply.

See in-line.

regards,

Dan


On Tue, Jun 25, 2019 at 9:29 PM David Schinazi <dschinazi.ietf@gmail.com>
wrote:

> Hello Dan, and thanks for your review. Comments inline.
>
> 1. In section 2.1:
>>
>> > The default port
>>    for Babel over DTLS is registered with IANA as the "babel-dtls" port
>>    (UDP port TBD, see Section 4), and the port exchanging unencrypted
>>    Babel traffic is registered as the "babel" port (UDP port 6696).
>>
>> A reference would be desirable here.
>>
>
> What reference do you have in mind? This paragraph already has a
> reference to Section 4 (IANA Considerations).
>

the section in the Babel spec that defines the "babel" port (UDP port 6696,
see ....)



>
>> 2. In section 2.4
>>
>> > Nodes MUST silently ignore any unprotected
>>    packet sent over unicast.  When parsing an unprotected packet, a node
>>    MUST silently ignore all TLVs that are not of type Hello.  Nodes MUST
>>    also silently ignore any unprotected Hello with the Unicast flag set.
>>
>> Is the last sentence necessary? Is this case not covered by the statement
>> in
>> the first sentence?
>>
>
> The Unicast flag is a bit in the Babel packet. This statement instructs
> nodes
> to ignore a Hello TLV which was received over multicast but has the
> unicast flag set.
>

Thanks for the clarification.


> Thanks,
> David
>
>