Re: [Gen-art] Genart last call review of draft-ietf-httpbis-binary-message-04
Lars Eggert <lars@eggert.org> Thu, 16 June 2022 12:15 UTC
Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 868D6C14F741; Thu, 16 Jun 2022 05:15:46 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.108
X-Spam-Level:
X-Spam-Status: No, score=-2.108 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6shT34JhIIv9; Thu, 16 Jun 2022 05:15:43 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 970CBC14CF00; Thu, 16 Jun 2022 05:15:42 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:1c88:e8ae:82ba:5180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 97EB31F0943; Thu, 16 Jun 2022 15:15:16 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1655381716; bh=+DcXjg6Pd5BFE2Z2XFGqZafZZkRRqzBbOlTN3fVm6co=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=rASer9Mm1f0YKd8gnbC6jwjlij9Zl6PhXrWNU/tm8tPGG6UA7XWF5skZBn/i8kzzF ILOHOJwwy8nWH6j6I/Vw1ZHH4YkSVIVNrgviqzzipYKzEzLlTP/LEYzuInHhpIq2Lm VFnv971X3IrFD5518ywrDO7qK+bInhsR0NjyQ1Iw=
Content-Type: multipart/signed; boundary="Apple-Mail=_93576605-3015-4ABC-8141-60C9F38CCD40"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <165340077863.8642.7728497225957989470@ietfa.amsl.com>
Date: Thu, 16 Jun 2022 15:15:15 +0300
Cc: gen-art@ietf.org, draft-ietf-httpbis-binary-message.all@ietf.org, ietf-http-wg@w3.org, last-call@ietf.org
Message-Id: <4EB59E17-5AE1-48EE-A219-F36CCC6314D7@eggert.org>
References: <165340077863.8642.7728497225957989470@ietfa.amsl.com>
To: David Schinazi <dschinazi.ietf@gmail.com>
X-MailScanner-ID: 97EB31F0943.A32D5
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/gqkjrV46cP2NsjZXAHWDuKIU5Ec>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-httpbis-binary-message-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jun 2022 12:15:46 -0000
David, thank you for your review. I have entered a No Objection ballot for this document. Lars > On 2022-5-24, at 16:59, David Schinazi via Datatracker <noreply@ietf.org> wrote: > > Reviewer: David Schinazi > Review result: Ready with Issues > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > For more information, please see the FAQ at > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. > > Document: draft-ietf-httpbis-binary-message-04 > Reviewer: David Schinazi > Review Date: 2022-05-24 > IETF LC End Date: 2022-06-03 > IESG Telechat date: Not scheduled for a telechat > > Summary: Well written concise draft, apart from section 3 - see below. > > Major issues: None > > Minor issues: While this is an editorial comment, I'm raising it as a minor > issue because it significantly hampers comprehension in my mind. I find Section > 3 incredibly hard to reason about. In order to get to the actual format, the > reader is forced to repeatedly jump forward and backwards using a notepad to > track state. The draft seems somewhat akin to a game like Myst if you'll pardon > the analogy. I believe that this could be resolved by the editors without too > much work by doing the following: - keep the preface to Section 3 as-is, it > does a great job of introducing the concepts - split up the "Message with > Known-Length" diagram into two diagrams, one for known-length request and one > for known-length response - similarly split up "Indeterminate-Length Message" > diagram - reorder diagrams to avoid forward references, for example > "Known-Length Field Section" should appear before "Message with Known-Length" > since the latter relies on the former - define every field using a separate > bullet following the style from RFC 9000. Currently the draft uses the > notational conventions from RFC 9000 albeit incorrectly, for example > "Known-Length Informational Response" does not appear in all "Message with > Known-Length" structs but the square brackets indicating optionality are > missing. > > While this is fundamentally an editorial issue that is theoretically the > purview of the editors, such readability difficulties are worth discussing by > the GEN Area Director if they agree with this assessment. > > Nits/editorial comments: None > > > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Genart last call review of draft-ietf-h… David Schinazi via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Martin Thomson
- Re: [Gen-art] Genart last call review of draft-ie… David Schinazi
- Re: [Gen-art] Genart last call review of draft-ie… Lars Eggert