Re: [Gen-art] Genart last call review of draft-ietf-pals-ethernet-cw-06

Stewart Bryant <stewart.bryant@gmail.com> Mon, 02 July 2018 10:19 UTC

Return-Path: <stewart.bryant@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7D4DE130EB5; Mon, 2 Jul 2018 03:19:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TbHgGcSzV_nT; Mon, 2 Jul 2018 03:19:37 -0700 (PDT)
Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 83E50130DF4; Mon, 2 Jul 2018 03:19:37 -0700 (PDT)
Received: by mail-wm0-x22c.google.com with SMTP id n17-v6so8128076wmh.2; Mon, 02 Jul 2018 03:19:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=aus1NLv7lEFIlshY35dCW6eZ1nBDZivE+MwLtWolaWc=; b=fKQqEw+oFn49V3MTLH/IGlwKW+QiGARRn/YPQl0Okm2XgDz+l9aSEwVOqmmyswPIuA YfLQcO+K8weOjN5OIz3D4/ECvusm44igYChzc6DtCALxLdi6jupypHtBKnQnlOV3HoE+ mJeHAXCKRTPmIBJEj+qLE5O/47JkkEAEH9f9COy/2Tz7x1EELVOiCKEMWtUoAQOQsrNn /uHRMpNfIbgv86YRCXKQ7u3w0dEzVGMmKklH0i2ZnPFEVWlBtjlj+LO8PpuJiICqURZ2 OnFvoeIsF41Yz2fRes/drjdSKgjP9Weg7PH71jV4p/5O6+RZEdU5cTkyOFBRI5IuW1C+ m+Og==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=aus1NLv7lEFIlshY35dCW6eZ1nBDZivE+MwLtWolaWc=; b=W5R8GcPZWqS8kZgKsPsdwhKmZGIn4PQUkC+gUG/I52I/NlOUTSVlGC9107ZjRN1oF+ e+iDNL031LpsMveL4Nu+vE8TzILKMZ4q88DD1KQIiQqsa3SFapuwDrcJC6khJ7lOpr70 5GYPKpvcgggkDd+6eDzve/6Z9BuHYBXH2MDnq6JbgJQCBcTIw+iPXRxRHvw+vDhNvM8G fduLL8phpr5fyGBBG4I4+YXNPsDINZel7HBcb7/UL4fNL1kT2yYlILrBG1tk9oT8kcJS 677REZxqGx7rQ+fho49vPA164lsYr4ZxSY6UtFEuEh/uf436wrh2RKyXJjhQMOLGtHVg dfMw==
X-Gm-Message-State: APt69E1LbeL4Jis1ECY/BXUMTBNfV4HvDKzOSENjpZTjDa9CByMB23FS fGaiMfNOHxVQMM0Uk+EHUNE092aO
X-Google-Smtp-Source: AAOMgpciv1fD99PBpN5KrIBLqqERRp/7N245XDmAzufXVUQtywhqy5Oq4rtr4ZiAHz8FPOgn3xxEBg==
X-Received: by 2002:a1c:46c2:: with SMTP id t185-v6mr7529071wma.56.1530526775402; Mon, 02 Jul 2018 03:19:35 -0700 (PDT)
Received: from [192.168.2.105] (host213-123-124-182.in-addr.btopenworld.com. [213.123.124.182]) by smtp.gmail.com with ESMTPSA id 143-v6sm9861024wml.37.2018.07.02.03.19.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jul 2018 03:19:34 -0700 (PDT)
To: Brian Carpenter <brian.e.carpenter@gmail.com>, gen-art@ietf.org
Cc: draft-ietf-pals-ethernet-cw.all@ietf.org, pals@ietf.org
References: <152877425096.2652.654313340478370473@ietfa.amsl.com>
From: Stewart Bryant <stewart.bryant@gmail.com>
Message-ID: <d16739e8-1344-0d69-93d2-4309348cf1a0@gmail.com>
Date: Mon, 02 Jul 2018 11:19:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <152877425096.2652.654313340478370473@ietfa.amsl.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/iM13Jvgvx-Ib4tlwM71QsD3Q5XU>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-pals-ethernet-cw-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Jul 2018 10:19:40 -0000

Hi Brian

Thank you for your review comments. Please see inline.

On 12/06/2018 04:30, Brian Carpenter wrote:
> Reviewer: Brian Carpenter
> Review result: Ready with Nits
>
> Gen-ART Last Call review of draft-ietf-pals-ethernet-cw-06
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>
> Document: draft-ietf-pals-ethernet-cw-06.txt
> Reviewer: Brian Carpenter
> Review Date: 2018-06-12
> IETF LC End Date: 2018-06-15
> IESG Telechat date: 2018-06-21
>
> Summary: Ready with nits
> --------
>
> Comments:
> ---------
>
> This (with RFC4928) is a wonderful example of why layer violations are a Bad Thing.
>
> Nits:
> -----
>
>> 1.  Introduction
> ...
>>    This document recommends the use of the Ethernet pseudowire control
>>    word in all but exceptional circumstances.
> That's wrong, it *mandates* this usage with a MUST (first paragraph of section 4).

The text with the MUST is

"This document updates {{RFC4448}} to state that
where both the ingress PE and the egress PE support the Ethernet
pseudowire control word, then the CW MUST be used."

This is conditional on both equipments supporting the feature.

During WG discussion there was a lot of discussion on the degree to
which we would mandate the migration to CW.  The problem is that
the use of the CW has hardware implications. At one stage we went
so far as to recommend the the phasing out of equipment that could
not support the CW, but we got strong pushback from a specialist part
of the vendor community. This led us to a compromise position where
we RECOMMEND the use of the CW, but only  mandate that the CW be
used if it is available in the equipment used at both ends of
the PW.

>> 3.  Background
> ...
>>    A recent posting on the Nanog email list has highlighted this
>>    problem:
>>
>>    https://mailman.nanog.org/pipermail/nanog/2016-December/089395.html
> No, it's no longer recent. How about:
>
>     For example, a posting on the N email list highlighted this
>     problem:

I have changed the text to:

A posting on the NANOG email list highlighted this problem:


>
>> 7.  Operational Considerations
>>
>>    CW presence on the PW is controlled by the configuration and may be
>>    subject to default operational mode of not being enabled.
> That sentence is hard to parse. Try this:
>
>     A configuration switch might determine whether the CW is used on the PW.
>     The default configuration might be to disable use of the CW.
This now says:

In some cases, the inclusion of a CW in the PW is determined by
equipment configuration. Furthermore, it is possible that the default
configuration in such cases is  to disable use of the CW.

- Stewart