Re: [Gen-art] Gen-ART review of draft-ietf-isis-rfc6326bis-01
Donald Eastlake <d3e3e3@gmail.com> Mon, 20 January 2014 16:45 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 07E4F1A01C1 for <gen-art@ietfa.amsl.com>; Mon, 20 Jan 2014 08:45:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.75
X-Spam-Level:
X-Spam-Status: No, score=-1.75 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H68Q9TkaOLEs for <gen-art@ietfa.amsl.com>; Mon, 20 Jan 2014 08:45:27 -0800 (PST)
Received: from mail-oa0-x231.google.com (mail-oa0-x231.google.com [IPv6:2607:f8b0:4003:c02::231]) by ietfa.amsl.com (Postfix) with ESMTP id 7BC5D1A01BE for <gen-art@ietf.org>; Mon, 20 Jan 2014 08:45:27 -0800 (PST)
Received: by mail-oa0-f49.google.com with SMTP id i7so5570200oag.36 for <gen-art@ietf.org>; Mon, 20 Jan 2014 08:45:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=0WYVHmGd+du8UBk+AXywcUcIGZM4PaK7uTPvc1yHNys=; b=T8v7Q+epQLcCduH0ujiWuU4dP3VtKSkO4CQzZUnzo+G2Zrfk9ijiigMovSxzBJmblZ 8E4QMDF3JEgdwgzChreILYO+pInJO1js/TWjdMIsHYXWbylxL0SIDb66p1Qvkzjya2N1 1Ah5n9QnB9aa96+joMdaQBOBQsbXV+LFb2UnVbwjIyDgHLtAXbqp9QXQOSbg6CxZWeey Vnk/vZpaUAuRhgVN5M/lK0kgqV/dzWrcGpsgE2JdG3W43UKUCnNxmt/wNXqG154FfNuM niwMiSRB3Q4xLfvXmKOzWF3pXeoIBnEsWUiHZXfX3Mf1iFK7ZvnRlFX+N4GZJYEyYnTX xKAg==
X-Received: by 10.182.114.132 with SMTP id jg4mr16664409obb.29.1390236327407; Mon, 20 Jan 2014 08:45:27 -0800 (PST)
MIME-Version: 1.0
Received: by 10.76.33.102 with HTTP; Mon, 20 Jan 2014 08:45:07 -0800 (PST)
In-Reply-To: <52DD04AE.8070604@isode.com>
References: <52DD04AE.8070604@isode.com>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Mon, 20 Jan 2014 11:45:07 -0500
Message-ID: <CAF4+nEFuPdVmyqa5x0QwFOysLB14eGzPM8gLRy6wb4yMXuzLJw@mail.gmail.com>
To: Alexey Melnikov <alexey.melnikov@isode.com>
Content-Type: text/plain; charset="ISO-8859-1"
Cc: "gen-art@ietf.org Review Team" <gen-art@ietf.org>, draft-ietf-isis-rfc6326bis.all@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-isis-rfc6326bis-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jan 2014 16:45:29 -0000
Hi Alexey, Thanks for your review, see below: On Mon, Jan 20, 2014 at 6:12 AM, Alexey Melnikov <alexey.melnikov@isode.com> wrote: > I am the assigned Gen-ART reviewer for this draft. For background on > Gen-ART, please see the FAQ at > <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. > > Please resolve these comments along with any other Last Call > comments you may receive. > > Document: draft-ietf-isis-rfc6326bis-01 > Reviewer: Alexey Melnikov > Review Date: 2014-01-20 > IETF LC End Date: 2014-01-22 > IESG Telechat date: 2014-01-23 > > > Summary: This draft is nearly ready for publication as a standard track RFC. > > Major issues: None > > Minor issues: > > o Label: This carries the fine-grained label identifier for all > subsequent MAC addresses in this sub-TLV, or the value zero if no > label is specified. > > I fully admit ignorance of the topic, but what is exactly > "fine-grained label" and where is the exact format defined? If it is > defined later in the document, can you please add a forward > reference. If it is defined in another document, can you please add > a reference to that. Fine grained labels are specified in draft-ietf-trill-fine-labeling-07, which is an approved standard track draft in the RFC Editor's queue. Adding a reference to it here would be good. > In Sections 2.2.4 and 2.3.1: > > What are the requirements on backward compatibility between different > versions of TRILL. Are TLVs formats supported for a version N also valid for > version N+M? If you have any implied assumptions, please state them in the > document. There are no explicit requirements. Incremental changes and improvements are generally handed with capability bits or the presence/absence of data strucutres in control messages. A version change would probably indicate a pretty major modification but, since these version numbers are within IS-IS TLVs, I would say that implicitly the intent is to stay with the IS-IS PDU structure for the control plane. Thanks, Donald ============================= Donald E. Eastlake 3rd +1-508-333-2270 (cell) 155 Beaver Street, Milford, MA 01757 USA d3e3e3@gmail.com > Nits/editorial comments: None
- [Gen-art] Gen-ART review of draft-ietf-isis-rfc63… Alexey Melnikov
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Donald Eastlake
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Alexey Melnikov
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Jari Arkko
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Donald Eastlake
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Jari Arkko