Re: [Gen-art] Gen-ART review of draft-ietf-isis-rfc6326bis-01
Donald Eastlake <d3e3e3@gmail.com> Tue, 21 January 2014 23:21 UTC
Return-Path: <d3e3e3@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 144BB1A01BB for <gen-art@ietfa.amsl.com>; Tue, 21 Jan 2014 15:21:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.75
X-Spam-Level:
X-Spam-Status: No, score=-1.75 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MvO_yHbzCCdX for <gen-art@ietfa.amsl.com>; Tue, 21 Jan 2014 15:21:27 -0800 (PST)
Received: from mail-oa0-x230.google.com (mail-oa0-x230.google.com [IPv6:2607:f8b0:4003:c02::230]) by ietfa.amsl.com (Postfix) with ESMTP id 6088A1A017A for <gen-art@ietf.org>; Tue, 21 Jan 2014 15:21:25 -0800 (PST)
Received: by mail-oa0-f48.google.com with SMTP id l6so5218834oag.35 for <gen-art@ietf.org>; Tue, 21 Jan 2014 15:21:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=C8lQiRp2UolSBl1DuLyLPh4wd70+Me2gKmU1CC0+qss=; b=Q8/GPBaHw7OzahZSygXfnbvzt7Z3VDXjPim3kLl0AaXgW/nDxiS29Aql0cLD5CQmN1 YO9b54xrrujPBmSxD6hFZyoTSTHIvHAGyq6TU3bj/RxgAWKFpocETBGrah1bldarTd/U TLhyYmswyphO81w7Esqeuw6K9mGbA6c+H+ze7Wwgoo3ZQJwjexNZvUb13Ja5qPsjih1O MoLYXvZ0Q2Ma8/Hzw9B9+8wojh53YxWqQJ8vviacxqn1f8m3NxWPs99ycpcfadJKb8ZR oETo55XOp2owSHRFK+UnHcyNYoPzZSa6pwlD4NpIiel/M3dAGyeIzwmFG9BW7D6FSemN 2DGQ==
X-Received: by 10.60.37.33 with SMTP id v1mr23429416oej.2.1390346485000; Tue, 21 Jan 2014 15:21:25 -0800 (PST)
MIME-Version: 1.0
Received: by 10.76.33.102 with HTTP; Tue, 21 Jan 2014 15:21:04 -0800 (PST)
In-Reply-To: <90658F23-325C-44A0-93A3-429E5FFF5C7B@piuha.net>
References: <52DD04AE.8070604@isode.com> <CAF4+nEFuPdVmyqa5x0QwFOysLB14eGzPM8gLRy6wb4yMXuzLJw@mail.gmail.com> <52DD66D7.7020107@isode.com> <90658F23-325C-44A0-93A3-429E5FFF5C7B@piuha.net>
From: Donald Eastlake <d3e3e3@gmail.com>
Date: Tue, 21 Jan 2014 18:21:04 -0500
Message-ID: <CAF4+nEHnM_LTroNHuZXXzVEH+Och19F+5AU19P6yGqpNOtxQnA@mail.gmail.com>
To: Jari Arkko <jari.arkko@piuha.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: "gen-art@ietf.org Review Team" <gen-art@ietf.org>, draft-ietf-isis-rfc6326bis.all@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-isis-rfc6326bis-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jan 2014 23:21:29 -0000
Hi Jari, On Tue, Jan 21, 2014 at 5:01 PM, Jari Arkko <jari.arkko@piuha.net> wrote: > Thanks for your review, Alexey! And thank you Donald for considering the comments. I have placed a no-obj position on the ballot for this Thursday's IESG telechat. But I do think Alexey raised valid points and I expect the draft to be revised. Will you take care of that, Donald? I have a version ready to post with some minor editorial fixes and the like and would be happy to include the missing reference to draft-ietf-trill-fine-labeling; however, I would prefer not to include the somewhat hand-waving text I wrote about TRILL protocol version number and I am not sure how long it would take to come up with a good statement on that... Thanks, Donald ============================= Donald E. Eastlake 3rd +1-508-333-2270 (cell) 155 Beaver Street, Milford, MA 01757 USA d3e3e3@gmail.com > Jari > > On Jan 20, 2014, at 8:11 PM, Alexey Melnikov <alexey.melnikov@isode.com> wrote: > >> Hi Donald, >> >> On 20/01/2014 16:45, Donald Eastlake wrote: >>> Hi Alexey, >>> >>> Thanks for your review, see below: >>> >>> On Mon, Jan 20, 2014 at 6:12 AM, Alexey Melnikov >>> <alexey.melnikov@isode.com> wrote: >>>> I am the assigned Gen-ART reviewer for this draft. For background on >>>> Gen-ART, please see the FAQ at >>>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. >>>> >>>> Please resolve these comments along with any other Last Call >>>> comments you may receive. >>>> >>>> Document: draft-ietf-isis-rfc6326bis-01 >>>> Reviewer: Alexey Melnikov >>>> Review Date: 2014-01-20 >>>> IETF LC End Date: 2014-01-22 >>>> IESG Telechat date: 2014-01-23 >>>> >>>> >>>> Summary: This draft is nearly ready for publication as a standard track RFC. >>>> >>>> Major issues: None >>>> >>>> Minor issues: >>>> >>>> o Label: This carries the fine-grained label identifier for all >>>> subsequent MAC addresses in this sub-TLV, or the value zero if no >>>> label is specified. >>>> >>>> I fully admit ignorance of the topic, but what is exactly >>>> "fine-grained label" and where is the exact format defined? If it is >>>> defined later in the document, can you please add a forward >>>> reference. If it is defined in another document, can you please add >>>> a reference to that. >>> Fine grained labels are specified in draft-ietf-trill-fine-labeling-07, >>> which is an approved standard track draft in the RFC Editor's >>> queue. Adding a reference to it here would be good. >> Sounds great. Thanks. >>>> In Sections 2.2.4 and 2.3.1: >>>> >>>> What are the requirements on backward compatibility between different >>>> versions of TRILL. Are TLVs formats supported for a version N also valid for >>>> version N+M? If you have any implied assumptions, please state them in the >>>> document. >>> There are no explicit requirements. Incremental changes and >>> improvements are generally handed with capability bits or the >>> presence/absence of data strucutres in control messages. A version >>> change would probably indicate a pretty major modification but, since >>> these version numbers are within IS-IS TLVs, I would say that >>> implicitly the intent is to stay with the IS-IS PDU structure for the >>> control plane. >> I think the document should state that. Also, if you want any messages to be unchanged (fully or partially) irrespectively of version numbers, you should state that too. >> >> Best Regards, >> Alexey >> >> _______________________________________________ >> Gen-art mailing list >> Gen-art@ietf.org >> https://www.ietf.org/mailman/listinfo/gen-art >
- [Gen-art] Gen-ART review of draft-ietf-isis-rfc63… Alexey Melnikov
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Donald Eastlake
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Alexey Melnikov
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Jari Arkko
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Donald Eastlake
- Re: [Gen-art] Gen-ART review of draft-ietf-isis-r… Jari Arkko