Re: [Gen-art] review of draft-ietf-sidrops-bgpsec-rollover-02.txt

"Brian Weis (bew)" <bew@cisco.com> Tue, 10 October 2017 00:25 UTC

Return-Path: <bew@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 88D1B13307F; Mon, 9 Oct 2017 17:25:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.521
X-Spam-Level:
X-Spam-Status: No, score=-14.521 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LeVLaeh_h1Gp; Mon, 9 Oct 2017 17:25:08 -0700 (PDT)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DC5E713301E; Mon, 9 Oct 2017 17:25:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3814; q=dns/txt; s=iport; t=1507595107; x=1508804707; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=BcW1eB55q3BAA5njAb/G+12SQefBgC6xBw+MYnof6Rc=; b=NSlBhB60e/Ma3qyYmhZBda1AmhsRvKNSGoLOzYZ6wKRgqSKuVFQItgX3 qw7sw7I6gn+ozNbPsNqPcQbXmzOhFyhZib2z+YIX6Pwe10pu+S1mC539E R183W1D3fGeocCUbkeOLc3rslEtyU0QmwUVw0NEJU9U/RxRsJpU7bkGaW 0=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CaAACcEtxZ/4wNJK1ZAxkBAQEBAQEBAQEBAQcBAQEBAYNdZG4nB4Nzih+RapYvDoIECiOFGAIahCA/GAECAQEBAQEBAWsohRgBAQEBAgEjBA1FBQsCAQgQBAQCAiYCAgIwFRACBA4FiigIEKgKgW06iycBAQEBAQEBAQEBAQEBAQEBAQEBAQEYBYEOgh+CAoM7K4J+hFEBCwcBBxgXChcCDYJML4IyBaE1Aodcg2GJKIIUhW+LCIoXixYCERkBgTgBHziBAwt4FVsBhwp2hUMPGIEMgRABAQE
X-IronPort-AV: E=Sophos;i="5.42,502,1500940800"; d="scan'208";a="303824601"
Received: from alln-core-7.cisco.com ([173.36.13.140]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 10 Oct 2017 00:25:06 +0000
Received: from XCH-RTP-004.cisco.com (xch-rtp-004.cisco.com [64.101.220.144]) by alln-core-7.cisco.com (8.14.5/8.14.5) with ESMTP id v9A0P6Ku012371 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Tue, 10 Oct 2017 00:25:06 GMT
Received: from xch-rtp-001.cisco.com (64.101.220.141) by XCH-RTP-004.cisco.com (64.101.220.144) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 9 Oct 2017 20:25:05 -0400
Received: from xch-rtp-001.cisco.com ([64.101.220.141]) by XCH-RTP-001.cisco.com ([64.101.220.141]) with mapi id 15.00.1320.000; Mon, 9 Oct 2017 20:25:05 -0400
From: "Brian Weis (bew)" <bew@cisco.com>
To: Francis Dupont <Francis.Dupont@fdupont.fr>
CC: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-sidrops-bgpsec-rollover.all@ietf.org" <draft-ietf-sidrops-bgpsec-rollover.all@ietf.org>
Thread-Topic: review of draft-ietf-sidrops-bgpsec-rollover-02.txt
Thread-Index: AQHTQQXT0T7y5GrPoEKVVJ93CKbGQ6LcfY2A
Date: Tue, 10 Oct 2017 00:25:05 +0000
Message-ID: <291E54C5-7BC9-42F7-BAE9-182A21275A3B@cisco.com>
References: <201710091332.v99DWF92085778@givry.fdupont.fr>
In-Reply-To: <201710091332.v99DWF92085778@givry.fdupont.fr>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.32.173.58]
Content-Type: text/plain; charset="utf-8"
Content-ID: <FFE6A6A3DEAA714F8B36FD207655CCAE@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/jQlA1hDpEJS4CPuxaFCcJLqEC74>
Subject: Re: [Gen-art] review of draft-ietf-sidrops-bgpsec-rollover-02.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Oct 2017 00:25:09 -0000

Hi Francis,

Thanks for your review. I’ve addressed the nits as you’ve suggest, although there are a couple of notes inline.

> On Oct 9, 2017, at 6:32 AM, Francis Dupont <Francis.Dupont@fdupont.fr> wrote:
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-sidrops-bgpsec-rollover-02.txt
> Reviewer: Francis Dupont
> Review Date: 20171007
> IETF LC End Date: 20171017
> IESG Telechat date: unknown
> 
> Summary: Ready
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments: 
> IMHO the language itself needs some improvements. Unfortunately I am not
> a native English writer so I can only be a limited help...
> 
> - Abstract page 1: bad wording in
>  "... certificates BGPsec router certificates"
> 
> - Abstract page 1: Normal -> normal
> 
> - Abstract page 1: "creating" does not fit in grammar. Perhaps
>  "which create”?

BEW: I’ve made this much simpler and removed “create” altogether:

  “The  rollover must be carefully managed in order to synchronize the
   distribution of router public keys with BGPsec Update messages
   verified with those router public keys."

> 
> - Abstract page 1: I suggest accomplished -> performed
>  (this point is typical of why a native English writer will really help)
> 
> - ToC page 2 and 4/4.2 page 7: titles of 4 and 4.2 are too close

BEW: I’m not sure what I can do here, and looking at the .txt file I don’t see the spacing issue. I’ve used xml2rfc, which chooses the way titles are spaced. Can you clarify?
> 
> - ToC page 2 and 7 page 9: Acknowledgements -> Acknowledgments
> 
> - 2 page 2: I suggest
>  the local policies of a network. -> the local policies of network.

BEW: How about "This process will need to happen at regular intervals, normally due to policies of the local network.”?

> 
> - 2 page 3: as the 2119 lowe case keyword issue is now solved you may
>  use "may" as in "documents may reference" but perhaps with an upgrade
>  to the standard 2119 reference text. I am asking to the gen-art what
>  to do (and I expect to get an answer before the LC).

BEW: Thanks, will wait for guidance.

Thanks,
Brian

> 
> - 2 page 3, 3.1 and 4 page 6:
>   roll-over -> rollover (i.e. keep one spelling)
> 
> - 4.2 page 7: i.e. -> i.e.,
> 
> Regards
> 
> Francis.Dupont@fdupont.fr

-- 
Brian Weis
Security, CSG, Cisco Systems
Telephone: +1 408 526 4796
Email: bew@cisco.com