Re: [Gen-art] review of draft-ietf-sidrops-bgpsec-rollover-02.txt

Alissa Cooper <alissa@cooperw.in> Wed, 29 November 2017 21:23 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E18D41270A7; Wed, 29 Nov 2017 13:23:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.721
X-Spam-Level:
X-Spam-Status: No, score=-2.721 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=hRtIqtQf; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=R2rzG6Vd
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8Pg43sdwq4JS; Wed, 29 Nov 2017 13:23:49 -0800 (PST)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 734B7126BFD; Wed, 29 Nov 2017 13:23:46 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BBD3E20C14; Wed, 29 Nov 2017 16:23:45 -0500 (EST)
Received: from frontend1 ([10.202.2.160]) by compute7.internal (MEProxy); Wed, 29 Nov 2017 16:23:45 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=X1AS/6erHUtmVWHGGkg27YQjTYu+R Uhp7eFPxe3hoKM=; b=hRtIqtQfCvpAP4fjWecOLpt7+rSNGLeoqrXxs2+TU/Kr0 6qzfvtjNeW6hOhOQZIEXOOznKWLgkRe09622ZHxyo2GeRXbD8Q5ifJAo75ze//CY u3tR7wdU+f2UO/ExrgoeHqTB+/3XfFriJBcWTs6XXbw4vyQCvbkOvGIDHMJ02LzJ uqzZsm/gt9tz6DbWQwm8nRjMCHoK5KptB4wqwS2FoT7SarWCTkNlc/xNP1uXGtlE M4LldgDRFUxL3BJmXVYfjqzAyQjj3Vifwe20YUyCpJrJz636xhAV7oNZjMQypmLp EVp57r4A/UlruRKnL/KKR9sq0UjIbDRA9ECJ2YsFA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=X1AS/6 erHUtmVWHGGkg27YQjTYu+RUhp7eFPxe3hoKM=; b=R2rzG6VdV5M9+aIaBZOfM3 F9ZvcSwKrduTfUSrfeo5wZSgh1AlQT57aWKm7wsZZ929DuEnYAaxghZeJqyQqbhh 09vK4c5eYCyznTWBv2E1Egfa/QX90m4yVlytd2rtEjWatKfGQUcSM2t4S7PMDN14 y8/QZ5hgzT3wCH/BeQWq8r8oviCkCIgWMCWao38vYDPX7Un2hsxshf1KXTynZKiu FBJTIwKOG6xz7tPqwPSRKx/+uRpQDgEgtO1N25isGYqlqKyUmkoru1Z41nMPEbQp ByxT7jlEo7KvaJRoFG6hNS1X3yevULtQzpStqPuTriVkm0eOsyVXu3yJd2grNmzg ==
X-ME-Sender: <xms:YSUfWvpFqRU21BxJTTsoaUWgy9lG8N1fbG0eUpFdPY7Q1feDbF9CMg>
Received: from sjc-alcoop-8816.cisco.com (unknown [128.107.241.191]) by mail.messagingengine.com (Postfix) with ESMTPA id BAD907FAE5; Wed, 29 Nov 2017 16:23:44 -0500 (EST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <291E54C5-7BC9-42F7-BAE9-182A21275A3B@cisco.com>
Date: Wed, 29 Nov 2017 16:23:42 -0500
Cc: Francis Dupont <Francis.Dupont@fdupont.fr>, "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-sidrops-bgpsec-rollover.all@ietf.org" <draft-ietf-sidrops-bgpsec-rollover.all@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <316DF910-2AF9-4ECD-82B1-B24F79FF4D3E@cooperw.in>
References: <201710091332.v99DWF92085778@givry.fdupont.fr> <291E54C5-7BC9-42F7-BAE9-182A21275A3B@cisco.com>
To: "Brian Weis (bew)" <bew@cisco.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/An58W5hYkSBHT5zP3iXtDX4bh9A>
Subject: Re: [Gen-art] review of draft-ietf-sidrops-bgpsec-rollover-02.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Nov 2017 21:23:52 -0000

Francis, thanks for your review. Brian, thanks for your response. I have entered a No Objection ballot.

Personally I think the usage of “may” in Section 2 is fine.

Alissa


> On Oct 9, 2017, at 8:25 PM, Brian Weis (bew) <bew@cisco.com> wrote:
> 
> Hi Francis,
> 
> Thanks for your review. I’ve addressed the nits as you’ve suggest, although there are a couple of notes inline.
> 
>> On Oct 9, 2017, at 6:32 AM, Francis Dupont <Francis.Dupont@fdupont.fr> wrote:
>> 
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>> 
>> For more information, please see the FAQ at
>> 
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>> 
>> Document: draft-ietf-sidrops-bgpsec-rollover-02.txt
>> Reviewer: Francis Dupont
>> Review Date: 20171007
>> IETF LC End Date: 20171017
>> IESG Telechat date: unknown
>> 
>> Summary: Ready
>> 
>> Major issues: None
>> 
>> Minor issues: None
>> 
>> Nits/editorial comments: 
>> IMHO the language itself needs some improvements. Unfortunately I am not
>> a native English writer so I can only be a limited help...
>> 
>> - Abstract page 1: bad wording in
>> "... certificates BGPsec router certificates"
>> 
>> - Abstract page 1: Normal -> normal
>> 
>> - Abstract page 1: "creating" does not fit in grammar. Perhaps
>> "which create”?
> 
> BEW: I’ve made this much simpler and removed “create” altogether:
> 
>  “The  rollover must be carefully managed in order to synchronize the
>   distribution of router public keys with BGPsec Update messages
>   verified with those router public keys."
> 
>> 
>> - Abstract page 1: I suggest accomplished -> performed
>> (this point is typical of why a native English writer will really help)
>> 
>> - ToC page 2 and 4/4.2 page 7: titles of 4 and 4.2 are too close
> 
> BEW: I’m not sure what I can do here, and looking at the .txt file I don’t see the spacing issue. I’ve used xml2rfc, which chooses the way titles are spaced. Can you clarify?
>> 
>> - ToC page 2 and 7 page 9: Acknowledgements -> Acknowledgments
>> 
>> - 2 page 2: I suggest
>> the local policies of a network. -> the local policies of network.
> 
> BEW: How about "This process will need to happen at regular intervals, normally due to policies of the local network.”?
> 
>> 
>> - 2 page 3: as the 2119 lowe case keyword issue is now solved you may
>> use "may" as in "documents may reference" but perhaps with an upgrade
>> to the standard 2119 reference text. I am asking to the gen-art what
>> to do (and I expect to get an answer before the LC).
> 
> BEW: Thanks, will wait for guidance.
> 
> Thanks,
> Brian
> 
>> 
>> - 2 page 3, 3.1 and 4 page 6:
>>  roll-over -> rollover (i.e. keep one spelling)
>> 
>> - 4.2 page 7: i.e. -> i.e.,
>> 
>> Regards
>> 
>> Francis.Dupont@fdupont.fr
> 
> -- 
> Brian Weis
> Security, CSG, Cisco Systems
> Telephone: +1 408 526 4796
> Email: bew@cisco.com
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art